mirror of
https://github.com/OPM/ResInsight.git
synced 2026-10-16 10:22:15 -05:00
Add readability-simplify-boolean-expr
* Add readability-simplify-boolean-expr * Fixes based on review
This commit is contained in:
1 parent
34d83efaed
commit
59ca0b943c
116 files changed
+179
-635
No files matched your search
+1
-3
@@ -41,9 +41,7 @@ bool RicAppendSummaryPlotsForSummaryCasesFeature::isCommandEnabled()
|
||||
auto cases = selectedCases();
|
||||
auto ensembles = selectedEnsembles();
|
||||
|
||||
if ( cases.empty() && ensembles.empty() ) return false;
|
||||
|
||||
return true;
|
||||
return !( cases.empty() && ensembles.empty() );
|
||||
}
|
||||
|
||||
//--------------------------------------------------------------------------------------------------
|
||||
|
||||
@@ -48,9 +48,7 @@ bool RicNewSummaryMultiPlotFeature::isCommandEnabled()
|
||||
|
||||
std::vector<RimSummaryCase*> selectedIndividualSummaryCases;
|
||||
std::vector<RimSummaryCaseCollection*> selectedEnsembles;
|
||||
if ( selectedCases( &selectedIndividualSummaryCases, &selectedEnsembles ) ) return true;
|
||||
|
||||
return false;
|
||||
return selectedCases( &selectedIndividualSummaryCases, &selectedEnsembles );
|
||||
}
|
||||
|
||||
//--------------------------------------------------------------------------------------------------
|
||||
@@ -124,10 +122,5 @@ bool RicNewSummaryMultiPlotFeature::selectedCases( std::vector<RimSummaryCase*>*
|
||||
}
|
||||
// Second try selected summary cases
|
||||
caf::SelectionManager::instance()->objectsByTypeStrict( selectedIndividualSummaryCases );
|
||||
if ( !selectedIndividualSummaryCases->empty() )
|
||||
{
|
||||
return true;
|
||||
}
|
||||
|
||||
return false;
|
||||
return !selectedIndividualSummaryCases->empty();
|
||||
}
|
||||
Reference in new issue
Block a user