From 5afdeac10612b4fcd33d6d6cd163043ad7dec8f7 Mon Sep 17 00:00:00 2001 From: Magne Sjaastad Date: Thu, 18 Jun 2026 13:54:23 +0200 Subject: [PATCH] #14241 MSW: Update stale comments referencing deleted legacy classes Remove references to the deleted RicMswItem/RicMswBranch/RicMswSegment tree and the removed collectWelsegsData collection functions from code comments in the geometry-based MSW export path. --- .../MswExport/RicMswBranchBuilder.cpp | 4 ++-- .../MswExport/RicMswBranchBuilder.h | 2 +- .../MswExport/RicWellPathExportMswGeometryPath.cpp | 8 +++----- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/ApplicationLibCode/Commands/CompletionExportCommands/MswExport/RicMswBranchBuilder.cpp b/ApplicationLibCode/Commands/CompletionExportCommands/MswExport/RicMswBranchBuilder.cpp index bdfc905f92..1a2276a9d8 100644 --- a/ApplicationLibCode/Commands/CompletionExportCommands/MswExport/RicMswBranchBuilder.cpp +++ b/ApplicationLibCode/Commands/CompletionExportCommands/MswExport/RicMswBranchBuilder.cpp @@ -670,8 +670,8 @@ std::vector buildFractureBranchesFromGeometry( RimEclipseCase* seg.outletSegmentNumber = outletSeg; seg.length = length; seg.depth = depth; - seg.diameter = 0.15; // RicMswSegment default (tree approach uses same value) - seg.roughness = 5.0e-5; // RicMswSegment default (tree approach uses same value) + seg.diameter = 0.15; // default segment diameter + seg.roughness = 5.0e-5; // default segment roughness seg.sourceWellName = wellPath->name().toStdString(); seg.description = fracture->name().toStdString(); seg.intersections = std::move( compsegs ); diff --git a/ApplicationLibCode/Commands/CompletionExportCommands/MswExport/RicMswBranchBuilder.h b/ApplicationLibCode/Commands/CompletionExportCommands/MswExport/RicMswBranchBuilder.h index a88a6768e3..747c2a0651 100644 --- a/ApplicationLibCode/Commands/CompletionExportCommands/MswExport/RicMswBranchBuilder.h +++ b/ApplicationLibCode/Commands/CompletionExportCommands/MswExport/RicMswBranchBuilder.h @@ -37,7 +37,7 @@ class RimPerforationInterval; //-------------------------------------------------------------------------------------------------- /// Free functions that build RigMswSegment lists directly from well-path geometry and Rim -/// completion objects — without creating the intermediate RicMswBranch / RicMswItem tree. +/// completion objects. /// /// Extracted from the former `internal` anonymous namespace in RicWellPathExportMswGeometryPath.cpp /// so that they can be called from other translation units and unit-tested in isolation. diff --git a/ApplicationLibCode/Commands/CompletionExportCommands/MswExport/RicWellPathExportMswGeometryPath.cpp b/ApplicationLibCode/Commands/CompletionExportCommands/MswExport/RicWellPathExportMswGeometryPath.cpp index d06b5ce98d..b26ca558bb 100644 --- a/ApplicationLibCode/Commands/CompletionExportCommands/MswExport/RicWellPathExportMswGeometryPath.cpp +++ b/ApplicationLibCode/Commands/CompletionExportCommands/MswExport/RicWellPathExportMswGeometryPath.cpp @@ -258,8 +258,7 @@ std::vector buildLateralBranches( RimEclipseCase* } //-------------------------------------------------------------------------------------------------- -/// Build MSW export data directly from well-path geometry and Rim completion objects, -/// without building the RicMswBranch / RicMswItem tree. +/// Build MSW export data directly from well-path geometry and Rim completion objects. /// /// Currently implemented: main-bore WELSEGS segments + perforation COMPSEGS entries. /// TODO: valve completions (ICD/AICD/SICD/ICV), fishbones laterals, fractures, tie-in wells. @@ -437,9 +436,8 @@ RigMswWellExportData buildMswWellExportData( RimEclipseCase* } //-------------------------------------------------------------------------------------------------- -/// Populate RigMswTableData from a pre-built RigMswWellExportData. -/// This replaces the recursive tree-based collection functions (collectWelsegsData etc.) with -/// simple iteration over RigMswSegment objects. +/// Populate RigMswTableData from a pre-built RigMswWellExportData by simple iteration over +/// RigMswSegment objects. //-------------------------------------------------------------------------------------------------- RigMswTableData collectTableData( const RigMswWellExportData& exportData, RiaDefines::EclipseUnitSystem unitSystem ) {