#964 Improve code robustness in defineEditorAttribute

ApplicationCode/Application/RiaPreferences.cpp

@@ -113,7 +113,7 @@ void RiaPreferences::defineEditorAttribute(const caf::PdmFieldHandle* field, QSt
 
     if (field == &scriptDirectories)
     {
-        caf::PdmUiFilePathEditorAttribute* myAttr = static_cast<caf::PdmUiFilePathEditorAttribute*>(attribute);
+        caf::PdmUiFilePathEditorAttribute* myAttr = dynamic_cast<caf::PdmUiFilePathEditorAttribute*>(attribute);
         if (myAttr)
         {
             myAttr->m_selectDirectory = true;
@@ -129,7 +129,7 @@ void RiaPreferences::defineEditorAttribute(const caf::PdmFieldHandle* field, QSt
             field == &showLasCurveWithoutTvdWarning ||
             field == &autoCreatePlotsOnImport)
     {
-        caf::PdmUiCheckBoxEditorAttribute* myAttr = static_cast<caf::PdmUiCheckBoxEditorAttribute*>(attribute);
+        caf::PdmUiCheckBoxEditorAttribute* myAttr = dynamic_cast<caf::PdmUiCheckBoxEditorAttribute*>(attribute);
         if (myAttr)
         {
             myAttr->m_useNativeCheckBoxLabel = true;

ApplicationCode/Application/RiaRegressionTest.cpp

@@ -51,7 +51,7 @@ void RiaRegressionTest::defineEditorAttribute(const caf::PdmFieldHandle* field,
 {
     if (field == &applicationWorkingFolder || field == &regressionTestFolder)
     {
-        caf::PdmUiFilePathEditorAttribute* myAttr = static_cast<caf::PdmUiFilePathEditorAttribute*>(attribute);
+        caf::PdmUiFilePathEditorAttribute* myAttr = dynamic_cast<caf::PdmUiFilePathEditorAttribute*>(attribute);
         if (myAttr)
         {
             myAttr->m_selectDirectory = true;

ApplicationCode/Commands/RicExportToLasFileResampleUi.cpp

@@ -121,7 +121,7 @@ void RicExportToLasFileResampleUi::defineEditorAttribute(const caf::PdmFieldHand
 {
     if (field == &exportFolder)
     {
-        caf::PdmUiFilePathEditorAttribute* myAttr = static_cast<caf::PdmUiFilePathEditorAttribute*>(attribute);
+        caf::PdmUiFilePathEditorAttribute* myAttr = dynamic_cast<caf::PdmUiFilePathEditorAttribute*>(attribute);
         if (myAttr)
         {
             myAttr->m_selectDirectory = true;
@@ -130,7 +130,7 @@ void RicExportToLasFileResampleUi::defineEditorAttribute(const caf::PdmFieldHand
 
     if (field == &exportTvdrkb || field == &activateResample)
     {
-        caf::PdmUiCheckBoxEditorAttribute* myAttr = static_cast<caf::PdmUiCheckBoxEditorAttribute*>(attribute);
+        caf::PdmUiCheckBoxEditorAttribute* myAttr = dynamic_cast<caf::PdmUiCheckBoxEditorAttribute*>(attribute);
         if (myAttr)
         {
             myAttr->m_useNativeCheckBoxLabel = true;

ApplicationCode/FileInterface/RifReaderSettings.cpp

@@ -52,7 +52,7 @@ void RifReaderSettings::defineEditorAttribute(const caf::PdmFieldHandle* field,
         field == &importAdvancedMswData ||
         field == &importNNCs)
     {
-        caf::PdmUiCheckBoxEditorAttribute* myAttr = static_cast<caf::PdmUiCheckBoxEditorAttribute*>(attribute);
+        caf::PdmUiCheckBoxEditorAttribute* myAttr = dynamic_cast<caf::PdmUiCheckBoxEditorAttribute*>(attribute);
         if (myAttr)
         {
             myAttr->m_useNativeCheckBoxLabel = true;

ApplicationCode/ProjectDataModel/RimBinaryExportSettings.cpp

@@ -43,7 +43,7 @@ void RimBinaryExportSettings::defineEditorAttribute(const caf::PdmFieldHandle* f
 {
     if (field == &fileName)
     {
-        caf::PdmUiFilePathEditorAttribute* myAttr = static_cast<caf::PdmUiFilePathEditorAttribute*>(attribute);
+        caf::PdmUiFilePathEditorAttribute* myAttr = dynamic_cast<caf::PdmUiFilePathEditorAttribute*>(attribute);
         if (myAttr)
         {
             myAttr->m_selectSaveFileName = true;

ApplicationCode/ProjectDataModel/RimCellRangeFilter.cpp

@@ -171,7 +171,7 @@ RimCellRangeFilterCollection* RimCellRangeFilter::parentContainer()
 //--------------------------------------------------------------------------------------------------
 void RimCellRangeFilter::defineEditorAttribute(const caf::PdmFieldHandle* field, QString uiConfigName, caf::PdmUiEditorAttribute * attribute)
 {
-    caf::PdmUiSliderEditorAttribute* myAttr = static_cast<caf::PdmUiSliderEditorAttribute*>(attribute);
+    caf::PdmUiSliderEditorAttribute* myAttr = dynamic_cast<caf::PdmUiSliderEditorAttribute*>(attribute);
     if (!myAttr || !parentContainer())
     {
         return;

ApplicationCode/ProjectDataModel/RimEclipseStatisticsCase.cpp

@@ -613,14 +613,20 @@ void RimEclipseStatisticsCase::defineEditorAttribute(const caf::PdmFieldHandle*
     if (&m_selectionSummary == field)
     {
         caf::PdmUiTextEditorAttribute* textEditAttrib = dynamic_cast<caf::PdmUiTextEditorAttribute*> (attribute);
+        if (textEditAttrib)
+        {
             textEditAttrib->textMode = caf::PdmUiTextEditorAttribute::HTML;
         }
+    }
 
     if (&m_calculateEditCommand == field)
     {
         caf::PdmUiPushButtonEditorAttribute* attrib = dynamic_cast<caf::PdmUiPushButtonEditorAttribute*> (attribute);
+        if (attrib)
+        {
             attrib->m_buttonText = hasComputedStatistics() ? "Edit (Will DELETE current results)": "Compute";
         }
+    }
 }
 
 //--------------------------------------------------------------------------------------------------

ApplicationCode/ProjectDataModel/RimExportInputPropertySettings.cpp

@@ -42,7 +42,7 @@ void RimExportInputSettings::defineEditorAttribute(const caf::PdmFieldHandle* fi
 {
     if (field == &fileName)
     {
-        caf::PdmUiFilePathEditorAttribute* myAttr = static_cast<caf::PdmUiFilePathEditorAttribute*>(attribute);
+        caf::PdmUiFilePathEditorAttribute* myAttr = dynamic_cast<caf::PdmUiFilePathEditorAttribute*>(attribute);
         if (myAttr)
         {
             myAttr->m_selectSaveFileName = true;

ApplicationCode/ProjectDataModel/RimIntersection.cpp

@@ -553,6 +553,8 @@ void RimIntersection::defineEditorAttribute(const caf::PdmFieldHandle* field, QS
     {
         caf::PdmUiPushButtonEditorAttribute* attrib = dynamic_cast<caf::PdmUiPushButtonEditorAttribute*> (attribute);
 
+        if (attrib)
+        {
             if (inputPolyLineFromViewerEnabled)
             {
                 attrib->m_buttonText = "Stop picking points";
@@ -562,6 +564,7 @@ void RimIntersection::defineEditorAttribute(const caf::PdmFieldHandle* field, QS
                 attrib->m_buttonText = "Start picking points";
             }
         }
+    }
     else if (field == &m_userPolyline)
     {
         caf::PdmUiListEditorAttribute* myAttr = dynamic_cast<caf::PdmUiListEditorAttribute*>(attribute);
@@ -574,6 +577,8 @@ void RimIntersection::defineEditorAttribute(const caf::PdmFieldHandle* field, QS
     {
         caf::PdmUiPushButtonEditorAttribute* attrib = dynamic_cast<caf::PdmUiPushButtonEditorAttribute*> (attribute);
 
+        if (attrib)
+        {
             if (inputExtrusionPointsFromViewerEnabled)
             {
                 attrib->m_buttonText = "Stop picking points";
@@ -583,6 +588,7 @@ void RimIntersection::defineEditorAttribute(const caf::PdmFieldHandle* field, QS
                 attrib->m_buttonText = "Start picking points";
             }
         }
+    }
     else if (field == &m_customExtrusionPoints)
     {
         caf::PdmUiListEditorAttribute* myAttr = dynamic_cast<caf::PdmUiListEditorAttribute*>(attribute);

ApplicationCode/ProjectDataModel/RimIntersectionBox.cpp

@@ -404,6 +404,8 @@ void RimIntersectionBox::defineEditorAttribute(const caf::PdmFieldHandle* field,
     {
         caf::PdmUiPushButtonEditorAttribute* attrib = dynamic_cast<caf::PdmUiPushButtonEditorAttribute*> (attribute);
 
+        if (attrib)
+        {
             if (m_show3DManipulator)
             {
                 attrib->m_buttonText = "Hide 3D manipulator";
@@ -413,6 +415,8 @@ void RimIntersectionBox::defineEditorAttribute(const caf::PdmFieldHandle* field,
                 attrib->m_buttonText = "Show 3D manipulator";
             }
         }
+
+    }
 }
 
 //--------------------------------------------------------------------------------------------------

ApplicationCode/ProjectDataModel/RimScriptCollection.cpp

@@ -187,7 +187,10 @@ void RimScriptCollection::defineEditorAttribute(const caf::PdmFieldHandle* field
 {
     if (field == &directory)
     {
-        caf::PdmUiFilePathEditorAttribute* myAttr = static_cast<caf::PdmUiFilePathEditorAttribute*>(attribute);
+        caf::PdmUiFilePathEditorAttribute* myAttr = dynamic_cast<caf::PdmUiFilePathEditorAttribute*>(attribute);
+        if (myAttr)
+        {
             myAttr->m_selectDirectory = true;
         }
+    }
 }

ApplicationCode/ProjectDataModel/Summary/RimSummaryCurveFilter.cpp

@@ -423,8 +423,11 @@ void RimSummaryCurveFilter::defineEditorAttribute(const caf::PdmFieldHandle* fie
     if(&m_applyButtonField == field)
     {
         caf::PdmUiPushButtonEditorAttribute* attrib = dynamic_cast<caf::PdmUiPushButtonEditorAttribute*> (attribute);
+        if (attrib)
+        {
             attrib->m_buttonText = "Apply";
         }
+    }
 }
 
 //--------------------------------------------------------------------------------------------------

ApplicationCode/ProjectDataModel/Summary/RimSummaryPlot.cpp

@@ -984,7 +984,7 @@ void RimSummaryPlot::defineEditorAttribute(const caf::PdmFieldHandle* field, QSt
 {
     if (field == &m_showLegend || field == &m_showPlotTitle)
     {
-        caf::PdmUiCheckBoxEditorAttribute* myAttr = static_cast<caf::PdmUiCheckBoxEditorAttribute*>(attribute);
+        caf::PdmUiCheckBoxEditorAttribute* myAttr = dynamic_cast<caf::PdmUiCheckBoxEditorAttribute*>(attribute);
         if (myAttr)
         {
             myAttr->m_useNativeCheckBoxLabel = true;