OilfieldToolsNet/ResInsight
4
0
Fork 0
mirror of https://github.com/OPM/ResInsight.git synced 2025-02-25 18:55:39 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixes detected by cppcheck (#4974)

Browse Source 
* Janitor : Remove obsolete pointer to dialog

* Janitor : Remove unused functions

* Janitor : Remove unused functions

* Janitor : Add explicit to constructors

* Janitor : Remove unused variables

* Janitor : Remove unused functions related to summary plot templates

* clang-tidy : Use nullptr instead of 0

* clang-tidy : Fix usage of virtual and override

* Upped to version 2019.08.2-dev.05

* Janitor : Remove unused variables

* Janitor : Clean up several cppcheck issues

* Janitor : Add cppcheck config files

* Janitor : Use const when possible
This commit is contained in:
Magne Sjaastad
2019-11-03 08:37:03 +01:00
committed by GitHub
parent 18eee02bb1
commit 67e7bb0cf3
64 changed files with 159 additions and 282 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ApplicationCode/ReservoirDataModel/RigCaseRealizationParameters.cpp
View File

@@ -155,7 +155,8 @@ size_t RigCaseRealizationParameters::parameterHash( const QString& name ) const
}
QString s = QString::number( nameHash ) + QString::number( valueHash );
return stringHasher( ( QString::number( nameHash ) + QString::number( valueHash ) ).toStdString() );
return stringHasher( s.toStdString() );
}
//--------------------------------------------------------------------------------------------------
@@ -191,7 +192,7 @@ void RigCaseRealizationParameters::calculateParametersHash( const std::set<QStri
}
else
{
for ( auto paramName : paramNames )
for ( const auto& paramName : paramNames )
{
if ( m_parameters.find( paramName ) == m_parameters.end() ) return;
hashes.push_back( QString::number( parameterHash( paramName ) ) );