OilfieldToolsNet/ResInsight
4
0
Fork 0
mirror of https://github.com/OPM/ResInsight.git synced 2025-02-25 18:55:39 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fixes detected by cppcheck (#4974)

Browse Source 
* Janitor : Remove obsolete pointer to dialog

* Janitor : Remove unused functions

* Janitor : Remove unused functions

* Janitor : Add explicit to constructors

* Janitor : Remove unused variables

* Janitor : Remove unused functions related to summary plot templates

* clang-tidy : Use nullptr instead of 0

* clang-tidy : Fix usage of virtual and override

* Upped to version 2019.08.2-dev.05

* Janitor : Remove unused variables

* Janitor : Clean up several cppcheck issues

* Janitor : Add cppcheck config files

* Janitor : Use const when possible
This commit is contained in:
Magne Sjaastad
2019-11-03 08:37:03 +01:00
committed by GitHub
parent 18eee02bb1
commit 67e7bb0cf3
64 changed files with 159 additions and 282 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
ApplicationCode/UserInterface/RiuGridPlotWindow.cpp
View File

@@ -686,7 +686,7 @@ void RiuGridPlotWindow::clearGridLayout()
}
QLayoutItem* item;
while ( ( item = m_gridLayout->takeAt( 0 ) ) != 0 )
while ( ( item = m_gridLayout->takeAt( 0 ) ) != nullptr )
{
}
QWidget().setLayout( m_gridLayout );

5
ApplicationCode/UserInterface/RiuGridStatisticsHistogramWidget.cpp
View File

@@ -52,6 +52,9 @@ void RiuGridStatisticsHistogramWidget::paintEvent( QPaintEvent* event )
this->draw( &painter, 0, 0, this->width() - 1, this->height() - 1 );
}
//--------------------------------------------------------------------------------------------------
///
//--------------------------------------------------------------------------------------------------
void RiuGridStatisticsHistogramWidget::draw( QPainter* painter, int x, int y, int width, int height )
{
// Initialize variables
@@ -63,11 +66,9 @@ void RiuGridStatisticsHistogramWidget::draw( QPainter* painter, int x, int y, in
QRect r1( x, y, width, height );
// Frame around it all;
QColor windowColor = palette().color( QPalette::Window ); // QColor(144, 173, 208, 180);
QColor frameColor = palette().color( QPalette::WindowText ); // QColor(220, 240, 255, 100);
QColor foregroundColor = palette().color( QPalette::Dark ); // QColor(100, 141, 189);
// painter->fillRect(r1, windowColor);
painter->setPen( frameColor );
painter->drawRect( r1 );

5
ApplicationCode/UserInterface/RiuSimpleHistogramWidget.cpp
View File

@@ -56,6 +56,9 @@ void RiuSimpleHistogramWidget::paintEvent( QPaintEvent* event )
this->draw( &painter, 0, 0, this->width() - 1, this->height() - 1 );
}
//--------------------------------------------------------------------------------------------------
///
//--------------------------------------------------------------------------------------------------
void RiuSimpleHistogramWidget::draw( QPainter* painter, int x, int y, int width, int height )
{
// Initialize variables
@@ -67,11 +70,9 @@ void RiuSimpleHistogramWidget::draw( QPainter* painter, int x, int y, int width,
QRect r1( x, y, width, height );
// Frame around it all;
QColor windowColor = palette().color( QPalette::Window ); // QColor(144, 173, 208, 180);
QColor frameColor = palette().color( QPalette::Midlight ); // QColor(220, 240, 255, 100);
QColor foregroundColor = palette().color( QPalette::Dark ); // QColor(100, 141, 189);
// painter->fillRect(r1, windowColor);
painter->setPen( frameColor );
painter->drawRect( r1 );

1
ApplicationCode/UserInterface/RiuSummaryCurveDefSelection.cpp
View File

@@ -575,7 +575,6 @@ void RiuSummaryCurveDefSelection::setDefaultSelection( const std::vector<Summary
{
RimProject* proj = RiaApplication::instance()->project();
auto allSumCases = proj->allSummaryCases();
auto allSumGroups = proj->summaryGroups();
if ( allSumCases.size() > 0 )
{

2
ApplicationCode/UserInterface/RiuViewerCommands.cpp
View File

@@ -243,8 +243,6 @@ void RiuViewerCommands::displayContextMenu( QMouseEvent* event )
break;
}
cvf::Vec3d displayModelOffset = cvf::Vec3d::ZERO;
if ( mainOrComparisonView )
{
cvf::ref<caf::DisplayCoordTransform> transForm = mainOrComparisonView->displayCoordTransform();