CppCheck : Make sure all variables are initialized in constructor

This commit is contained in:
Magne Sjaastad
2018-12-21 11:30:29 +01:00
parent 8bc8ac5e58
commit 6b952add64
4 changed files with 15 additions and 11 deletions

View File

@@ -246,9 +246,11 @@ RigCompletionData::CompletionType RicMswPerforationICV::completionType() const
//-------------------------------------------------------------------------------------------------- //--------------------------------------------------------------------------------------------------
/// ///
//-------------------------------------------------------------------------------------------------- //--------------------------------------------------------------------------------------------------
RicMswPerforationAICD::RicMswPerforationAICD(const QString& label, RicMswPerforationAICD::RicMswPerforationAICD(const QString& label, const RimWellPathValve* wellPathValve)
const RimWellPathValve* wellPathValve)
: RicMswValve(label, wellPathValve) : RicMswValve(label, wellPathValve)
, m_valid(false)
, m_deviceOpen(false)
, m_length(0.0)
{ {
} }

View File

@@ -178,4 +178,4 @@ private:
bool m_deviceOpen; bool m_deviceOpen;
std::array<double, AICD_NUM_PARAMS> m_parameters; std::array<double, AICD_NUM_PARAMS> m_parameters;
double m_length; double m_length;
}; };

View File

@@ -19,18 +19,20 @@
#include "RimViewNameConfig.h" #include "RimViewNameConfig.h"
//================================================================================================== //==================================================================================================
/// ///
/// ///
//================================================================================================== //==================================================================================================
CAF_PDM_SOURCE_INIT(RimViewNameConfig, "RimViewNameConfig"); CAF_PDM_SOURCE_INIT(RimViewNameConfig, "RimViewNameConfig");
//-------------------------------------------------------------------------------------------------- //--------------------------------------------------------------------------------------------------
/// ///
//-------------------------------------------------------------------------------------------------- //--------------------------------------------------------------------------------------------------
RimViewNameConfig::RimViewNameConfig(const RimNameConfigHolderInterface* configHolder) RimViewNameConfig::RimViewNameConfig(const RimNameConfigHolderInterface* configHolder)
: RimNameConfig(configHolder) : RimNameConfig(configHolder)
, m_hideCaseNameField(false)
, m_hideAggregationTypeField(false) , m_hideAggregationTypeField(false)
, m_hidePropertyField(false)
, m_hideSampleSpacingField(false) , m_hideSampleSpacingField(false)
{ {
CAF_PDM_InitObject("View Name Generator", "", "", ""); CAF_PDM_InitObject("View Name Generator", "", "", "");
@@ -156,8 +158,8 @@ void RimViewNameConfig::hideSampleSpacingField(bool hide)
void RimViewNameConfig::defineUiOrdering(QString uiConfigName, caf::PdmUiOrdering& uiOrdering) void RimViewNameConfig::defineUiOrdering(QString uiConfigName, caf::PdmUiOrdering& uiOrdering)
{ {
RimNameConfig::defineUiOrdering(uiConfigName, uiOrdering); RimNameConfig::defineUiOrdering(uiConfigName, uiOrdering);
if(!m_hideCaseNameField) uiOrdering.add(&m_addCaseName); if (!m_hideCaseNameField) uiOrdering.add(&m_addCaseName);
if(!m_hideAggregationTypeField) uiOrdering.add(&m_addAggregationType); if (!m_hideAggregationTypeField) uiOrdering.add(&m_addAggregationType);
if(!m_hidePropertyField) uiOrdering.add(&m_addProperty); if (!m_hidePropertyField) uiOrdering.add(&m_addProperty);
if(!m_hideSampleSpacingField) uiOrdering.add(&m_addSampleSpacing); if (!m_hideSampleSpacingField) uiOrdering.add(&m_addSampleSpacing);
} }

View File

@@ -29,7 +29,7 @@ class RimViewNameConfig : public RimNameConfig
CAF_PDM_HEADER_INIT; CAF_PDM_HEADER_INIT;
public: public:
RimViewNameConfig(const RimNameConfigHolderInterface* configHolder = nullptr); explicit RimViewNameConfig(const RimNameConfigHolderInterface* configHolder = nullptr);
void setAddCaseName(bool add); void setAddCaseName(bool add);
bool addCaseName() const; bool addCaseName() const;