Added more clang-tidy checks

Improved GitHub Action to run clang-format as part of clang-tidy

* Simplify clang-tidy workflow
* Added modernize-use-using, modernize-redundant-void-arg, readability-static-accessed-through-instance
* Add nolint for libecl typedefs
This commit is contained in:
Magne Sjaastad
2023-04-14 14:07:45 +02:00
committed by GitHub
parent 457dc9080f
commit 6f6dc80bc6
118 changed files with 220 additions and 225 deletions

View File

@@ -29,7 +29,7 @@
class RiaColorTables
{
public:
typedef std::map<RiaDefines::WellPathComponentType, cvf::Color3::ColorIdent> WellPathComponentColors;
using WellPathComponentColors = std::map<RiaDefines::WellPathComponentType, cvf::Color3::ColorIdent>;
static const caf::ColorTable& normalPaletteColors();
static const caf::ColorTable& normalPaletteOppositeOrderingColors();

View File

@@ -34,7 +34,7 @@ class QDateTime;
class RiaCurveDataTools
{
public:
typedef std::vector<std::pair<size_t, size_t>> CurveIntervals;
using CurveIntervals = std::vector<std::pair<size_t, size_t>>;
enum class ErrorAxis
{

View File

@@ -38,7 +38,7 @@ template <typename XValueType>
class RiaCurveMerger
{
public:
typedef XValueComparator<XValueType> XComparator;
using XComparator = XValueComparator<XValueType>;
RiaCurveMerger();
void addCurveData( const std::vector<XValueType>& xValues, const std::vector<double>& yValues );
@@ -78,7 +78,7 @@ private:
std::vector<std::vector<double>> m_interpolatedValuesForAllCurves;
};
typedef RiaCurveMerger<time_t> RiaTimeHistoryCurveMerger;
using RiaTimeHistoryCurveMerger = RiaCurveMerger<time_t>;
template <>
bool XValueComparator<double>::equals( const double& lhs, const double& rhs );

View File

@@ -21,14 +21,14 @@
#include <fstream>
#include <iostream>
RiaImageCompareReporter::RiaImageCompareReporter( void )
RiaImageCompareReporter::RiaImageCompareReporter()
{
m_showOriginal = true;
m_showGenerated = true;
m_showInteractiveDiff = false;
}
RiaImageCompareReporter::~RiaImageCompareReporter( void )
RiaImageCompareReporter::~RiaImageCompareReporter()
{
}

View File

@@ -33,7 +33,7 @@ class RifReaderSettings;
class RiaImportEclipseCaseTools
{
public:
typedef std::map<QString, int> FileCaseIdMap;
using FileCaseIdMap = std::map<QString, int>;
static bool openEclipseCasesFromFile( const QStringList& fileNames,
bool createView,