Added more clang-tidy checks

Improved GitHub Action to run clang-format as part of clang-tidy

* Simplify clang-tidy workflow
* Added modernize-use-using, modernize-redundant-void-arg, readability-static-accessed-through-instance
* Add nolint for libecl typedefs
This commit is contained in:
Magne Sjaastad
2023-04-14 14:07:45 +02:00
committed by GitHub
parent 457dc9080f
commit 6f6dc80bc6
118 changed files with 220 additions and 225 deletions

View File

@@ -76,8 +76,8 @@ class RimFracture : public RimCheckableNamedObject, public Rim3dPropertiesInterf
CAF_PDM_HEADER_INIT;
public:
RimFracture( void );
~RimFracture( void ) override;
RimFracture();
~RimFracture() override;
double perforationLength() const;
double perforationEfficiency() const;

View File

@@ -39,7 +39,7 @@ CAF_PDM_SOURCE_INIT( RimSimWellFracture, "SimWellFracture" );
//--------------------------------------------------------------------------------------------------
///
//--------------------------------------------------------------------------------------------------
RimSimWellFracture::RimSimWellFracture( void )
RimSimWellFracture::RimSimWellFracture()
{
CAF_PDM_InitObject( "SimWellFracture", ":/FractureSymbol16x16.png" );

View File

@@ -32,8 +32,8 @@ class RimSimWellFracture : public RimFracture
CAF_PDM_HEADER_INIT;
public:
RimSimWellFracture( void );
~RimSimWellFracture( void ) override;
RimSimWellFracture();
~RimSimWellFracture() override;
void setClosestWellCoord( cvf::Vec3d& position, size_t branchIndex );

View File

@@ -26,7 +26,7 @@ CAF_PDM_SOURCE_INIT( RimSimWellFractureCollection, "SimWellFractureCollection" )
//--------------------------------------------------------------------------------------------------
///
//--------------------------------------------------------------------------------------------------
RimSimWellFractureCollection::RimSimWellFractureCollection( void )
RimSimWellFractureCollection::RimSimWellFractureCollection()
{
CAF_PDM_InitObject( "Fractures", ":/FractureLayout16x16.png" );

View File

@@ -33,8 +33,8 @@ class RimSimWellFractureCollection : public caf::PdmObject
CAF_PDM_HEADER_INIT;
public:
RimSimWellFractureCollection( void );
~RimSimWellFractureCollection( void ) override;
RimSimWellFractureCollection();
~RimSimWellFractureCollection() override;
caf::PdmChildArrayField<RimSimWellFracture*> simwellFractures;

View File

@@ -55,7 +55,7 @@ protected:
void defineUiTreeOrdering( caf::PdmUiTreeOrdering& uiTreeOrdering, QString uiConfigName = "" ) override;
private:
typedef caf::AppEnum<RiaDefines::WellPathComponentType> CompletionTypeEnum;
using CompletionTypeEnum = caf::AppEnum<RiaDefines::WellPathComponentType>;
caf::PdmField<caf::AppEnum<RiaDefines::EclipseUnitSystem>> m_valveTemplateUnit;

View File

@@ -36,7 +36,7 @@ public:
WATER,
LIQUID
};
typedef caf::AppEnum<WellType> WellTypeEnum;
using WellTypeEnum = caf::AppEnum<WellType>;
enum GasInflowEquation
{
@@ -45,21 +45,21 @@ public:
DRY_GAS_PSEUDO_PRESSURE,
GENERALIZED_PSEUDO_PRESSURE
};
typedef caf::AppEnum<GasInflowEquation> GasInflowEnum;
using GasInflowEnum = caf::AppEnum<GasInflowEquation>;
enum AutomaticWellShutIn
{
ISOLATE_FROM_FORMATION,
STOP_ABOVE_FORMATION
};
typedef caf::AppEnum<AutomaticWellShutIn> AutomaticWellShutInEnum;
using AutomaticWellShutInEnum = caf::AppEnum<AutomaticWellShutIn>;
enum HydrostaticDensity
{
SEGMENTED,
AVERAGED
};
typedef caf::AppEnum<HydrostaticDensity> HydrostaticDensityEnum;
using HydrostaticDensityEnum = caf::AppEnum<HydrostaticDensity>;
public:
RimWellPathCompletionSettings();

View File

@@ -33,7 +33,7 @@ CAF_PDM_SOURCE_INIT( RimWellPathFracture, "WellPathFracture" );
//--------------------------------------------------------------------------------------------------
///
//--------------------------------------------------------------------------------------------------
RimWellPathFracture::RimWellPathFracture( void )
RimWellPathFracture::RimWellPathFracture()
{
CAF_PDM_InitObject( "Fracture", ":/FractureSymbol16x16.png" );

View File

@@ -36,8 +36,8 @@ class RimWellPathFracture : public RimFracture
CAF_PDM_HEADER_INIT;
public:
RimWellPathFracture( void );
~RimWellPathFracture( void ) override;
RimWellPathFracture();
~RimWellPathFracture() override;
double fractureMD() const override;
void setMeasuredDepth( double mdValue );

View File

@@ -28,7 +28,7 @@ CAF_PDM_SOURCE_INIT( RimWellPathFractureCollection, "WellPathFractureCollection"
//--------------------------------------------------------------------------------------------------
///
//--------------------------------------------------------------------------------------------------
RimWellPathFractureCollection::RimWellPathFractureCollection( void )
RimWellPathFractureCollection::RimWellPathFractureCollection()
{
CAF_PDM_InitObject( "Fractures", ":/FractureLayout16x16.png" );

View File

@@ -38,8 +38,8 @@ class RimWellPathFractureCollection : public RimCheckableNamedObject
CAF_PDM_HEADER_INIT;
public:
RimWellPathFractureCollection( void );
~RimWellPathFractureCollection( void ) override;
RimWellPathFractureCollection();
~RimWellPathFractureCollection() override;
bool hasFractures() const;
void addFracture( RimWellPathFracture* fracture );