OilfieldToolsNet/ResInsight
4
0
Fork 0
mirror of https://github.com/OPM/ResInsight.git synced 2025-02-25 18:55:39 -06:00
Code Issues Packages Projects Releases Wiki Activity

Added more clang-tidy checks

Browse Source 
Improved GitHub Action to run clang-format as part of clang-tidy

* Simplify clang-tidy workflow
* Added modernize-use-using, modernize-redundant-void-arg, readability-static-accessed-through-instance
* Add nolint for libecl typedefs
This commit is contained in:
Magne Sjaastad
2023-04-14 14:07:45 +02:00
committed by GitHub
parent 457dc9080f
commit 6f6dc80bc6
118 changed files with 220 additions and 225 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ApplicationLibCode/ProjectDataModel/GeoMech/RimGeoMechCellColors.cpp
View File

@@ -29,7 +29,7 @@ CAF_PDM_SOURCE_INIT( RimGeoMechCellColors, "GeoMechResultSlot" );
//--------------------------------------------------------------------------------------------------
///
//--------------------------------------------------------------------------------------------------
RimGeoMechCellColors::RimGeoMechCellColors( void )
RimGeoMechCellColors::RimGeoMechCellColors()
: legendConfigChanged( this )
{
CAF_PDM_InitFieldNoDefault( &legendConfig, "LegendDefinition", "Color Legend" );
@@ -41,7 +41,7 @@ RimGeoMechCellColors::RimGeoMechCellColors( void )
//--------------------------------------------------------------------------------------------------
///
//--------------------------------------------------------------------------------------------------
RimGeoMechCellColors::~RimGeoMechCellColors( void )
RimGeoMechCellColors::~RimGeoMechCellColors()
{
delete legendConfig;
}

4
ApplicationLibCode/ProjectDataModel/GeoMech/RimGeoMechCellColors.h
View File

@@ -39,8 +39,8 @@ public:
caf::Signal<RimLegendConfigChangeType> legendConfigChanged;
public:
RimGeoMechCellColors( void );
~RimGeoMechCellColors( void ) override;
RimGeoMechCellColors();
~RimGeoMechCellColors() override;
caf::PdmChildField<RimRegularLegendConfig*> legendConfig;

2
ApplicationLibCode/ProjectDataModel/GeoMech/RimGeoMechContourMapProjection.h
View File

@@ -58,7 +58,7 @@ public:
double sampleSpacing() const override;
protected:
typedef RimContourMapProjection::CellIndexAndResult CellIndexAndResult;
using CellIndexAndResult = RimContourMapProjection::CellIndexAndResult;
// GeoMech implementation specific data generation methods
cvf::ref<cvf::UByteArray> getCellVisibility() const override;

6
ApplicationLibCode/ProjectDataModel/GeoMech/RimGeoMechContourMapView.cpp
View File

@@ -301,7 +301,7 @@ void RimGeoMechContourMapView::appendContourMapProjectionToModel()
if ( frameScene )
{
cvf::String name = "ContourMapProjection";
this->removeModelByName( frameScene, name );
RimGeoMechContourMapView::removeModelByName( frameScene, name );
cvf::ref<cvf::ModelBasicList> contourMapProjectionModelBasicList = new cvf::ModelBasicList;
contourMapProjectionModelBasicList->setName( name );
@@ -326,7 +326,7 @@ void RimGeoMechContourMapView::appendContourLinesToModel()
if ( frameScene )
{
cvf::String name = "ContourMapLines";
this->removeModelByName( frameScene, name );
RimGeoMechContourMapView::removeModelByName( frameScene, name );
cvf::ref<cvf::ModelBasicList> contourMapLabelModelBasicList = new cvf::ModelBasicList;
contourMapLabelModelBasicList->setName( name );
@@ -351,7 +351,7 @@ void RimGeoMechContourMapView::appendPickPointVisToModel()
if ( frameScene )
{
cvf::String name = "ContourMapPickPoint";
this->removeModelByName( frameScene, name );
RimGeoMechContourMapView::removeModelByName( frameScene, name );
cvf::ref<cvf::ModelBasicList> contourMapProjectionModelBasicList = new cvf::ModelBasicList;
contourMapProjectionModelBasicList->setName( name );

4
ApplicationLibCode/ProjectDataModel/GeoMech/RimGeoMechModels.cpp
View File

@@ -32,7 +32,7 @@ CAF_PDM_SOURCE_INIT( RimGeoMechModels, "ResInsightGeoMechModels" );
//--------------------------------------------------------------------------------------------------
///
//--------------------------------------------------------------------------------------------------
RimGeoMechModels::RimGeoMechModels( void )
RimGeoMechModels::RimGeoMechModels()
{
CAF_PDM_InitObject( "Geomechanical Models", ":/GeoMechCases48x48.png" );
@@ -43,7 +43,7 @@ RimGeoMechModels::RimGeoMechModels( void )
//--------------------------------------------------------------------------------------------------
///
//--------------------------------------------------------------------------------------------------
RimGeoMechModels::~RimGeoMechModels( void )
RimGeoMechModels::~RimGeoMechModels()
{
}

4
ApplicationLibCode/ProjectDataModel/GeoMech/RimGeoMechModels.h
View File

@@ -35,8 +35,8 @@ class RimGeoMechModels : public caf::PdmObject
CAF_PDM_HEADER_INIT;
public:
RimGeoMechModels( void );
~RimGeoMechModels( void ) override;
RimGeoMechModels();
~RimGeoMechModels() override;
RimGeoMechCase* copyCase( RimGeoMechCase* thecase, const QString& newInputFileName );
void removeCase( RimGeoMechCase* thecase );

4
ApplicationLibCode/ProjectDataModel/GeoMech/RimGeoMechResultDefinition.cpp
View File

@@ -74,7 +74,7 @@ CAF_PDM_SOURCE_INIT( RimGeoMechResultDefinition, "GeoMechResultDefinition" );
//--------------------------------------------------------------------------------------------------
///
//--------------------------------------------------------------------------------------------------
RimGeoMechResultDefinition::RimGeoMechResultDefinition( void )
RimGeoMechResultDefinition::RimGeoMechResultDefinition()
{
CAF_PDM_InitObject( "Color Result", ":/CellResult.png" );
@@ -124,7 +124,7 @@ RimGeoMechResultDefinition::RimGeoMechResultDefinition( void )
//--------------------------------------------------------------------------------------------------
///
//--------------------------------------------------------------------------------------------------
RimGeoMechResultDefinition::~RimGeoMechResultDefinition( void )
RimGeoMechResultDefinition::~RimGeoMechResultDefinition()
{
}

4
ApplicationLibCode/ProjectDataModel/GeoMech/RimGeoMechResultDefinition.h
View File

@@ -46,8 +46,8 @@ class RimGeoMechResultDefinition : public RimFemResultObserver, public RimChecka
CAF_PDM_HEADER_INIT;
public:
RimGeoMechResultDefinition( void );
~RimGeoMechResultDefinition( void ) override;
RimGeoMechResultDefinition();
~RimGeoMechResultDefinition() override;
void setGeoMechCase( RimGeoMechCase* geomCase );
RimGeoMechCase* geoMechCase() const;

10
ApplicationLibCode/ProjectDataModel/GeoMech/RimGeoMechView.cpp
View File

@@ -84,7 +84,7 @@ CAF_PDM_SOURCE_INIT( RimGeoMechView, "GeoMechView" );
//--------------------------------------------------------------------------------------------------
///
//--------------------------------------------------------------------------------------------------
RimGeoMechView::RimGeoMechView( void )
RimGeoMechView::RimGeoMechView()
: m_currentInternalTimeStep( 0 )
, m_currentDataFrameIndex( -1 )
{
@@ -125,7 +125,7 @@ RimGeoMechView::RimGeoMechView( void )
//--------------------------------------------------------------------------------------------------
///
//--------------------------------------------------------------------------------------------------
RimGeoMechView::~RimGeoMechView( void )
RimGeoMechView::~RimGeoMechView()
{
m_geomechCase = nullptr;
@@ -423,7 +423,7 @@ void RimGeoMechView::onUpdateDisplayModelForCurrentTimeStep()
{
// Grid model
cvf::String name = "GridModel";
this->removeModelByName( frameScene, name );
RimGeoMechView::removeModelByName( frameScene, name );
cvf::ref<cvf::ModelBasicList> frameParts = new cvf::ModelBasicList;
frameParts->setName( name );
@@ -436,7 +436,7 @@ void RimGeoMechView::onUpdateDisplayModelForCurrentTimeStep()
// Well Paths
{
cvf::String name = "WellPathMod";
this->removeModelByName( frameScene, name );
RimGeoMechView::removeModelByName( frameScene, name );
cvf::ref<cvf::ModelBasicList> wellPathModelBasicList = new cvf::ModelBasicList;
wellPathModelBasicList->setName( name );
@@ -450,7 +450,7 @@ void RimGeoMechView::onUpdateDisplayModelForCurrentTimeStep()
{
// Tensors
cvf::String name = "Tensor";
this->removeModelByName( frameScene, name );
RimGeoMechView::removeModelByName( frameScene, name );
cvf::ref<cvf::ModelBasicList> frameParts = new cvf::ModelBasicList;
frameParts->setName( name );

4
ApplicationLibCode/ProjectDataModel/GeoMech/RimGeoMechView.h
View File

@@ -63,8 +63,8 @@ class RimGeoMechView : public RimGridView
CAF_PDM_HEADER_INIT;
public:
RimGeoMechView( void );
~RimGeoMechView( void ) override;
RimGeoMechView();
~RimGeoMechView() override;
RiaDefines::View3dContent viewContent() const override;