Revert "#4018 Result management : Use ensureReservoirCaseIsOpen instead of open..."

This reverts commit fde60d1e34.

ApplicationCode/CommandFileInterface/RicfExportProperty.cpp

@@ -71,12 +71,15 @@ void RicfExportProperty::execute()
             return;
         }
 
-        if (!eclipseCase->ensureReservoirCaseIsOpen())
+        if (!eclipseCase->eclipseCaseData())
+        {
+            if (!eclipseCase->openReserviorCase())
             {
                 RiaLogging::error(QString("exportProperty: Could not find eclipseCaseData with ID %1").arg(m_caseId()));
                 return;
             }
         }
+    }
 
     RigEclipseCaseData* eclipseCaseData = eclipseCase->eclipseCaseData();
 

ApplicationCode/ProjectDataModel/RimEclipseCase.h

@@ -70,6 +70,7 @@ public:
     void                                        setFilesContainingFaults(const std::vector<QString>& val);
 
     bool                                        ensureReservoirCaseIsOpen();
+    bool                                        openReserviorCase();
     virtual bool                                openEclipseGridFile() = 0;
                                                       
     RigEclipseCaseData*                         eclipseCaseData();
@@ -131,7 +132,6 @@ protected:
 private:
     void                                        createTimeStepFormatString();
     std::vector<Rim3dView*>             allSpecialViews() const override;
-    bool                                        openReserviorCase();
 
 protected:
     caf::PdmField<bool>                         m_flipXAxis;

ApplicationCode/ProjectDataModel/RimEclipseInputCase.cpp

@@ -233,7 +233,7 @@ bool RimEclipseInputCase::openEclipseGridFile()
 void RimEclipseInputCase::reloadEclipseGridFile()
 {
     setReservoirData(nullptr);
-    ensureReservoirCaseIsOpen();
+    openReserviorCase();
 }
 
 #define for_all(stdVector, indexName) for (size_t indexName = 0; indexName < stdVector.size(); ++indexName)

ApplicationCode/ProjectDataModel/RimEclipseResultCase.cpp

@@ -243,7 +243,7 @@ void RimEclipseResultCase::reloadEclipseGridFile()
     m_gridAndWellDataIsReadFromFile = false;
     m_activeCellInfoIsReadFromFile = false;
     setReservoirData(nullptr);
-    ensureReservoirCaseIsOpen();
+    openReserviorCase();
 }
 
 //--------------------------------------------------------------------------------------------------

ApplicationCode/ProjectDataModel/RimEclipseStatisticsCase.cpp

@@ -176,7 +176,7 @@ bool RimEclipseStatisticsCase::openEclipseGridFile()
 void RimEclipseStatisticsCase::reloadEclipseGridFile()
 {
     setReservoirData(nullptr);
-    ensureReservoirCaseIsOpen();
+    openReserviorCase();
 }
 
 //--------------------------------------------------------------------------------------------------

ApplicationCode/ProjectDataModel/RimEclipseView.cpp

@@ -830,7 +830,7 @@ void RimEclipseView::onLoadDataAndUpdate()
 
     if (m_eclipseCase)
     {
-        if (!m_eclipseCase->ensureReservoirCaseIsOpen())
+        if (!m_eclipseCase->openReserviorCase())
         {
             QMessageBox::warning(RiuMainWindow::instance(), 
                                 "Error when opening project file", 

ApplicationCode/ProjectDataModel/RimIdenticalGridCaseGroup.cpp

@@ -171,7 +171,7 @@ void RimIdenticalGridCaseGroup::loadMainCaseAndActiveCellInfo()
     // When reading active cell info, only the total cell count is tested for consistency
 
     RimEclipseCase* mainCase = caseCollection()->reservoirs[0];
-    if (!mainCase->ensureReservoirCaseIsOpen())
+    if (!mainCase->openReserviorCase())
     {
         QMessageBox::warning(Riu3DMainWindowTools::mainWindowWidget(),
                              "Error when opening project file",