#3944 System : Improve code quality using clang-tidy

Remove redundant virtual and add override

ApplicationCode/Commands/HoloLensCommands/RicHoloLensSession.h

@@ -40,7 +40,7 @@ class RimGridView;
 class RicHoloLensSession : public QObject, private RicHoloLensRestResponseHandler
 {
 public:
-    ~RicHoloLensSession();
+    ~RicHoloLensSession() override;
 
     static RicHoloLensSession*  createSession(const QString& serverUrl, const QString& sessionName, const QByteArray& sessionPinCode, RicHoloLensSessionObserver* sessionObserver);
     static RicHoloLensSession*  createDummyFileBackedSession();
@@ -53,10 +53,10 @@ public:
 private:
     RicHoloLensSession();
 
-    virtual void    handleSuccessfulCreateSession() override;
-    virtual void    handleFailedCreateSession() override;
-    virtual void    handleSuccessfulSendMetaData(int metaDataSequenceNumber, const QByteArray& jsonServerResponseString) override;
-    virtual void    handleError(const QString& errMsg, const QString& url, const QString& serverData) override;
+    void    handleSuccessfulCreateSession() override;
+    void    handleFailedCreateSession() override;
+    void    handleSuccessfulSendMetaData(int metaDataSequenceNumber, const QByteArray& jsonServerResponseString) override;
+    void    handleError(const QString& errMsg, const QString& url, const QString& serverData) override;
 
     static bool     parseJsonIntegerArray(const QByteArray& jsonString, std::vector<int>* integerArr);
 

ApplicationCode/Commands/HoloLensCommands/RicHoloLensSessionManager.h

@@ -44,7 +44,7 @@ public:
     static void         refreshToolbarState();
 
 private:
-    virtual void        handleSessionNotification(const RicHoloLensSession* session, Notification notification) override;
+    void        handleSessionNotification(const RicHoloLensSession* session, Notification notification) override;
 
 private:
     RicHoloLensSessionManager();

ApplicationCode/Commands/MeasurementCommands/RicMeasurementPickEventHandler.h

@@ -30,6 +30,6 @@ public:
 
 protected:
     bool handlePickEvent(const Ric3DPickEvent& eventObject) override;
-    void notifyUnregistered();
+    void notifyUnregistered() override;
 };
 

ApplicationCode/ProjectDataModel/Annotations/RimPolylinesAnnotation.h

@@ -38,7 +38,7 @@ class RimPolylinesAnnotation : public caf::PdmObject
 
 public:
     RimPolylinesAnnotation();
-    ~RimPolylinesAnnotation();
+    ~RimPolylinesAnnotation() override;
 
     virtual cvf::ref<RigPolyLinesData> polyLinesData() = 0;
     virtual bool isEmpty() = 0;
@@ -53,7 +53,7 @@ public:
     RimPolylineAppearance* appearance() const;
 
 protected:
-    virtual caf::PdmFieldHandle* objectToggleField() override;
+    caf::PdmFieldHandle* objectToggleField() override;
 
 protected:
     caf::PdmField<bool>   m_isActive;

ApplicationCode/ProjectDataModel/Annotations/RimPolylinesAnnotationInView.h

@@ -63,7 +63,7 @@ public:
 
 protected:
     void fieldChangedByUi(const caf::PdmFieldHandle* changedField, const QVariant& oldValue, const QVariant& newValue) override;
-    virtual caf::PdmFieldHandle* objectToggleField() override;
+    caf::PdmFieldHandle* objectToggleField() override;
     caf::PdmFieldHandle*         userDescriptionField() override;
 
 private:

ApplicationCode/ProjectDataModel/Annotations/RimPolylinesFromFileAnnotation.h

@@ -29,14 +29,14 @@ class RimPolylinesFromFileAnnotation : public RimPolylinesAnnotation
 
 public:
     RimPolylinesFromFileAnnotation();
-    ~RimPolylinesFromFileAnnotation();
+    ~RimPolylinesFromFileAnnotation() override;
 
     void                        setFileName(const QString& fileName);
     QString                     fileName() const;
     void                        readPolyLinesFile(QString * errorMessage);
 
     cvf::ref<RigPolyLinesData>  polyLinesData() override;
-    virtual bool                isEmpty() override;
+    bool                isEmpty() override;
 
     void                        setDescriptionFromFileName();
 
@@ -45,7 +45,7 @@ protected:
     void fieldChangedByUi(const caf::PdmFieldHandle* changedField, const QVariant& oldValue, const QVariant& newValue) override;
 
 private:
-    virtual caf::PdmFieldHandle* userDescriptionField() override;
+    caf::PdmFieldHandle* userDescriptionField() override;
 
     caf::PdmField<QString>       m_userDescription;
     caf::PdmField<caf::FilePath> m_polyLinesFileName;

ApplicationCode/ProjectDataModel/Annotations/RimReachCircleAnnotation.h

@@ -68,7 +68,7 @@ protected:
     void defineUiOrdering(QString uiConfigName, caf::PdmUiOrdering& uiOrdering) override;
     void fieldChangedByUi(const caf::PdmFieldHandle* changedField, const QVariant& oldValue, const QVariant& newValue) override;
     caf::PdmFieldHandle* userDescriptionField() override;
-    virtual caf::PdmFieldHandle* objectToggleField() override;
+    caf::PdmFieldHandle* objectToggleField() override;
 
 private:
     caf::PdmField<bool>     m_isActive;

ApplicationCode/ProjectDataModel/Annotations/RimReachCircleAnnotationInView.h

@@ -63,7 +63,7 @@ public:
 
 protected:
     void fieldChangedByUi(const caf::PdmFieldHandle* changedField, const QVariant& oldValue, const QVariant& newValue) override;
-    virtual caf::PdmFieldHandle* objectToggleField() override;
+    caf::PdmFieldHandle* objectToggleField() override;
     caf::PdmFieldHandle*         userDescriptionField() override;
 
 private:

ApplicationCode/ProjectDataModel/Annotations/RimTextAnnotation.h

@@ -71,7 +71,7 @@ protected:
     void defineUiOrdering(QString uiConfigName, caf::PdmUiOrdering& uiOrdering) override;
     void fieldChangedByUi(const caf::PdmFieldHandle* changedField, const QVariant& oldValue, const QVariant& newValue) override;
     caf::PdmFieldHandle* userDescriptionField() override;
-    virtual caf::PdmFieldHandle* objectToggleField() override;
+    caf::PdmFieldHandle* objectToggleField() override;
 
 private:
     friend class RicTextAnnotation3dEditor;

ApplicationCode/ProjectDataModel/Annotations/RimTextAnnotationInView.h

@@ -59,7 +59,7 @@ public:
 
 protected:
     void fieldChangedByUi(const caf::PdmFieldHandle* changedField, const QVariant& oldValue, const QVariant& newValue) override;
-    virtual caf::PdmFieldHandle* objectToggleField() override;
+    caf::PdmFieldHandle* objectToggleField() override;
     caf::PdmFieldHandle*         userDescriptionField() override;
 
 private:

ApplicationCode/ProjectDataModel/Annotations/RimUserDefinedPolylinesAnnotation.h

@@ -39,11 +39,11 @@ class RimUserDefinedPolylinesAnnotation : public RimPolylinesAnnotation
     CAF_PDM_HEADER_INIT;
 public:
     RimUserDefinedPolylinesAnnotation();
-    ~RimUserDefinedPolylinesAnnotation();
+    ~RimUserDefinedPolylinesAnnotation() override;
 
     cvf::ref<RigPolyLinesData>  polyLinesData() override;
     std::vector<RimPolylineTarget*> activeTargets() const;
-    virtual bool isEmpty() override;
+    bool isEmpty() override;
 
     void appendTarget(const cvf::Vec3d& defaultPos = cvf::Vec3d::ZERO);
     void insertTarget(const RimPolylineTarget* targetToInsertBefore, RimPolylineTarget* targetToInsert);

ApplicationCode/ProjectDataModel/Completions/RimCompletionTemplateCollection.h

@@ -46,6 +46,6 @@ private:
     caf::PdmChildField<RimValveTemplateCollection*>    m_valveTemplates;
 
 protected:
-    virtual void defineUiTreeOrdering(caf::PdmUiTreeOrdering& uiTreeOrdering, QString uiConfigName = "") override;
+    void defineUiTreeOrdering(caf::PdmUiTreeOrdering& uiTreeOrdering, QString uiConfigName = "") override;
 
 };

ApplicationCode/ProjectDataModel/Completions/RimMultipleValveLocations.h

@@ -57,8 +57,8 @@ public:
                     int                                    valveCount,
                     const std::vector<double>&             locationOfValves);
 protected:
-    virtual void fieldChangedByUi(const caf::PdmFieldHandle* changedField, const QVariant& oldValue, const QVariant& newValue) override;
-    virtual void defineUiOrdering(QString uiConfigName, caf::PdmUiOrdering& uiOrdering) override;
+    void fieldChangedByUi(const caf::PdmFieldHandle* changedField, const QVariant& oldValue, const QVariant& newValue) override;
+    void defineUiOrdering(QString uiConfigName, caf::PdmUiOrdering& uiOrdering) override;
 
 private:
     int rangeCountFromSpacing() const;

ApplicationCode/ProjectDataModel/Completions/RimWellPathAicdParameters.h

@@ -49,7 +49,7 @@ class RimWellPathAicdParameters : public caf::PdmObject
     CAF_PDM_HEADER_INIT;
 public:
     RimWellPathAicdParameters();
-    ~RimWellPathAicdParameters();
+    ~RimWellPathAicdParameters() override;
     bool isValid() const;
 
     bool isOpen() const;

ApplicationCode/ProjectDataModel/Rim3dView.h

@@ -222,7 +222,7 @@ protected:
 
     void                            fieldChangedByUi(const caf::PdmFieldHandle* changedField, const QVariant& oldValue, const QVariant& newValue) override;
     void                            defineUiOrdering(QString uiConfigName, caf::PdmUiOrdering& uiOrdering) override;
-    virtual void                    updateViewWidgetAfterCreation() override; 
+    void                    updateViewWidgetAfterCreation() override; 
     QWidget*                        createViewWidget(QWidget* mainWindowParent) override;
     void                            initAfterRead() override;
 

ApplicationCode/ProjectDataModel/RimContourMapView.h

@@ -56,7 +56,7 @@ protected:
 
     caf::PdmFieldHandle* userDescriptionField() override;
 
-    virtual std::set<RivCellSetEnum> allVisibleFaultGeometryTypes() const override;
+    std::set<RivCellSetEnum> allVisibleFaultGeometryTypes() const override;
     
     QWidget* createViewWidget(QWidget* mainWindowParent) override;
 

ApplicationCode/ProjectDataModel/RimEclipseView.h

@@ -137,27 +137,27 @@ public:
 
     bool                                            isUsingFormationNames() const override;
 
-    virtual void                                    calculateCurrentTotalCellVisibility(cvf::UByteArray* totalVisibility, int timeStep) override;
+    void                                    calculateCurrentTotalCellVisibility(cvf::UByteArray* totalVisibility, int timeStep) override;
     
-    virtual std::vector<RimLegendConfig*>           legendConfigs() const override;
+    std::vector<RimLegendConfig*>           legendConfigs() const override;
     cvf::Color4f                                    colorFromCellCategory(RivCellSetEnum geometryType) const;
 
     void                                            syncronizeLocalAnnotationsFromGlobal();
 
 protected:
     void                                    initAfterRead() override;
-    virtual void                            defineUiOrdering( QString uiConfigName, caf::PdmUiOrdering& uiOrdering ) override;
-    virtual void                            defineUiTreeOrdering(caf::PdmUiTreeOrdering& uiTreeOrdering, QString uiConfigName = "") override;
-    virtual void                            onLoadDataAndUpdate() override;
+    void                            defineUiOrdering( QString uiConfigName, caf::PdmUiOrdering& uiOrdering ) override;
+    void                            defineUiTreeOrdering(caf::PdmUiTreeOrdering& uiTreeOrdering, QString uiConfigName = "") override;
+    void                            onLoadDataAndUpdate() override;
     caf::PdmFieldHandle*                    userDescriptionField() override;
 
     void                                    createPartCollectionFromSelection(cvf::Collection<cvf::Part>* parts) override;
     bool                                    showActiveCellsOnly() override;
-    virtual void                            updateCurrentTimeStep() override;
+    void                            updateCurrentTimeStep() override;
     void                                    updateVisibleGeometriesAndCellColors();
     void                                    appendWellsAndFracturesToModel();
 
-    virtual void                            createDisplayModel() override;
+    void                            createDisplayModel() override;
     RimPropertyFilterCollection*            nativePropertyFilterCollection();
     virtual std::set<RivCellSetEnum>        allVisibleFaultGeometryTypes() const;
 
@@ -173,7 +173,7 @@ private:
     void                                            updateStaticCellColors() override;
     void                                            updateStaticCellColors(RivCellSetEnum geometryType);
 
-    virtual void                                    updateLegends() override;
+    void                                    updateLegends() override;
     void                                            updateMinMaxValuesAndAddLegendToView(QString legendLabel, RimEclipseCellColors* resultColors, RigCaseCellResultsData* cellResultsData);
     void                                            resetLegendsInViewer() override;
     void                                            updateVirtualConnectionLegendRanges();

ApplicationCode/ProjectDataModel/RimGridCollection.h

@@ -37,7 +37,7 @@ class RimGridInfo : public caf::PdmObject
 
 public:
     RimGridInfo();
-    ~RimGridInfo() {}
+    ~RimGridInfo() override {}
 
     void    setName(const QString& name);
     void    setEclipseGridIndex(int index);
@@ -68,7 +68,7 @@ class RimGridInfoCollection : public caf::PdmObject
 
 public:
     RimGridInfoCollection();
-    ~RimGridInfoCollection() {}
+    ~RimGridInfoCollection() override {}
 
     bool                      isActive() const;
     void                      addGridInfo(RimGridInfo * gridInfo);

ApplicationCode/ProjectDataModel/RimNameConfig.h

@@ -56,7 +56,7 @@ public:
     void                             uiOrdering(QString uiConfigName, caf::PdmUiOrdering& uiOrdering);
 
 protected:
-    virtual void                     defineUiOrdering(QString uiConfigName, caf::PdmUiOrdering& uiOrdering) override;
+    void                     defineUiOrdering(QString uiConfigName, caf::PdmUiOrdering& uiOrdering) override;
     void                             fieldChangedByUi(const caf::PdmFieldHandle* changedField, const QVariant& oldValue, const QVariant& newValue) override;
     QString                          autoName() const;
     virtual void                     updateAllSettings();

ApplicationCode/ProjectDataModel/RimOilField.h

@@ -69,7 +69,7 @@ public:
     caf::PdmChildField<RimMeasurement*>                     measurement;
 
 protected:
-    virtual void initAfterRead() override;
+    void initAfterRead() override;
 
 private:
     caf::PdmChildField<RimFractureTemplateCollection*>      m_fractureTemplateCollection_OBSOLETE;

ApplicationCode/ReservoirDataModel/RigPolyLinesData.h

@@ -32,7 +32,7 @@ class RigPolyLinesData : public cvf::Object
 {
 public:
     RigPolyLinesData();
-    ~RigPolyLinesData();
+    ~RigPolyLinesData() override;
 
     const std::vector<std::vector<cvf::Vec3d> >& polyLines() const            { return m_polylines;}
     void setPolyLines(const std::vector<std::vector<cvf::Vec3d> >& polyLines) { m_polylines = polyLines;}