Stop invalid analysis plot filters from removing cases

ApplicationCode/ProjectDataModel/AnalysisPlots/RimAnalysisPlot.cpp

@@ -1097,7 +1097,7 @@ void RimAnalysisPlot::applyFilter( const RimPlotDataFilterItem*        filter,
 {
     const std::vector<RiaSummaryCurveDefinition> curveDefsToFilter;
 
-    if ( !filter->isActive() ) return;
+    if ( !filter->isActive() || !filter->isValid() ) return;
 
     std::vector<RiaSummaryCurveDefinition> filteredCurveDefs;
 
@@ -1166,6 +1166,10 @@ void RimAnalysisPlot::applyFilter( const RimPlotDataFilterItem*        filter,
                 }
             }
         }
+        else
+        {
+            casesToKeep = ( *filteredSumCases );
+        }
     }
     else
     {

ApplicationCode/ProjectDataModel/AnalysisPlots/RimPlotDataFilterItem.cpp

@@ -127,6 +127,23 @@ RimPlotDataFilterItem::~RimPlotDataFilterItem()
 {
 }
 
+//--------------------------------------------------------------------------------------------------
+///
+//--------------------------------------------------------------------------------------------------
+bool RimPlotDataFilterItem::isValid() const
+{
+    if ( m_filterTarget() == ENSEMBLE_CASE && ensembleParameterName().isEmpty() )
+    {
+        return false;
+    }
+    else if ( ( m_filterTarget() == SUMMARY_CASE || m_filterTarget() == SUMMARY_ITEM ) && !summaryAddress().isValid() )
+    {
+        return false;
+    }
+
+    return true;
+}
+
 //--------------------------------------------------------------------------------------------------
 ///
 //--------------------------------------------------------------------------------------------------

ApplicationCode/ProjectDataModel/AnalysisPlots/RimPlotDataFilterItem.h

@@ -90,6 +90,7 @@ public:
 
     bool         isActive() const { return m_isActive(); }
     FilterTarget filterTarget() const { return m_filterTarget(); }
+    bool         isValid() const;
 
     RifEclipseSummaryAddress summaryAddress() const;