Fix several warnings and potentially uninitialized data

ApplicationCode/GrpcInterface/RiaGrpcNNCPropertiesService.cpp

@@ -337,7 +337,6 @@ grpc::Status RiaNNCInputValuesStateHandler::init( const NNCValuesInputRequest* r
     {
         auto caseData        = m_eclipseCase->eclipseCaseData();
         auto m_porosityModel = static_cast<RiaDefines::PorosityModelType>( request->porosity_model() );
-        auto resultData      = caseData->results( m_porosityModel );
         m_timeStep           = request->time_step();
         m_propertyName       = QString::fromStdString( request->property_name() );
 

ApplicationCode/ModelVisualization/Surfaces/RivSurfaceIntersectionGeometryGenerator.cpp

@@ -182,7 +182,7 @@ void RivSurfaceIntersectionGeometryGenerator::calculateArrays()
         // End loop local memory
 
 #pragma omp for // default scheduling absolutely best
-        for ( int ntVxIdx = 0; ntVxIdx < nativeTriangleIndices.size(); ntVxIdx += 3 )
+        for ( int ntVxIdx = 0; ntVxIdx < static_cast<int>( nativeTriangleIndices.size() ); ntVxIdx += 3 )
         {
             cvf::Vec3d p0 = nativeVertices[nativeTriangleIndices[ntVxIdx + 0]];
             cvf::Vec3d p1 = nativeVertices[nativeTriangleIndices[ntVxIdx + 1]];

ApplicationCode/ModelVisualization/Surfaces/RivSurfacePartMgr.cpp

@@ -456,7 +456,7 @@ void RivSurfacePartMgr::calculateVertexTextureCoordinates( cvf::Vec2fArray*
     cvf::Vec2f* rawPtr = textureCoords->ptr();
 
 #pragma omp parallel for
-    for ( int vxIdx = 0; vxIdx < numVertices; vxIdx++ )
+    for ( int vxIdx = 0; vxIdx < static_cast<int>( numVertices ); vxIdx++ )
     {
         double     cellScalarValue = resultAccessor->cellScalarGlobIdx( vertexToCellIdxMap[vxIdx] );
         cvf::Vec2f texCoord        = mapper->mapToTextureCoord( cellScalarValue );

Fwk/AppFwk/cafVizExtensions/cafCategoryLegend.h

@@ -46,9 +46,10 @@ protected:
             charHeight = 0.0f;
             lineSpacing = 0.0f;
             margins = cvf::Vec2f::ZERO;
-            tickEndX = 0.0f;
             tickStartX = 0.0f;
             tickMidX = 0.0f;
+            tickEndX = 0.0f;
+            tickTextLeadSpace = 0.0f;
 
             overallLegendSize = setSize;
         }

Fwk/AppFwk/cafVizExtensions/cafOverlayScalarMapperLegend.h

@@ -97,6 +97,14 @@ protected:
     {
         OverlayColorLegendLayoutInfo(const Vec2ui& setSize)
         {
+            charHeight = 0.0f;
+            lineSpacing = 0.0f;
+            margins = cvf::Vec2f::ZERO;
+            tickStartX = 0.0f;
+            tickMidX = 0.0f;
+            tickEndX = 0.0f;
+            tickTextLeadSpace = 0.0f;
+
             overallLegendSize = setSize;
         }
 

Fwk/AppFwk/cafVizExtensions/cafOverlayScaleLegend.h

@@ -112,6 +112,17 @@ protected:
 
         LayoutInfo(const Vec2ui& setSize)
         {
+            charWidth = 0.0f;
+            charHeight = 0.0f;
+            lineSpacing = 0.0f;
+            margins = cvf::Vec2f::ZERO;
+            tickTextLeadSpace = 0.0f;
+            
+            axisStartPt = cvf::Vec2f::ZERO;
+            axisLength = 0.0f;
+            majorTickSize = 0.0f;
+            minorTickSize = 0.0f;
+
             overallLegendSize = setSize;
         }