From 914cab908400d253cd4f31b22be9b3bd5fc8c7d1 Mon Sep 17 00:00:00 2001 From: Magne Sjaastad Date: Tue, 20 Oct 2026 20:07:39 +0200 Subject: [PATCH] #13097: Expose Fixed Angle as scriptable field in Fishbones Make RimFishbones::m_fixedInstallationRotationAngle scriptable so it can be set from the Python API when using the Fixed Fishbones orientation mode. --- .../ProjectDataModel/Completions/RimFishbones.cpp | 2 +- GrpcInterface/Python/rips/tests/test_wells_path_completions.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/ApplicationLibCode/ProjectDataModel/Completions/RimFishbones.cpp b/ApplicationLibCode/ProjectDataModel/Completions/RimFishbones.cpp index 33d03462b8..ee31c3cb40 100644 --- a/ApplicationLibCode/ProjectDataModel/Completions/RimFishbones.cpp +++ b/ApplicationLibCode/ProjectDataModel/Completions/RimFishbones.cpp @@ -106,7 +106,7 @@ RimFishbones::RimFishbones() CAF_PDM_InitFieldNoDefault( &m_installationRotationAngles, "InstallationRotationAngles", "Installation Rotation Angles [deg]" ); m_installationRotationAngles.uiCapability()->setUiEditorTypeName( caf::PdmUiListEditor::uiEditorTypeName() ); m_installationRotationAngles.uiCapability()->setUiHidden( true ); - CAF_PDM_InitField( &m_fixedInstallationRotationAngle, "FixedInstallationRotationAngle", 0.0, " Fixed Angle [deg]" ); + CAF_PDM_InitScriptableField( &m_fixedInstallationRotationAngle, "FixedInstallationRotationAngle", 0.0, " Fixed Angle [deg]" ); auto pipeProperties = new RimFishbonesPipeProperties; diff --git a/GrpcInterface/Python/rips/tests/test_wells_path_completions.py b/GrpcInterface/Python/rips/tests/test_wells_path_completions.py index 8540b66430..972850f7a3 100644 --- a/GrpcInterface/Python/rips/tests/test_wells_path_completions.py +++ b/GrpcInterface/Python/rips/tests/test_wells_path_completions.py @@ -217,6 +217,7 @@ def test_fishbone_interface(rips_instance, initialize_test): fishbones.lateral_tubing_diameter = 0.1 fishbones.lateral_tubing_roghness_factor = 0.1 fishbones.subs_orientation_mode = "FIXED" + fishbones.fixed_installation_rotation_angle = 12.3 fishbones.update() fishbones_updated = fishbones_collection.fishbones()[0] @@ -234,6 +235,7 @@ def test_fishbone_interface(rips_instance, initialize_test): assert fishbones_updated.lateral_tubing_diameter == 0.1 assert fishbones_updated.lateral_tubing_roghness_factor == 0.1 assert fishbones_updated.subs_orientation_mode == "FIXED" + assert fishbones_updated.fixed_installation_rotation_angle == 12.3 # test perforations and perforations settings