#1561 Replacing old combine function for RigCompletionData with new combineEclipseCellCompletions which can calculate WPImult. Assumes completions to always have calculated transmissibility.

ApplicationCode/Commands/CompletionCommands/RicFishbonesTransmissibilityCalculationFeatureImp.cpp

@@ -115,7 +115,7 @@ void RicFishbonesTransmissibilityCalculationFeatureImp::findFishboneLateralsWell
                 if (intersection.mainBoreCell && settings.removeLateralsInMainBoreCells()) continue;
 
                 double diameter = location.fishbonesSubs->holeDiameter() / 1000;
-                QString completionMetaData = (location.fishbonesSubs->name(), QString("Sub: %1 Lateral: %2").arg(location.subIndex).arg(lateral.lateralIndex));
+                QString completionMetaData = (location.fishbonesSubs->name() + QString(" Sub: %1 Lateral: %2").arg(location.subIndex).arg(lateral.lateralIndex));
                 WellBorePartForTransCalc wellBorePart = WellBorePartForTransCalc(intersection.lengthsInCell, 
                                                                                  diameter / 2, 
                                                                                  location.fishbonesSubs->skinFactor(), 
@@ -155,8 +155,11 @@ std::vector<RigCompletionData> RicFishbonesTransmissibilityCalculationFeatureImp
         bool cellIsActive = activeCellInfo->isActive(cellIndex);
         if (!cellIsActive) continue;
         
+        //TODO: Only laterals should contribute to reduction!
         size_t NumberOfCellContributions = wellBoreParts.size();
         //Simplest implementation possible, this can be improved later
+
+        //TODO: Find main bore direction and use this as direction in which to split cell
         QString directionToSplitCellVolume = "DX";
 
         for (WellBorePartForTransCalc wellBorePart : wellBoreParts)
@@ -165,6 +168,8 @@ std::vector<RigCompletionData> RicFishbonesTransmissibilityCalculationFeatureImp
             completion.addMetadata(wellBorePart.metaData, "");
             if (settings.computeTransmissibility())
             {
+
+
                 double transmissibility = RicWellPathExportCompletionDataFeature::calculateTransmissibility(settings.caseToApply,
                                                                                                             wellPath,
                                                                                                             wellBorePart.lengthsInCell,

ApplicationCode/Commands/CompletionCommands/RicWellPathExportCompletionDataFeature.cpp

@@ -138,7 +138,8 @@ std::vector<RimWellPath*> RicWellPathExportCompletionDataFeature::selectedWellPa
 //--------------------------------------------------------------------------------------------------
 /// 
 //--------------------------------------------------------------------------------------------------
-void RicWellPathExportCompletionDataFeature::exportCompletions(const std::vector<RimWellPath*>& wellPaths, const RicExportCompletionDataSettingsUi& exportSettings)
+void RicWellPathExportCompletionDataFeature::exportCompletions(const std::vector<RimWellPath*>& wellPaths, 
+                                                               const RicExportCompletionDataSettingsUi& exportSettings)
 {
 
     if (exportSettings.caseToApply() == nullptr)
@@ -184,9 +185,8 @@ void RicWellPathExportCompletionDataFeature::exportCompletions(const std::vector
             return;
         }
     }
-
+    
-
+    std::map<IJKCellIndex, std::vector<RigCompletionData> > completionsPerEclipseCell;
-    std::map<IJKCellIndex, std::vector<RigCompletionData> > completionData;
 
     for (auto wellPath : usedWellPaths)
     {
@@ -195,26 +195,24 @@ void RicWellPathExportCompletionDataFeature::exportCompletions(const std::vector
         if (exportSettings.includePerforations)
         {
             std::vector<RigCompletionData> perforationCompletionData = generatePerforationsCompdatValues(wellPath, exportSettings);
-            appendCompletionData(&completionData, perforationCompletionData);
+            appendCompletionData(&completionsPerEclipseCell, perforationCompletionData);
         }
         if (exportSettings.includeFishbones)
         {
-//             std::vector<RigCompletionData> fishbonesCompletionData = RicFishbonesTransmissibilityCalculationFeatureImp::generateFishboneLateralsCompdatValues(wellPath, exportSettings);
-//             appendCompletionData(&completionData, fishbonesCompletionData);
-//             std::vector<RigCompletionData> fishbonesWellPathCompletionData = RicFishbonesTransmissibilityCalculationFeatureImp::generateFishbonesImportedLateralsCompdatValues(wellPath, exportSettings);
-//             appendCompletionData(&completionData, fishbonesWellPathCompletionData);
-
             std::vector<RigCompletionData> fishbonesCompletionData = RicFishbonesTransmissibilityCalculationFeatureImp::generateFishboneCompdatValuesUsingAdjustedCellVolume(wellPath, exportSettings);
-            appendCompletionData(&completionData, fishbonesCompletionData);
+            appendCompletionData(&completionsPerEclipseCell, fishbonesCompletionData);
-
         }
     }
 
-    // Merge map into a vector of values
     std::vector<RigCompletionData> completions;
-    for (auto& data : completionData)
+    //std::map < IJKCellIndex, std::map<QString, RigCompletionData >> combinedCompletionDataPerEclipseCell; 
+    //Should be moved to map instead of vector
+
+    for (auto& data : completionsPerEclipseCell)
     {
-        completions.push_back(RigCompletionData::combine(data.second));
+        //completions.push_back(RigCompletionData::combine(data.second));
+        completions.push_back(combineEclipseCellCompletions(data.second, exportSettings));
+
     }
 
     const QString eclipseCaseName = exportSettings.caseToApply->caseUserDescription();
@@ -259,11 +257,97 @@ void RicWellPathExportCompletionDataFeature::exportCompletions(const std::vector
     }
 }
 
+//==================================================================================================
+/// 
+//==================================================================================================
+RigCompletionData RicWellPathExportCompletionDataFeature::combineEclipseCellCompletions(const std::vector<RigCompletionData>& completions,
+                                                                                        const RicExportCompletionDataSettingsUi& settings)
+{
+    CVF_ASSERT(!completions.empty());
+    QString wellName = completions[0].wellName();
+    IJKCellIndex cellIndexIJK = completions[0].cellIndex();
+    RigMainGrid* grid = settings.caseToApply->eclipseCaseData()->mainGrid();
+    size_t cellIndex = grid->cellIndexFromIJK(cellIndexIJK.i, cellIndexIJK.j, cellIndexIJK.k);
+    RigCompletionData::CompletionType completionType = completions[0].completionType();
+
+    //completion type, skin factor, well bore diameter and cell direction are taken from (first) main bore, 
+    //if no main bore they are taken from first completion
+    double skinfactor = completions[0].skinFactor();
+    double wellBoreDiameter = completions[0].diameter();
+    CellDirection cellDirection = completions[0].direction();
+    
+    for (const RigCompletionData& completion : completions)
+    {
+        if (completion.isMainBore())
+        {
+            skinfactor = completion.skinFactor();
+            wellBoreDiameter = completion.diameter();
+            cellDirection = completion.direction();
+            break;
+        }
+    }
+
+
+    RigCompletionData resultCompletion(wellName, cellIndexIJK);
+
+    double totalTrans = 0.0;
+
+    for (const RigCompletionData& completion : completions)
+    {
+        if (completion.completionType() != completions[0].completionType())
+        {
+            RiaLogging::error(QString("Cannot combine completions of different types in same cell [%1, %2, %3]").arg(cellIndexIJK.i).arg(cellIndexIJK.j).arg(cellIndexIJK.k));
+            return resultCompletion; //Returning empty completion, should not be exported
+        }
+
+        if (completion.wellName() != completions[0].wellName())
+        {
+            RiaLogging::error(QString("Cannot combine completions from different wells in same cell [%1, %2, %3]").arg(cellIndexIJK.i).arg(cellIndexIJK.j).arg(cellIndexIJK.k));
+            return resultCompletion; //Returning empty completion, should not be exported
+        }
+        
+        if (completion.transmissibility() == HUGE_VAL)
+        {
+            RiaLogging::error(QString("Transmissibility calculation has failed for cell [%1, %2, %3]").arg(cellIndexIJK.i).arg(cellIndexIJK.j).arg(cellIndexIJK.k));
+            return resultCompletion; //Returning empty completion, should not be exported
+        }       
+        totalTrans = totalTrans + completion.transmissibility();
+    }
+
+
+    if (settings.computeTransmissibility() && !settings.includeWpimult) //TODO: replace with explicitTransmissibilityExport setting
+    {
+        resultCompletion.setCombinedValuesExplicitTrans(totalTrans, completionType);
+    }
+
+    if (settings.includeWpimult) //TODO: replace with implicitTransmissibilityExportByWPImult
+    {
+        //calculate trans for main bore - but as Eclipse will do it!      
+        double transmissibilityEclipseCalculation = RicWellPathExportCompletionDataFeature::calculateTransmissibilityAsEclipseDoes(settings.caseToApply(),
+                                                                                                                                   skinfactor,
+                                                                                                                                   wellBoreDiameter / 2,
+                                                                                                                                   cellIndex,
+                                                                                                                                   cellDirection);
+
+        double wpimult = totalTrans / transmissibilityEclipseCalculation;
+        resultCompletion.setCombinedValuesImplicitTransWPImult(wpimult, cellDirection, skinfactor, wellBoreDiameter, completionType);
+    }
+        
+    return resultCompletion;
+}
+
+
+
+
+
 //--------------------------------------------------------------------------------------------------
 /// 
 //--------------------------------------------------------------------------------------------------
 void RicWellPathExportCompletionDataFeature::printCompletionsToFile(const QString& exportFolder, const QString& fileName, std::vector<RigCompletionData>& completions, bool includeWpimult)
 {
+    //TODO: Check that completion is ready for export
+    //TODO: Use wpimult instead of count for export!
+
     QString filePath = QDir(exportFolder).filePath(fileName);
     QFile exportFile(filePath);
     if (!exportFile.open(QIODevice::WriteOnly))
@@ -280,6 +364,8 @@ void RicWellPathExportCompletionDataFeature::printCompletionsToFile(const QStrin
 
     // Print completion data
     generateCompdatTable(formatter, completions);
+
+    
     if (includeWpimult)
     {
         generateWpimultTable(formatter, completions);
@@ -708,3 +794,67 @@ double RicWellPathExportCompletionDataFeature::calculateTransmissibility(RimEcli
 
     return RigTransmissibilityEquations::totalConnectionFactor(transx, transy, transz);
 }
+
+
+//--------------------------------------------------------------------------------------------------
+/// 
+//--------------------------------------------------------------------------------------------------
+double RicWellPathExportCompletionDataFeature::calculateTransmissibilityAsEclipseDoes(RimEclipseCase* eclipseCase,
+                                                                                      double skinFactor,
+                                                                                      double wellRadius,
+                                                                                      size_t cellIndex,
+                                                                                      CellDirection direction)
+{
+    RigEclipseCaseData* eclipseCaseData = eclipseCase->eclipseCaseData();
+
+    eclipseCase->results(RifReaderInterface::MATRIX_RESULTS)->findOrLoadScalarResult(RiaDefines::STATIC_NATIVE, "DX");
+    cvf::ref<RigResultAccessor> dxAccessObject = RigResultAccessorFactory::createFromUiResultName(eclipseCaseData, 0, RifReaderInterface::MATRIX_RESULTS, 0, "DX");
+    eclipseCase->results(RifReaderInterface::MATRIX_RESULTS)->findOrLoadScalarResult(RiaDefines::STATIC_NATIVE, "DY");
+    cvf::ref<RigResultAccessor> dyAccessObject = RigResultAccessorFactory::createFromUiResultName(eclipseCaseData, 0, RifReaderInterface::MATRIX_RESULTS, 0, "DY");
+    eclipseCase->results(RifReaderInterface::MATRIX_RESULTS)->findOrLoadScalarResult(RiaDefines::STATIC_NATIVE, "DZ");
+    cvf::ref<RigResultAccessor> dzAccessObject = RigResultAccessorFactory::createFromUiResultName(eclipseCaseData, 0, RifReaderInterface::MATRIX_RESULTS, 0, "DZ");
+
+    eclipseCase->results(RifReaderInterface::MATRIX_RESULTS)->findOrLoadScalarResult(RiaDefines::STATIC_NATIVE, "PERMX");
+    cvf::ref<RigResultAccessor> permxAccessObject = RigResultAccessorFactory::createFromUiResultName(eclipseCaseData, 0, RifReaderInterface::MATRIX_RESULTS, 0, "PERMX");
+    eclipseCase->results(RifReaderInterface::MATRIX_RESULTS)->findOrLoadScalarResult(RiaDefines::STATIC_NATIVE, "PERMY");
+    cvf::ref<RigResultAccessor> permyAccessObject = RigResultAccessorFactory::createFromUiResultName(eclipseCaseData, 0, RifReaderInterface::MATRIX_RESULTS, 0, "PERMY");
+    eclipseCase->results(RifReaderInterface::MATRIX_RESULTS)->findOrLoadScalarResult(RiaDefines::STATIC_NATIVE, "PERMZ");
+    cvf::ref<RigResultAccessor> permzAccessObject = RigResultAccessorFactory::createFromUiResultName(eclipseCaseData, 0, RifReaderInterface::MATRIX_RESULTS, 0, "PERMZ");
+
+    double dx = dxAccessObject->cellScalarGlobIdx(cellIndex);
+    double dy = dyAccessObject->cellScalarGlobIdx(cellIndex);
+    double dz = dzAccessObject->cellScalarGlobIdx(cellIndex);
+    double permx = permxAccessObject->cellScalarGlobIdx(cellIndex);
+    double permy = permxAccessObject->cellScalarGlobIdx(cellIndex);
+    double permz = permxAccessObject->cellScalarGlobIdx(cellIndex);
+
+    //TODO: EclipseCaseData should use RiaEclipseUnitTools to simplify this!!!
+    RiaEclipseUnitTools::UnitSystem units = RiaEclipseUnitTools::UNITS_UNKNOWN;
+    if (eclipseCase->eclipseCaseData()->unitsType() == RigEclipseCaseData::UNITS_FIELD)
+    {
+        units = RiaEclipseUnitTools::UNITS_FIELD;
+    }
+    else if (eclipseCase->eclipseCaseData()->unitsType() == RigEclipseCaseData::UNITS_METRIC)
+    {
+        units = RiaEclipseUnitTools::UNITS_METRIC;
+    }
+    double darcy = RiaEclipseUnitTools::darcysConstant(units);
+
+
+
+    double trans = cvf::UNDEFINED_DOUBLE;
+    if (direction == CellDirection::DIR_I)
+    {
+        trans = RigTransmissibilityEquations::wellBoreTransmissibilityComponent(dx, permy, permz, dy, dz, wellRadius, skinFactor, darcy);
+    }
+    else if (direction == CellDirection::DIR_J)
+    {
+        trans = RigTransmissibilityEquations::wellBoreTransmissibilityComponent(dy, permx, permz, dx, dz, wellRadius, skinFactor, darcy);
+    }
+    else if (direction == CellDirection::DIR_K)
+    {
+        trans = RigTransmissibilityEquations::wellBoreTransmissibilityComponent(dz, permy, permx, dy, dx, wellRadius, skinFactor, darcy);
+    }
+
+    return trans;
+}

ApplicationCode/Commands/CompletionCommands/RicWellPathExportCompletionDataFeature.h

@@ -136,8 +136,23 @@ public:
     static void                                  markWellPathCells(const std::vector<size_t>& wellPathCells, std::vector<WellSegmentLocation>* locations);
     static CellDirection                         calculateDirectionInCell(RimEclipseCase* eclipseCase, size_t cellIndex, const cvf::Vec3d& lengthsInCell);
     
-    static double                                calculateTransmissibility(RimEclipseCase* eclipseCase, const RimWellPath* wellPath, const cvf::Vec3d& internalCellLengths, double skinFactor, double wellRadius, size_t cellIndex, size_t volumeScaleConstant = 1, QString directionForVolumeScaling = "DX");
+    static double                                calculateTransmissibility(RimEclipseCase* eclipseCase, 
+                                                                           const RimWellPath* wellPath, 
+                                                                           const cvf::Vec3d& internalCellLengths, 
+                                                                           double skinFactor, 
+                                                                           double wellRadius, 
+                                                                           size_t cellIndex, 
+                                                                           size_t volumeScaleConstant = 1, 
+                                                                           QString directionForVolumeScaling = "DX");
+    static double                                calculateTransmissibilityAsEclipseDoes(RimEclipseCase* eclipseCase,
+                                                                                        double skinFactor,
+                                                                                        double wellRadius,
+                                                                                        size_t cellIndex,
+                                                                                        CellDirection direction);
+
 private:
+    static RigCompletionData                     combineEclipseCellCompletions(const std::vector<RigCompletionData>& completions, 
+                                                                               const RicExportCompletionDataSettingsUi& settings);
     static void                                  exportCompletions(const std::vector<RimWellPath*>& wellPaths, const RicExportCompletionDataSettingsUi& exportSettings);
     static void                                  printCompletionsToFile(const QString& exportFolder, const QString& fileName, std::vector<RigCompletionData>& completions, bool includeWpimult);
     static std::vector<RigCompletionData>        getCompletionsForWellAndCompletionType(const std::vector<RigCompletionData>& completions, const QString& wellName, RigCompletionData::CompletionType completionType);

ApplicationCode/ReservoirDataModel/RigCompletionData.cpp

@@ -22,6 +22,8 @@
 
 #include <QString>
 #include <cmath> // Needed for HUGE_VAL on Linux
+#include "CompletionCommands\RicExportCompletionDataSettingsUi.h"
+#include "CompletionCommands\RicWellPathExportCompletionDataFeature.h"
 
 //==================================================================================================
 /// 
@@ -37,7 +39,10 @@ RigCompletionData::RigCompletionData(const QString wellName, const IJKCellIndex&
       m_dFactor(HUGE_VAL),
       m_direction(DIR_UNDEF),
       m_connectionState(OPEN),
-      m_count(1)
+      m_count(1),
+      m_wpimult(1),
+      m_isMainBore(false),
+      m_readyForExport(false)
 {
 }
 
@@ -86,6 +91,7 @@ RigCompletionData RigCompletionData::combine(const std::vector<RigCompletionData
         result.m_metadata.reserve(result.m_metadata.size() + it->m_metadata.size());
         result.m_metadata.insert(result.m_metadata.end(), it->m_metadata.begin(), it->m_metadata.end());
 
+        //TODO: remove?
         result.m_count += it->m_count;
     }
 
@@ -157,6 +163,33 @@ void RigCompletionData::setFromPerforation(double diameter, CellDirection direct
     m_direction = direction;
 }
 
+//==================================================================================================
+/// 
+//==================================================================================================
+void RigCompletionData::setCombinedValuesExplicitTrans(double transmissibility, 
+                                                       CompletionType completionType)
+{
+    m_completionType = completionType;
+    m_transmissibility = transmissibility;
+    m_readyForExport = true;
+}
+
+//==================================================================================================
+/// 
+//==================================================================================================
+void RigCompletionData::setCombinedValuesImplicitTransWPImult(double wpimult, 
+                                                              CellDirection celldirection, 
+                                                              double skinFactor,
+                                                              double wellDiameter,
+                                                              CompletionType completionType)
+{
+    m_wpimult = wpimult;
+    m_completionType = completionType;
+    m_skinFactor = skinFactor;
+    m_diameter = wellDiameter;
+    m_readyForExport = true;
+}
+
 //==================================================================================================
 /// 
 //==================================================================================================

ApplicationCode/ReservoirDataModel/RigCompletionData.h

@@ -110,6 +110,15 @@ public:
     void                                 setFromFishbone(double diameter, CellDirection direction);
     void                                 setFromFishbone(double transmissibility, double skinFactor);
     void                                 setFromPerforation(double diameter, CellDirection direction);
+
+    void                                 setCombinedValuesExplicitTrans(double transmissibility, 
+                                                                        CompletionType completionType);
+    void                                 setCombinedValuesImplicitTransWPImult(double wpimult, 
+                                                                               CellDirection celldirection, 
+                                                                               double skinFactor, 
+                                                                               double wellDiameter, 
+                                                                               CompletionType completionType);
+
     void                                 addMetadata(const QString& name, const QString& comment);
     static bool                          isDefaultValue(double val);
 
@@ -119,29 +128,35 @@ public:
     WellConnectionState                       connectionState() const { return m_connectionState; }
     double                                    saturation() const { return m_saturation; }
     double                                    transmissibility() const { return m_transmissibility; }
-    double                                    diameter() const { return m_diameter; }
+    double                                    diameter() const { return m_diameter; } //TODO: should be ft or m
     double                                    kh() const { return m_kh; }
     double                                    skinFactor() const { return m_skinFactor; }
     double                                    dFactor() const { return m_dFactor; }
     CellDirection                             direction() const { return m_direction; }
     size_t                                    count() const { return m_count; }
     CompletionType                            completionType() const { return m_completionType; }
+    bool                                      isMainBore() const { return m_isMainBore; }
+    bool                                      readyForExport() const { return m_readyForExport; }
+
 
 private:
     std::vector<RigCompletionMetaData>   m_metadata;
     QString                              m_wellName;
     IJKCellIndex                         m_cellIndex;
     WellConnectionState                  m_connectionState;
-    double                               m_saturation;
+    double                               m_saturation; //TODO: remove, always use default in Eclipse?
     double                               m_transmissibility;
     double                               m_diameter;
-    double                               m_kh;
+    double                               m_kh; //TODO: Remove, always use default in Eclipse?
     double                               m_skinFactor;
-    double                               m_dFactor;
+    double                               m_dFactor; //TODO: Remove, always use default in Eclipse?
     CellDirection                        m_direction;
 
-    // Number of parts that have contributed to this completion
+    bool                                 m_isMainBore; //to use mainbore for Eclipse calculation
-    size_t                               m_count;
+    bool                                 m_readyForExport;
+
+    size_t                               m_count; //TODO: Remove, usage replaced by WPImult
+    size_t                               m_wpimult;
 
     CompletionType                       m_completionType;