CppCheck : Fix various minor issues

ApplicationCode/UserInterface/RiuCalculationsContextMenuManager.h

@@ -41,7 +41,11 @@ class RiuCalculationsContextMenuManager : public QObject
      static const std::map<QString, std::set<QString>> MENU_MAP;
 
 public:
-    RiuCalculationsContextMenuManager() { }
+    RiuCalculationsContextMenuManager()
+        : m_curveCalc(nullptr)
+        , m_textPosition(0)
+    {
+    }
 
     void attachWidget(QWidget* widget, RicSummaryCurveCalculator* curveCalc);
 

ApplicationCode/UserInterface/RiuExpressionContextMenuManager.h

@@ -39,7 +39,10 @@ class RiuExpressionContextMenuManager : public QObject
      static const std::map<QString, std::set<QString>> MENU_MAP;
 
 public:
-    RiuExpressionContextMenuManager() { }
+    RiuExpressionContextMenuManager()
+        : m_textPosition(0)
+    {
+    }
 
     void attachTextEdit(QTextEdit* textEdit);
 

ApplicationCode/UserInterface/RiuViewerCommands.cpp

@@ -177,12 +177,7 @@ void RiuViewerCommands::displayContextMenu(QMouseEvent* event)
 
     if (pickItemInfos.size())
     {
-        cvf::Vec3d globalIntersectionPoint(cvf::Vec3d::ZERO);
-
-        if ( pickItemInfos.size() )
-        {
-            globalIntersectionPoint = pickItemInfos[0].globalPickedPoint();
-        }
+        cvf::Vec3d globalIntersectionPoint = pickItemInfos[0].globalPickedPoint();
 
         for (const auto& pickItem : pickItemInfos)
         {

ApplicationCode/UserInterface/RiuWellPathComponentPlotItem.cpp

@@ -50,6 +50,7 @@ RiuWellPathComponentPlotItem::RiuWellPathComponentPlotItem(const RimWellPath* we
     , m_componentType(RiaDefines::WELL_PATH)
     , m_columnOffset(0.0)
     , m_depthType(RimWellLogPlot::MEASURED_DEPTH)
+    , m_maxColumnOffset(0.0)
     , m_showLabel(false)
 {
     CVF_ASSERT(wellPath);
@@ -68,6 +69,7 @@ RiuWellPathComponentPlotItem::RiuWellPathComponentPlotItem(const RimWellPath* we
     : m_wellPath(wellPath)
     , m_columnOffset(0.0)
     , m_depthType(RimWellLogPlot::MEASURED_DEPTH)
+    , m_maxColumnOffset(0.0)
     , m_showLabel(false)
 {
     CVF_ASSERT(wellPath && component);