OilfieldToolsNet/ResInsight
4
0 Fork 0
mirror of https://github.com/OPM/ResInsight.git synced 2026-10-25 14:40:26 -05:00
Code Issues Packages Projects Releases Wiki Activity

Improve description of statistical formulas (#13567)

Browse Source 
* Refactor and extend percentile calculation utilities

Refactored percentile and quantile calculation logic for improved flexibility and maintainability. Added helper functions for quantile/percentile validation, introduced a new vector-based calculatePercentiles method, and updated calculateStatisticsCurves to use it. Refactored nearest-rank and interpolated percentile methods to accept percentiles as vectors and improved parameter validation. Enhanced documentation throughout and updated function signatures in the header for clarity.
This commit is contained in:
Magne Sjaastad authored and GitHub committed 2026-02-08 11:52:42 +01:00
1 parent e8cd19f38c
commit af8213509a
4 files changed
+346 -140
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

ApplicationLibCode/ProjectDataModel/RimEclipseStatisticsCaseEvaluator.cpp
+29 -13
View File
@@ -20,6 +20,8 @@
#include "RimEclipseStatisticsCaseEvaluator.h"
#include "RiaLogging.h"
#include "RigCaseCellResultsData.h"
#include "RigEclipseCaseData.h"
#include "RigEclipseResultInfo.h"
@@ -262,13 +264,20 @@ void RimEclipseStatisticsCaseEvaluator::evaluateForResults( const QList<ResSpec>
pValPoss.push_back( m_statisticsConfig.m_pMinPos );
pValPoss.push_back( m_statisticsConfig.m_pMidPos );
pValPoss.push_back( m_statisticsConfig.m_pMaxPos );
std::vector<double> pVals =
auto resultValues =
RigStatisticsMath::calculateNearestRankPercentiles( values,
pValPoss,
RigStatisticsMath::PercentileStyle::SWITCHED );
statParams[PMIN] = pVals[0];
statParams[PMID] = pVals[1];
statParams[PMAX] = pVals[2];
if ( resultValues.has_value() )
{
statParams[PMIN] = ( *resultValues )[0];
statParams[PMID] = ( *resultValues )[1];
statParams[PMAX] = ( *resultValues )[2];
}
else
{
RiaLogging::warning( QString::fromStdString( resultValues.error() ) );
}
}
else if ( m_statisticsConfig.m_pValMethod == RimEclipseStatisticsCase::PercentileCalcType::HISTOGRAM_ESTIMATED )
{
@@ -285,17 +294,24 @@ void RimEclipseStatisticsCaseEvaluator::evaluateForResults( const QList<ResSpec>
else if ( m_statisticsConfig.m_pValMethod ==
RimEclipseStatisticsCase::PercentileCalcType::INTERPOLATED_OBSERVATION )
{
std::vector<double> pValPoss;
pValPoss.push_back( m_statisticsConfig.m_pMinPos );
pValPoss.push_back( m_statisticsConfig.m_pMidPos );
pValPoss.push_back( m_statisticsConfig.m_pMaxPos );
std::vector<double> pVals =
std::vector<double> percentiles;
percentiles.push_back( m_statisticsConfig.m_pMinPos );
percentiles.push_back( m_statisticsConfig.m_pMidPos );
percentiles.push_back( m_statisticsConfig.m_pMaxPos );
auto resultValues =
RigStatisticsMath::calculateInterpolatedPercentiles( values,
pValPoss,
percentiles,
RigStatisticsMath::PercentileStyle::SWITCHED );
statParams[PMIN] = pVals[0];
statParams[PMID] = pVals[1];
statParams[PMAX] = pVals[2];
if ( resultValues.has_value() )
{
statParams[PMIN] = ( *resultValues )[0];
statParams[PMID] = ( *resultValues )[1];
statParams[PMAX] = ( *resultValues )[2];
}
else
{
RiaLogging::warning( QString::fromStdString( resultValues.error() ) );
}
}
else
{