Cleanup includes

Use new tools in Visual Studio to help cleaning up includes and remove redundant includes.

ApplicationLibCode/Application/RiaApplication.h

@@ -21,12 +21,11 @@
 
 #include "RiaDefines.h"
 
-#include "cafPdmField.h"
+#include "cafPdmPointer.h"
-#include "cafPdmObject.h"
-
-#include "cvfFont.h"
 #include "cvfObject.h"
 
+#include <QEventLoop>
+#include <QMap>
 #include <QMutex>
 #include <QPointer>
 #include <QProcess>
@@ -35,7 +34,6 @@
 
 #include <gsl/gsl>
 
-#include <iostream>
 #include <memory>
 
 class QAction;
@@ -79,7 +77,8 @@ class UiProcess;
 namespace cvf
 {
 class ProgramOptions;
-}
+class Font;
+} // namespace cvf
 
 //==================================================================================================
 /// Base class for all ResInsight applications. I.e. console and GUI

ApplicationLibCode/Application/RiaFontCache.cpp

@@ -20,9 +20,11 @@
 
 #include "RiaGuiApplication.h"
 
+#include "cafAssert.h"
 #include "cafFixedAtlasFont.h"
 
 #include <QDesktopWidget>
+
 #include <cmath>
 
 //--------------------------------------------------------------------------------------------------

ApplicationLibCode/Application/RiaGuiApplication.h

@@ -21,11 +21,6 @@
 #include "RiaApplication.h"
 #include "RiaDefines.h"
 
-#include "cafPdmField.h"
-#include "cafPdmObject.h"
-
-#include "cvfObject.h"
-
 #include <QApplication>
 #include <QMutex>
 #include <QPointer>

ApplicationLibCode/Application/RiaPreferences.cpp

@@ -41,6 +41,7 @@
 #include "cafPdmUiFilePathEditor.h"
 #include "cafPdmUiLineEditor.h"
 
+#include <QCoreApplication>
 #include <QDate>
 #include <QDir>
 #include <QLocale>

ApplicationLibCode/Application/Tools/RiaStdStringTools.cpp

@@ -20,7 +20,6 @@
 
 #include "fast_float/include/fast_float/fast_float.h"
 
-#include <cctype>
 #include <charconv>
 #include <regex>
 #include <sstream>

ApplicationLibCode/Commands/ExportCommands/RicAdvancedSnapshotExportFeature.cpp

@@ -47,6 +47,7 @@
 #include "cafUtils.h"
 
 #include <QAction>
+#include <QApplication>
 #include <QDebug>
 #include <QDir>
 

ApplicationLibCode/Commands/ExportCommands/RicCreateDepthAdjustedLasFilesUi.cpp

@@ -31,7 +31,6 @@
 
 #include "cafPdmUiCheckBoxEditor.h"
 #include "cafPdmUiFilePathEditor.h"
-#include "cafPdmUiOrdering.h"
 #include "cafPdmUiTreeSelectionEditor.h"
 
 CAF_PDM_SOURCE_INIT( RicCreateDepthAdjustedLasFilesUi, "RicCreateDepthAdjustedLasFilesUi" );

ApplicationLibCode/Commands/ExportCommands/RicExportEclipseSectorModelUi.cpp

@@ -33,7 +33,6 @@
 #include "cafPdmUiFilePathEditor.h"
 #include "cafPdmUiGroup.h"
 #include "cafPdmUiLineEditor.h"
-#include "cafPdmUiOrdering.h"
 #include "cafPdmUiTreeSelectionEditor.h"
 
 #include <QDir>

ApplicationLibCode/Commands/ExportCommands/RicExportToLasFileResampleUi.cpp

@@ -20,7 +20,6 @@
 
 #include "cafPdmUiCheckBoxEditor.h"
 #include "cafPdmUiFilePathEditor.h"
-#include "cafPdmUiOrdering.h"
 
 #include <cmath>
 

ApplicationLibCode/Commands/ExportCommands/RicExportWellPathsUi.cpp

@@ -25,7 +25,6 @@
 #include "RimProject.h"
 
 #include "cafPdmUiFilePathEditor.h"
-#include "cafPdmUiOrdering.h"
 
 CAF_PDM_SOURCE_INIT( RicExportWellPathsUi, "RicExportWellPathsUi" );
 

ApplicationLibCode/Commands/ExportCommands/RicSaveEclipseInputVisibleCellsUi.cpp

@@ -22,7 +22,6 @@
 #include "RiaPreferences.h"
 
 #include "cafPdmUiFilePathEditor.h"
-#include "cafPdmUiOrdering.h"
 
 #include <QDir>
 

ApplicationLibCode/Commands/HoloLensCommands/RicHoloLensCreateSessionUi.cpp

@@ -24,7 +24,6 @@
 #include "RicHoloLensServerSettings.h"
 
 #include "cafPdmSettings.h"
-#include "cafPdmUiOrdering.h"
 
 #include "cvfAssert.h"
 

ApplicationLibCode/Commands/HoloLensCommands/RicHoloLensExportToFolderUi.cpp

@@ -25,7 +25,6 @@
 #include "RimProject.h"
 
 #include "cafPdmUiFilePathEditor.h"
-#include "cafPdmUiOrdering.h"
 
 CAF_PDM_SOURCE_INIT( RicHoloLensExportToFolderUi, "RicHoloLensExportToFolderUi" );
 

ApplicationLibCode/Commands/MeasurementCommands/RicMeasurementPickEventHandler.cpp

@@ -19,8 +19,6 @@
 #include "RicMeasurementPickEventHandler.h"
 
 #include "RiaApplication.h"
-#include "RiuViewer.h"
-#include "RiuViewerCommands.h"
 
 #include "Rim3dView.h"
 #include "RimExtrudedCurveIntersection.h"
@@ -28,13 +26,18 @@
 #include "RimMeasurement.h"
 #include "RimProject.h"
 
-#include "cafDisplayCoordTransform.h"
+#include "RiuViewer.h"
-#include "cafSelectionManager.h"
+#include "RiuViewerCommands.h"
 
 #include "RivPartPriority.h"
 
+#include "cafDisplayCoordTransform.h"
+#include "cafSelectionManager.h"
+
 #include "cvfPart.h"
 
+#include <QApplication>
+
 #include <vector>
 
 //--------------------------------------------------------------------------------------------------

ApplicationLibCode/Commands/OperationsUsingObjReferences/RicPasteFeatureImpl.cpp

@@ -33,6 +33,7 @@
 #include "cafPdmObjectHandle.h"
 
 #include <QAction>
+#include <QApplication>
 #include <QClipboard>
 #include <QString>
 

ApplicationLibCode/Commands/RicCopyGridStatisticsToClipboardFeature.cpp

@@ -18,7 +18,7 @@
 
 #include "RicCopyGridStatisticsToClipboardFeature.h"
 
-#include "RiaApplication.h"
+#include "RiaGuiApplication.h"
 
 #include "RicWellLogTools.h"
 

ApplicationLibCode/Commands/RicCreateEnsembleSurfaceUi.cpp

@@ -22,7 +22,6 @@
 
 #include "cafPdmObject.h"
 #include "cafPdmUiCheckBoxEditor.h"
-#include "cafPdmUiOrdering.h"
 #include "cafPdmUiTreeSelectionEditor.h"
 
 CAF_PDM_SOURCE_INIT( RicCreateEnsembleSurfaceUi, "RicCreateEnsembleSurfaceUi" );

ApplicationLibCode/Commands/RicCreateEnsembleWellLogUi.cpp

@@ -34,7 +34,6 @@
 #include "cafPdmObject.h"
 #include "cafPdmUiCheckBoxEditor.h"
 #include "cafPdmUiFilePathEditor.h"
-#include "cafPdmUiOrdering.h"
 #include "cafPdmUiTreeSelectionEditor.h"
 
 CAF_PDM_SOURCE_INIT( RicCreateEnsembleWellLogUi, "RicCreateEnsembleWellLogUi" );

ApplicationLibCode/Commands/SeismicCommands/RicNewSeismicDifferenceFeature.cpp

@@ -18,7 +18,7 @@
 
 #include "RicNewSeismicDifferenceFeature.h"
 
-#include "RiaApplication.h"
+#include "RiaGuiApplication.h"
 
 #include "RimOilField.h"
 #include "RimProject.h"

ApplicationLibCode/Commands/WellPathCommands/PointTangentManipulator/RicWellTarget3dEditor.cpp

@@ -40,6 +40,8 @@
 #include "cvfModelBasicList.h"
 #include "cvfPart.h"
 
+#include <QApplication>
+
 CAF_PDM_UI_3D_OBJECT_EDITOR_SOURCE_INIT( RicWellTarget3dEditor );
 
 //--------------------------------------------------------------------------------------------------

ApplicationLibCode/Commands/WellPathCommands/RicCreateWellTargetsPickEventHandler.cpp

@@ -31,19 +31,17 @@
 #include "RimEclipseView.h"
 #include "RimGeoMechView.h"
 #include "RimModeledWellPath.h"
-#include "RimWellPath.h"
 #include "RimWellPathGeometryDef.h"
 #include "RimWellPathTarget.h"
 
-#include "RiuViewerCommands.h"
-
 #include "RivFemPartGeometryGenerator.h"
 #include "RivFemPickSourceInfo.h"
 #include "RivSourceInfo.h"
 #include "RivWellPathSourceInfo.h"
 
 #include "cafDisplayCoordTransform.h"
-#include "cafSelectionManager.h"
+
+#include <QApplication>
 
 #include <vector>
 

ApplicationLibCode/ProjectDataModel/Annotations/RimPolylinesAnnotationInView.h

@@ -28,7 +28,6 @@
 #include "cafPdmObject.h"
 #include "cafPdmPointer.h"
 #include "cafPdmPtrField.h"
-#include "cafPdmUiOrdering.h"
 
 // Include to make Pdm work for cvf::Color
 #include "cafPdmChildField.h"

ApplicationLibCode/ProjectDataModel/Annotations/RimPolylinesFromFileAnnotationInView.h

@@ -26,7 +26,6 @@
 #include "cafPdmObject.h"
 #include "cafPdmPointer.h"
 #include "cafPdmPtrField.h"
-#include "cafPdmUiOrdering.h"
 
 // Include to make Pdm work for cvf::Color
 #include "cafPdmChildField.h"

ApplicationLibCode/ProjectDataModel/Annotations/RimReachCircleAnnotation.h

@@ -23,7 +23,6 @@
 #include "cafPdmField.h"
 #include "cafPdmObject.h"
 #include "cafPdmPointer.h"
-#include "cafPdmUiOrdering.h"
 
 // Include to make Pdm work for cvf::Color
 #include "cafPdmChildField.h"

ApplicationLibCode/ProjectDataModel/Annotations/RimReachCircleAnnotationInView.h

@@ -26,7 +26,6 @@
 #include "cafPdmObject.h"
 #include "cafPdmPointer.h"
 #include "cafPdmPtrField.h"
-#include "cafPdmUiOrdering.h"
 
 // Include to make Pdm work for cvf::Color
 #include "cafPdmChildField.h"

ApplicationLibCode/ProjectDataModel/Annotations/RimTextAnnotation.h

@@ -23,7 +23,6 @@
 #include "cafPdmField.h"
 #include "cafPdmObject.h"
 #include "cafPdmPointer.h"
-#include "cafPdmUiOrdering.h"
 
 // Include to make Pdm work for cvf::Color
 #include "cafPdmChildField.h"

ApplicationLibCode/ProjectDataModel/Annotations/RimTextAnnotationInView.h

@@ -24,7 +24,6 @@
 #include "cafPdmObject.h"
 #include "cafPdmPointer.h"
 #include "cafPdmPtrField.h"
-#include "cafPdmUiOrdering.h"
 
 // Include to make Pdm work for cvf::Color
 #include "cafPdmChildField.h"

ApplicationLibCode/ProjectDataModel/Annotations/RimUserDefinedPolylinesAnnotationInView.h

@@ -26,7 +26,6 @@
 #include "cafPdmObject.h"
 #include "cafPdmPointer.h"
 #include "cafPdmPtrField.h"
-#include "cafPdmUiOrdering.h"
 
 // Include to make Pdm work for cvf::Color
 #include "cafPdmChildField.h"

ApplicationLibCode/ProjectDataModel/Completions/RimWellPathCompletionSettings.cpp

@@ -27,7 +27,6 @@
 #include "cafPdmFieldScriptingCapability.h"
 #include "cafPdmObjectScriptingCapability.h"
 #include "cafPdmUiLineEditor.h"
-#include "cafPdmUiOrdering.h"
 #include "cafPdmUiTreeOrdering.h"
 
 namespace caf

ApplicationLibCode/ProjectDataModel/CorrelationPlots/RimCorrelationReportPlot.cpp

@@ -33,7 +33,6 @@
 #include "RiuQwtPlotWidget.h"
 
 #include "cafAssert.h"
-#include "cafPdmUiOrdering.h"
 #include "cafPdmUiTreeOrdering.h"
 
 #include <QDebug>

ApplicationLibCode/ProjectDataModel/Flow/RimWellRftEnsembleCurveSet.cpp

@@ -31,7 +31,6 @@
 #include "RiuQwtPlotWidget.h"
 
 #include "cafPdmUiObjectHandle.h"
-#include "cafPdmUiOrdering.h"
 #include "cafPdmUiTreeOrdering.h"
 #include "cafPdmUiTreeSelectionEditor.h"
 

ApplicationLibCode/ProjectDataModel/GeoMech/RimGeoMechCase.cpp

@@ -63,6 +63,7 @@
 
 #include "cvfVector3.h"
 
+#include <QApplication>
 #include <QFileInfo>
 
 #include <array>

ApplicationLibCode/ProjectDataModel/ProcessControl/RimProcess.cpp

@@ -23,6 +23,7 @@
 
 #include "cafPdmFieldCapability.h"
 
+#include <QApplication>
 #include <QProcess>
 #include <QProcessEnvironment>
 

ApplicationLibCode/ProjectDataModel/RimEclipseResultCase.cpp

@@ -61,9 +61,11 @@
 #include "cafProgressInfo.h"
 #include "cafUtils.h"
 
+#include <QApplication>
 #include <QDir>
 #include <QFile>
 #include <QFileInfo>
+
 #include <fstream>
 #include <string>
 

ApplicationLibCode/ProjectDataModel/RimStimPlanLegendConfig.cpp

@@ -20,7 +20,6 @@
 
 #include "RimRegularLegendConfig.h"
 
-#include "cafPdmUiOrdering.h"
 #include "cafPdmUiTreeOrdering.h"
 
 CAF_PDM_SOURCE_INIT( RimStimPlanLegendConfig, "RimStimPlanLegendConfig" );

ApplicationLibCode/ProjectDataModel/Summary/RimSummaryCaseMainCollection.cpp

@@ -47,6 +47,7 @@
 
 #include "cafProgressInfo.h"
 
+#include <QCoreApplication>
 #include <QDir>
 
 CAF_PDM_SOURCE_INIT( RimSummaryCaseMainCollection, "SummaryCaseCollection" );

ApplicationLibCode/ProjectDataModel/WellLog/RimWellLogCurveCommonDataSource.h

@@ -24,7 +24,6 @@
 #include "cafPdmField.h"
 #include "cafPdmObject.h"
 #include "cafPdmPtrField.h"
-#include "cafPdmUiOrdering.h"
 #include "cafTristate.h"
 
 #include <QDateTime>

ApplicationLibCode/UserInterface/RiuMainWindowBase.cpp

@@ -43,6 +43,7 @@
 #include "DockWidget.h"
 
 #include <QAction>
+#include <QApplication>
 #include <QClipboard>
 #include <QInputDialog>
 #include <QMdiArea>

ApplicationLibCode/UserInterface/RiuPlotMainWindowTools.cpp

@@ -20,6 +20,8 @@
 #include "RiaGuiApplication.h"
 #include "RiuPlotMainWindow.h"
 
+#include "cafPdmObject.h"
+
 //--------------------------------------------------------------------------------------------------
 ///
 //--------------------------------------------------------------------------------------------------

ApplicationLibCode/UserInterface/RiuPlotObjectPicker.cpp

@@ -21,6 +21,8 @@
 #include "RiaGuiApplication.h"
 #include "RiuPlotMainWindow.h"
 
+#include "cafPdmObject.h"
+
 #include <QMouseEvent>
 
 //--------------------------------------------------------------------------------------------------

ApplicationLibCode/UserInterface/RiuSummaryPlot.cpp

@@ -32,6 +32,7 @@
 
 #include "cafCmdFeatureMenuBuilder.h"
 
+#include <QApplication>
 #include <QMenu>
 #include <QPointer>
 

Fwk/AppFwk/cafCommand/cafCmdFieldChangeExec.cpp

@@ -38,6 +38,7 @@
 
 #include "cafNotificationCenter.h"
 #include "cafPdmReferenceHelper.h"
+#include "cafPdmUiOrdering.h"
 
 namespace caf
 {

Fwk/AppFwk/cafCommand/cafCmdUiCommandSystemImpl.cpp

@@ -43,8 +43,7 @@
 #include "cafPdmChildArrayField.h"
 #include "cafPdmFieldHandle.h"
 #include "cafPdmObjectHandle.h"
-#include "cafPdmUiObjectHandle.h"
+#include "cafPdmReferenceHelper.h"
-#include "cafPdmXmlFieldHandle.h"
 #include "cafSelectionManager.h"
 
 #include <QMenu>

Fwk/AppFwk/cafCommandFeatures/ToggleCommands/cafToggleItemsFeatureImpl.cpp

@@ -36,11 +36,8 @@
 
 #include "cafToggleItemsFeatureImpl.h"
 
-//#include "RiaFeatureCommandContext.h"
+#include "cafCmdFeatureManager.h"
-//#include "RiaGuiApplication.h"
+#include "cafPdmField.h"
-//#include "RiuMainWindow.h"
-//#include "RiuPlotMainWindow.h"
-
 #include "cafPdmUiFieldHandle.h"
 #include "cafPdmUiItem.h"
 #include "cafPdmUiObjectHandle.h"
@@ -50,7 +47,6 @@
 
 #include <QModelIndex>
 
-#include "cafCmdFeatureManager.h"
 #include <vector>
 
 namespace caf

Fwk/AppFwk/cafPdmScripting/cafPdmFieldScriptingCapability.h

@@ -45,11 +45,6 @@
 #include "cafPdmScriptIOMessages.h"
 
 #include <QIODevice>
-#include <QString>
-#include <QStringList>
-#include <QTextStream>
-
-#include <type_traits>
 
 #define CAF_PDM_InitScriptableField( field, keyword, default, uiName, ... )                          \
     {                                                                                                \

Fwk/AppFwk/cafPdmScripting/cafPdmObjectMethod.h

@@ -37,9 +37,7 @@
 
 #include "cafAssert.h"
 #include "cafPdmObject.h"
-#include "cafPdmObjectFactory.h"
 #include "cafPdmPointer.h"
-#include "cafPdmScriptResponse.h"
 
 /// CAF_PDM_OBJECT_METHOD_SOURCE_INIT associates the self class keyword and the method keyword with the method factory
 /// Place this in the cpp file, preferably above the constructor

Fwk/AppFwk/cafPdmScripting/cafPdmObjectScriptingCapability.h

@@ -35,15 +35,9 @@
 //##################################################################################################
 #pragma once
 
-#include "cafPdmChildArrayField.h"
 #include "cafPdmObjectCapability.h"
-#include "cafPdmObjectMethod.h"
 #include "cafPdmObjectScriptingCapabilityRegister.h"
 
-#include <QString>
-
-#include <map>
-#include <memory>
 #include <vector>
 
 class QTextStream;

Fwk/AppFwk/cafPdmScripting/cafPdmScriptResponse.h

@@ -36,7 +36,6 @@
 #pragma once
 
 #include "cafPdmObject.h"
-#include "cafPdmPointer.h"
 
 #include <QString>
 #include <QStringList>

Fwk/AppFwk/cafProjectDataModel/cafPdmCore/cafPdmBase.h

@@ -1,8 +1,5 @@
 #pragma once
 
-// Brings in size_t and definition of NULL
-#include <cstddef>
-
 // Macro to disable the copy constructor and assignment operator
 // Should be used in the private section of a class
 #define PDM_DISABLE_COPY_AND_ASSIGN( CLASS_NAME ) \

Fwk/AppFwk/cafProjectDataModel/cafPdmCore/cafPdmReferenceHelper.h

@@ -37,9 +37,6 @@
 #pragma once
 
 #include "cafPdmObjectHandle.h"
-#include "cafPdmPointer.h"
-
-#include <QStringList>
 
 namespace caf
 {

Fwk/AppFwk/cafProjectDataModel/cafPdmCore/cafSignal.h

@@ -40,7 +40,6 @@
 #include <functional>
 #include <list>
 #include <map>
-#include <string>
 #include <type_traits>
 
 namespace caf

Fwk/AppFwk/cafProjectDataModel/cafPdmDocument.h

@@ -35,9 +35,9 @@
 //##################################################################################################
 
 #pragma once
+
 #include "cafPdmField.h"
 #include "cafPdmObject.h"
-#include "cafPdmPointer.h"
 
 namespace caf
 {

Fwk/AppFwk/cafProjectDataModel/cafPdmObject.cpp

@@ -1,5 +1,7 @@
 #include "cafPdmObject.h"
 
+#include "cafPdmUiFieldHandle.h"
+
 using namespace caf;
 
 CAF_PDM_ABSTRACT_SOURCE_INIT( PdmObject, "PdmObjectBase" );
@@ -15,6 +17,20 @@ caf::PdmObject::PdmObject()
     CAF_PDM_InitObject( "Base PDM Object", "", "", "The Abstract Base Class for the Project Data Model" );
 }
 
+//--------------------------------------------------------------------------------------------------
+///
+//--------------------------------------------------------------------------------------------------
+void PdmObject::addFieldUiNoDefault( PdmFieldHandle* field, const QString& keyword, PdmUiItemInfo* fieldDescription )
+{
+    addField( field, keyword );
+
+    PdmUiFieldHandle* uiFieldHandle = field->uiCapability();
+    if ( uiFieldHandle )
+    {
+        uiFieldHandle->setUiItemInfo( fieldDescription );
+    }
+}
+
 //--------------------------------------------------------------------------------------------------
 ///
 //--------------------------------------------------------------------------------------------------

Fwk/AppFwk/cafProjectDataModel/cafPdmObject.h

@@ -38,27 +38,16 @@
 
 #include "cafPdmObjectHandle.h"
 
-#include "cafPdmPointer.h"
-#include "cafPdmUiOrdering.h"
-
-#include <set>
-
 class QXmlStreamReader;
 class QXmlStreamWriter;
 
+#include "cafInternalPdmUiFieldCapability.h"
 #include "cafPdmObjectCapability.h"
-
 #include "cafPdmUiObjectHandle.h"
+#include "cafPdmUiOrdering.h"
 #include "cafPdmXmlObjectHandle.h"
 #include "cafPdmXmlObjectHandleMacros.h"
 
-#include "cafInternalPdmUiFieldCapability.h"
-#include "cafInternalPdmXmlFieldCapability.h"
-#include "cafPdmFieldHandle.h"
-
-#include "cafIconProvider.h"
-#include "cafPdmUiFieldSpecialization.h"
-
 namespace caf
 {
 class PdmFieldHandle;
@@ -183,16 +172,7 @@ public:
 
     /// Does the same as the above method, but omits the default value.
     /// Consider this method private. Please use the CAF_PDM_InitFieldNoDefault() macro instead.
-    void addFieldUiNoDefault( PdmFieldHandle* field, const QString& keyword, PdmUiItemInfo* fieldDescription )
+    void addFieldUiNoDefault( PdmFieldHandle* field, const QString& keyword, PdmUiItemInfo* fieldDescription );
-    {
-        addField( field, keyword );
-
-        PdmUiFieldHandle* uiFieldHandle = field->uiCapability();
-        if ( uiFieldHandle )
-        {
-            uiFieldHandle->setUiItemInfo( fieldDescription );
-        }
-    }
 
     /// Returns _this_ if _this_ has requested class keyword
     /// Traverses parents recursively and returns first parent of the requested

Fwk/AppFwk/cafProjectDataModel/cafPdmUiCore/cafInternalPdmFieldTypeSpecializations.h

@@ -4,10 +4,6 @@
 #include "cafPdmObjectHandle.h"
 #include "cafPdmPointer.h"
 
-#include <QStringList>
-
-#include <type_traits>
-
 namespace caf
 {
 template <typename T>

Fwk/AppFwk/cafProjectDataModel/cafPdmUiCore/cafInternalPdmUiFieldCapability.h

@@ -1,5 +1,7 @@
 #pragma once
 
+#include "cafPdmChildArrayField.h"
+#include "cafPdmChildField.h"
 #include "cafPdmUiFieldHandle.h"
 
 namespace caf

Fwk/AppFwk/cafProjectDataModel/cafPdmUiCore/cafPdmUiEditorHandle.h

@@ -43,7 +43,6 @@
 
 namespace caf
 {
-class PdmUiItem;
 
 //==================================================================================================
 /// Abstract class to handle editors. Inherits QObject to be able to use signals and slots

Fwk/AppFwk/cafProjectDataModel/cafPdmUiCore/cafPdmUiFieldEditorHandle.cpp

@@ -42,9 +42,7 @@
 #include "cafPdmUiObjectHandle.h"
 
 #include <QAbstractScrollArea>
-#include <QLabel>
 #include <QMenu>
-#include <QVariant>
 
 namespace caf
 {
@@ -137,6 +135,30 @@ void PdmUiFieldEditorHandle::createWidgets( QWidget* parent )
     }
 }
 
+//--------------------------------------------------------------------------------------------------
+///
+//--------------------------------------------------------------------------------------------------
+QWidget* PdmUiFieldEditorHandle::combinedWidget()
+{
+    return m_combinedWidget;
+}
+
+//--------------------------------------------------------------------------------------------------
+///
+//--------------------------------------------------------------------------------------------------
+QWidget* PdmUiFieldEditorHandle::editorWidget()
+{
+    return m_editorWidget;
+}
+
+//--------------------------------------------------------------------------------------------------
+///
+//--------------------------------------------------------------------------------------------------
+QWidget* PdmUiFieldEditorHandle::labelWidget()
+{
+    return m_labelWidget;
+}
+
 //--------------------------------------------------------------------------------------------------
 ///
 //--------------------------------------------------------------------------------------------------
@@ -153,6 +175,30 @@ int PdmUiFieldEditorHandle::rowStretchFactor() const
     return isMultiRowEditor() ? 1 : 0;
 }
 
+//--------------------------------------------------------------------------------------------------
+///
+//--------------------------------------------------------------------------------------------------
+QWidget* PdmUiFieldEditorHandle::createCombinedWidget( QWidget* parent )
+{
+    return nullptr;
+}
+
+//--------------------------------------------------------------------------------------------------
+///
+//--------------------------------------------------------------------------------------------------
+QWidget* PdmUiFieldEditorHandle::createEditorWidget( QWidget* parent )
+{
+    return nullptr;
+}
+
+//--------------------------------------------------------------------------------------------------
+///
+//--------------------------------------------------------------------------------------------------
+QWidget* PdmUiFieldEditorHandle::createLabelWidget( QWidget* parent )
+{
+    return nullptr;
+}
+
 //--------------------------------------------------------------------------------------------------
 ///
 //--------------------------------------------------------------------------------------------------

Fwk/AppFwk/cafProjectDataModel/cafPdmUiCore/cafPdmUiFieldEditorHandle.h

@@ -40,14 +40,6 @@
 #include "cafPdmUiEditorHandle.h"
 #include "cafQShortenedLabel.h"
 
-#include <vector>
-
-#include <QPointer>
-#include <QString>
-#include <QWidget>
-
-class QLabel;
-
 namespace caf
 {
 //==================================================================================================
@@ -99,9 +91,9 @@ public:
     void              setUiField( PdmUiFieldHandle* uiFieldHandle );
 
     void     createWidgets( QWidget* parent );
-    QWidget* combinedWidget() { return m_combinedWidget; }
+    QWidget* combinedWidget();
-    QWidget* editorWidget() { return m_editorWidget; }
+    QWidget* editorWidget();
-    QWidget* labelWidget() { return m_labelWidget; }
+    QWidget* labelWidget();
     QMargins labelContentMargins() const;
     int      rowStretchFactor() const;
 
@@ -109,9 +101,9 @@ protected: // Virtual interface to override
     /// Implement one of these, or both editor and label. The widgets will be used in the parent layout according to
     /// being "Label" Editor" or a single combined widget.
 
-    virtual QWidget* createCombinedWidget( QWidget* parent ) { return nullptr; }
+    virtual QWidget* createCombinedWidget( QWidget* parent );
-    virtual QWidget* createEditorWidget( QWidget* parent ) { return nullptr; }
+    virtual QWidget* createEditorWidget( QWidget* parent );
-    virtual QWidget* createLabelWidget( QWidget* parent ) { return nullptr; }
+    virtual QWidget* createLabelWidget( QWidget* parent );
 
     void setValueToField( const QVariant& value );
 

Fwk/AppFwk/cafProjectDataModel/cafPdmUiCore/cafPdmUiItem.cpp

@@ -35,7 +35,6 @@
 //##################################################################################################
 
 #include "cafPdmUiItem.h"
-#include "cafPdmPtrField.h"
 #include "cafPdmUiEditorHandle.h"
 #include "cafPdmUiObjectEditorHandle.h"
 

Fwk/AppFwk/cafProjectDataModel/cafPdmUiCore/cafPdmUiItem.h

@@ -39,10 +39,6 @@
 #include "cafIconProvider.h"
 #include "cafPdmUiFieldSpecialization.h"
 
-#include <QApplication>
-#include <QColor>
-#include <QString>
-#include <QVariant>
 #include <set>
 #include <type_traits>
 

Fwk/AppFwk/cafProjectDataModel/cafPdmUiCore/cafPdmUiObjectEditorHandle.h

@@ -37,7 +37,6 @@
 
 #pragma once
 
-#include "cafPdmPointer.h"
 #include "cafPdmUiEditorHandle.h"
 
 #include <QPointer>

Fwk/AppFwk/cafProjectDataModel/cafPdmUiCore/cafPdmUiOrdering.cpp

@@ -36,7 +36,6 @@
 
 #include "cafPdmUiOrdering.h"
 
-#include "cafPdmDataValueField.h"
 #include "cafPdmObjectHandle.h"
 #include "cafPdmUiFieldHandle.h"
 #include "cafPdmUiObjectHandle.h"

Fwk/AppFwk/cafProjectDataModel/cafPdmUiCore/cafPdmUiTreeOrdering.cpp

@@ -37,7 +37,6 @@
 #include "cafPdmUiTreeOrdering.h"
 
 #include "cafAssert.h"
-#include "cafPdmDataValueField.h"
 #include "cafPdmObjectHandle.h"
 #include "cafPdmUiEditorHandle.h"
 #include "cafPdmUiFieldHandle.h"

Fwk/AppFwk/cafProjectDataModel/cafPdmUiCore/cafPdmUiTreeOrdering.h

@@ -41,8 +41,6 @@
 #include <QList>
 #include <QString>
 
-#include <vector>
-
 namespace caf
 {
 class PdmFieldHandle;

Fwk/AppFwk/cafProjectDataModel/cafPdmUiCore/cafQShortenedLabel.cpp

@@ -36,9 +36,7 @@
 #include "cafQShortenedLabel.h"
 
 #include <QApplication>
-#include <QFontMetrics>
 #include <QResizeEvent>
-#include <QVBoxLayout>
 
 using namespace caf;
 

Fwk/AppFwk/cafProjectDataModel/cafPdmUiCore/cafSelectionManager.h

@@ -37,7 +37,6 @@
 
 #include "cafSelectionChangedReceiver.h"
 
-#include "cafPdmField.h"
 #include "cafPdmObjectHandle.h"
 #include "cafPdmPointer.h"
 #include "cafPdmUiItem.h"

Fwk/AppFwk/cafProjectDataModel/cafPdmUiCore/cafUiTreeItem.h

@@ -36,7 +36,6 @@
 
 #pragma once
 
-//#include <QAbstractItemModel>
 #include <QList>
 #include <iostream>
 

Fwk/AppFwk/cafProjectDataModel/cafPdmXml/cafInternalPdmXmlFieldCapability.inl

@@ -2,6 +2,8 @@
 #include "cafAssert.h"
 #include "cafInternalPdmFieldIoHelper.h"
 #include "cafPdmObjectFactory.h"
+#include "cafPdmObjectHandle.h"
+#include "cafPdmReferenceHelper.h"
 #include "cafPdmXmlObjectHandle.h"
 
 #include <QStringList>

Fwk/AppFwk/cafProjectDataModel/cafPdmXml/cafInternalPdmXmlFieldReaderWriter.h

@@ -7,7 +7,6 @@
 #include "cafInternalPdmFieldIoHelper.h"
 #include "cafInternalPdmFilePathStreamOperators.h"
 #include "cafInternalPdmStreamOperators.h"
-#include "cafPdmReferenceHelper.h"
 
 namespace caf
 {
@@ -71,56 +70,4 @@ void PdmFieldReader<DataType>::readFieldData( DataType& fieldValue, QXmlStreamRe
 template <>
 void PdmFieldReader<QString>::readFieldData( QString& field, QXmlStreamReader& xmlStream, PdmObjectFactory* objectFactory );
 
-#if 0
-//--------------------------------------------------------------------------------------------------
-/// Specialized IO for PdmPointer
-//--------------------------------------------------------------------------------------------------
-template <typename DataType>
-struct PdmFieldWriter< PdmPointer<DataType> >
-{
-    static void writeFieldData(const PdmPointer<DataType> & fieldValue, QXmlStreamWriter& xmlStream, PdmReferenceHelper* referenceHelper)
-    {
-        QString dataString; 
-
-        CAF_ASSERT(referenceHelper);
-
-        if (fieldValue.isNull())
-        {
-            dataString = "NULL";
-        }
-        else
-        {
-            dataString = referenceHelper->referenceFromRootToObject(fieldValue.p());
-        }
-
-        xmlStream.writeCharacters(dataString);  
-    }
-};
-
-template <typename DataType>
-struct PdmFieldReader< PdmPointer<DataType> >
-{
-    static void readFieldData(PdmPointer<DataType> & fieldValue, QXmlStreamReader& xmlStream, PdmObjectFactory*, PdmReferenceHelper* referenceHelper)
-    {
-        PdmFieldIOHelper::skipComments(xmlStream);
-        if (!xmlStream.isCharacters()) return;
-
-        QString dataString = xmlStream.text().toString();
-
-        // Make stream point to end of element
-        QXmlStreamReader::TokenType type = xmlStream.readNext();
-        Q_UNUSED(type);
-        PdmFieldIOHelper::skipCharactersAndComments(xmlStream);
-
-        if (dataString != "NULL")
-        {
-            CAF_ASSERT(referenceHelper);
-            
-            PdmObjectHandle* objHandle = referenceHelper->objectFromReference(dataString);
-            fieldValue.setRawPtr(objHandle);
-        }
-    }
-};
-
-#endif
 } // End of namespace caf

Fwk/AppFwk/cafProjectDataModel/cafPdmXml/cafPdmSettings.cpp

@@ -35,10 +35,12 @@
 //##################################################################################################
 
 #include "cafPdmSettings.h"
-
+#include "cafPdmObjectHandle.h"
-#include "cafPdmField.h"
+#include "cafPdmValueField.h"
 #include "cafPdmXmlObjectHandle.h"
 
+#include <QSettings>
+
 namespace caf
 {
 //--------------------------------------------------------------------------------------------------

Fwk/AppFwk/cafProjectDataModel/cafPdmXml/cafPdmSettings.h

@@ -36,7 +36,7 @@
 
 #pragma once
 
-#include <QSettings>
+#include <QString>
 
 namespace caf
 {

Fwk/AppFwk/cafProjectDataModel/cafPdmXml/cafPdmXmlFieldHandle.h

@@ -2,7 +2,6 @@
 
 #include "cafPdmFieldCapability.h"
 #include <QString>
-#include <vector>
 
 class QXmlStreamReader;
 class QXmlStreamWriter;

Fwk/AppFwk/cafTests/cafTestApplication/LineEditAndPushButtons.cpp

@@ -7,6 +7,8 @@
 #include "cafPdmUiPushButtonEditor.h"
 #include "cafPdmUiTreeSelectionEditor.h"
 
+#include <QGuiApplication>
+
 CAF_PDM_SOURCE_INIT( LineEditAndPushButtons, "LineEditAndPushButtons" );
 
 //--------------------------------------------------------------------------------------------------

Fwk/AppFwk/cafTests/cafTestApplication/MainWindow.cpp

@@ -33,7 +33,6 @@
 #include "cafPdmUiFilePathEditor.h"
 #include "cafPdmUiItem.h"
 #include "cafPdmUiListEditor.h"
-#include "cafPdmUiOrdering.h"
 #include "cafPdmUiPropertyView.h"
 #include "cafPdmUiPushButtonEditor.h"
 #include "cafPdmUiTableView.h"

Fwk/AppFwk/cafUserInterface/cafPdmUiActionPushButtonEditor.cpp

@@ -41,7 +41,6 @@
 #include "cafPdmField.h"
 #include "cafPdmObject.h"
 #include "cafPdmUiFieldEditorHandle.h"
-#include "cafPdmUiOrdering.h"
 
 #include "cafFactory.h"
 

Fwk/AppFwk/cafUserInterface/cafPdmUiCheckBoxAndTextEditor.cpp

@@ -41,8 +41,6 @@
 #include "cafPdmUiDefaultObjectEditor.h"
 #include "cafPdmUiFieldEditorHandle.h"
 #include "cafPdmUiLineEditor.h"
-#include "cafPdmUiOrdering.h"
-#include "cafQShortenedLabel.h"
 
 #include <QHBoxLayout>
 #include <QLabel>

Fwk/AppFwk/cafUserInterface/cafPdmUiCheckBoxEditor.cpp

@@ -41,8 +41,6 @@
 #include "cafPdmField.h"
 #include "cafPdmObject.h"
 #include "cafPdmUiFieldEditorHandle.h"
-#include "cafPdmUiOrdering.h"
-#include "cafQShortenedLabel.h"
 
 #include "cafFactory.h"
 

Fwk/AppFwk/cafUserInterface/cafPdmUiCheckBoxTristateEditor.cpp

@@ -7,8 +7,6 @@
 #include "cafPdmField.h"
 #include "cafPdmObject.h"
 #include "cafPdmUiFieldEditorHandle.h"
-#include "cafPdmUiOrdering.h"
-#include "cafQShortenedLabel.h"
 
 #include "cafFactory.h"
 #include "cafTristate.h"

Fwk/AppFwk/cafUserInterface/cafPdmUiColorEditor.cpp

@@ -41,8 +41,6 @@
 #include "cafPdmField.h"
 #include "cafPdmObject.h"
 #include "cafPdmUiFieldEditorHandle.h"
-#include "cafPdmUiOrdering.h"
-#include "cafQShortenedLabel.h"
 
 #include "cafFactory.h"
 

Fwk/AppFwk/cafUserInterface/cafPdmUiComboBoxEditor.cpp

@@ -40,7 +40,6 @@
 #include "cafPdmField.h"
 #include "cafPdmObject.h"
 #include "cafPdmUiFieldEditorHandle.h"
-#include "cafQShortenedLabel.h"
 #include "cafUiAppearanceSettings.h"
 #include "cafUiIconFactory.h"
 

Fwk/AppFwk/cafUserInterface/cafPdmUiDateEditor.cpp

@@ -41,8 +41,6 @@
 #include "cafPdmObject.h"
 #include "cafPdmUiDefaultObjectEditor.h"
 #include "cafPdmUiFieldEditorHandle.h"
-#include "cafPdmUiOrdering.h"
-#include "cafQShortenedLabel.h"
 #include "cafSelectionManager.h"
 
 #include <QApplication>

Fwk/AppFwk/cafUserInterface/cafPdmUiDoubleSliderEditor.cpp

@@ -39,7 +39,6 @@
 #include "cafPdmField.h"
 #include "cafPdmUiFieldHandle.h"
 #include "cafPdmUiObjectHandle.h"
-#include "cafQShortenedLabel.h"
 
 #include <QDoubleValidator>
 #include <QHBoxLayout>

Fwk/AppFwk/cafUserInterface/cafPdmUiDoubleValueEditor.cpp

@@ -42,7 +42,6 @@
 #include "cafPdmUiFieldEditorHandle.h"
 
 #include "cafFactory.h"
-#include "cafQShortenedLabel.h"
 
 #include <QDoubleValidator>
 #include <QHBoxLayout>

Fwk/AppFwk/cafUserInterface/cafPdmUiFilePathEditor.cpp

@@ -42,9 +42,8 @@
 #include "cafPdmUiDefaultObjectEditor.h"
 #include "cafPdmUiFieldEditorHandle.h"
 #include "cafPdmUiLineEditor.h"
-#include "cafPdmUiOrdering.h"
-#include "cafQShortenedLabel.h"
 
+#include <QApplication>
 #include <QBoxLayout>
 #include <QClipboard>
 #include <QDir>

Fwk/AppFwk/cafUserInterface/cafPdmUiFormLayoutObjectEditor.h

@@ -36,7 +36,6 @@
 
 #pragma once
 
-#include "cafPdmUiOrdering.h"
 #include "cafPdmUiWidgetObjectEditorHandle.h"
 
 #include <QPointer>

Fwk/AppFwk/cafUserInterface/cafPdmUiLineEditor.cpp

@@ -41,9 +41,7 @@
 #include "cafPdmObject.h"
 #include "cafPdmUiDefaultObjectEditor.h"
 #include "cafPdmUiFieldEditorHandle.h"
-#include "cafPdmUiOrdering.h"
 #include "cafPdmUniqueIdValidator.h"
-#include "cafQShortenedLabel.h"
 #include "cafSelectionManager.h"
 #include "cafUiAppearanceSettings.h"
 #include "cafUiIconFactory.h"

Fwk/AppFwk/cafUserInterface/cafPdmUiListEditor.cpp

@@ -41,9 +41,6 @@
 #include "cafPdmUiDefaultObjectEditor.h"
 #include "cafPdmUiFieldEditorHandle.h"
 
-#include "cafFactory.h"
-#include "cafQShortenedLabel.h"
-
 #include <QApplication>
 #include <QBoxLayout>
 #include <QClipboard>

Fwk/AppFwk/cafUserInterface/cafPdmUiPushButtonEditor.cpp

@@ -41,10 +41,8 @@
 #include "cafPdmField.h"
 #include "cafPdmObject.h"
 #include "cafPdmUiFieldEditorHandle.h"
-#include "cafPdmUiOrdering.h"
 
 #include "cafFactory.h"
-#include "cafQShortenedLabel.h"
 
 #include <QBoxLayout>
 

Fwk/AppFwk/cafUserInterface/cafPdmUiPushButtonEditor.h

@@ -35,12 +35,14 @@
 //##################################################################################################
 
 #pragma once
+
 #include "cafPdmUiFieldEditorHandle.h"
 
 #include <QLabel>
 #include <QPointer>
 #include <QPushButton>
 #include <QWidget>
+
 class QHBoxLayout;
 
 namespace caf

Fwk/AppFwk/cafUserInterface/cafPdmUiSliderEditor.cpp

@@ -42,7 +42,6 @@
 #include "cafPdmUiFieldEditorHandle.h"
 
 #include "cafFactory.h"
-#include "cafQShortenedLabel.h"
 
 #include <QHBoxLayout>
 #include <QIntValidator>

Fwk/AppFwk/cafUserInterface/cafPdmUiSliderEditor.h

@@ -35,6 +35,7 @@
 //##################################################################################################
 
 #pragma once
+
 #include "cafPdmUiFieldEditorHandle.h"
 
 #include <QGroupBox>

Fwk/AppFwk/cafUserInterface/cafPdmUiTableRowEditor.cpp

@@ -36,9 +36,8 @@
 
 #include "cafPdmUiTableRowEditor.h"
 
-#include "cafPdmField.h"
+#include "cafPdmUiObjectHandle.h"
-#include "cafPdmObject.h"
+#include "cafPdmUiOrdering.h"
-#include "cafPdmUiEditorHandle.h"
 #include "cafPdmUiTableViewQModel.h"
 
 namespace caf

Fwk/AppFwk/cafUserInterface/cafPdmUiTableViewEditor.cpp

@@ -42,7 +42,6 @@
 #include "cafPdmUiEditorHandle.h"
 #include "cafPdmUiTableViewDelegate.h"
 #include "cafPdmUiTableViewQModel.h"
-#include "cafQShortenedLabel.h"
 #include "cafSelectionManager.h"
 
 #include <QApplication>

Fwk/AppFwk/cafUserInterface/cafPdmUiTableViewEditor.h

@@ -36,11 +36,11 @@
 
 #pragma once
 
-#include "cafPdmDocument.h"
 #include "cafPdmUiFieldEditorHandle.h"
 #include "cafSelectionChangedReceiver.h"
 
 #include <QAbstractItemModel>
+#include <QBoxLayout>
 #include <QPointer>
 #include <QTableView>
 #include <QWidget>

Fwk/AppFwk/cafUserInterface/cafPdmUiTableViewQModel.cpp

@@ -37,18 +37,13 @@
 #include "cafPdmUiTableViewQModel.h"
 
 #include "cafPdmChildArrayField.h"
-#include "cafPdmField.h"
-#include "cafPdmObject.h"
-#include "cafPdmUiComboBoxEditor.h"
 #include "cafPdmUiCommandSystemProxy.h"
 #include "cafPdmUiDateEditor.h"
 #include "cafPdmUiFieldEditorHelper.h"
 #include "cafPdmUiLineEditor.h"
+#include "cafPdmUiObjectHandle.h"
+#include "cafPdmUiOrdering.h"
 #include "cafPdmUiTableRowEditor.h"
-#include "cafPdmUiTableView.h"
-#include "cafSelectionManager.h"
-
-#include <QTableView>
 
 namespace caf
 {

Fwk/AppFwk/cafUserInterface/cafPdmUiTextEditor.cpp

@@ -40,8 +40,6 @@
 #include "cafPdmObject.h"
 #include "cafPdmUiDefaultObjectEditor.h"
 #include "cafPdmUiFieldEditorHandle.h"
-#include "cafPdmUiOrdering.h"
-#include "cafQShortenedLabel.h"
 
 #include <QIntValidator>
 #include <QLabel>

Fwk/AppFwk/cafUserInterface/cafPdmUiTextEditor.h

@@ -35,7 +35,9 @@
 //##################################################################################################
 
 #pragma once
+
 #include "cafPdmUiFieldEditorHandle.h"
+
 #include <QLabel>
 #include <QPointer>
 #include <QPushButton>

Fwk/AppFwk/cafUserInterface/cafPdmUiTimeEditor.cpp

@@ -41,8 +41,6 @@
 #include "cafPdmObject.h"
 #include "cafPdmUiDefaultObjectEditor.h"
 #include "cafPdmUiFieldEditorHandle.h"
-#include "cafPdmUiOrdering.h"
-#include "cafQShortenedLabel.h"
 #include "cafSelectionManager.h"
 
 #include <QApplication>

Fwk/AppFwk/cafUserInterface/cafPdmUiTimeEditor.h

@@ -38,7 +38,6 @@
 
 #include "cafPdmUiFieldEditorHandle.h"
 
-#include <QLabel>
 #include <QPointer>
 #include <QString>
 #include <QTimeEdit>