OilfieldToolsNet/ResInsight
4
0 Fork 0
mirror of https://github.com/OPM/ResInsight.git synced 2026-10-31 17:17:50 -05:00
Code Issues Packages Projects Releases Wiki Activity

#14477 MSW: Restore diameter and roughness for fishbones ICD subs

Browse Source 
The fishbones ICD sub segment left RigMswSegment::diameter and roughness unset, and the formatter renders an empty optional as the 1* default marker. The legacy tree path emitted 0.15 and 5.0e-5 for these rows, taken from the RicMswSegment constructor defaults. RigMswSegment has never had such defaults, so the comment claiming the tree behaviour was matched was wrong.

Set both values explicitly, as buildFractureBranches already does. Verified against TestModels/msw-export/project-files/fishbones.rsp: the ICD sub WELSEGS row again exports 0.15000 and 0.0000500, matching the stored legacy reference output.
This commit is contained in:
Magne Sjaastad committed 2026-08-07 13:29:32 +02:00
1 parent 593f27dcf4
commit c3801b268e
1 file changed
+5 -4
Download Patch File Download Diff File Expand all files Collapse all files
ApplicationLibCode/Commands/CompletionExportCommands/MswExport/RicMswBranchBuilder.cpp
+5 -4
View File
@@ -844,10 +844,11 @@ std::vector<RigMswBranch> buildFishbonesBranches( const RimEclipseCase*
icdSeg.outletSegmentNumber = outletSeg;
icdSeg.length = icdLength;
icdSeg.depth = icdDepth;
// Use RigMswSegment defaults for diameter/roughness (matching tree approach for fishbones ICD)
icdSeg.sourceWellName = wellPath->name().toStdString();
icdSeg.description = QString( "ICD sub %1" ).arg( subIndex + 1 ).toStdString();
icdSeg.intersections = std::move( icdCompsegs );
icdSeg.diameter = 0.15; // default segment diameter
icdSeg.roughness = 5.0e-5; // default segment roughness
icdSeg.sourceWellName = wellPath->name().toStdString();
icdSeg.description = QString( "ICD sub %1" ).arg( subIndex + 1 ).toStdString();
icdSeg.intersections = std::move( icdCompsegs );
WsegvalvRow wv;
wv.well = wellNameForExport;