OilfieldToolsNet/ResInsight
4
0
Fork 0
mirror of https://github.com/OPM/ResInsight.git synced 2025-02-25 18:55:39 -06:00
Code Issues Packages Projects Releases Wiki Activity

Replace RifRoffReader code to utilize roffcpp::reader (#10098)

Browse Source 
- Replace current content if RifRoffReader to utilize roffcpp
- Remove unit tests not applicable for function (some previous tests now belongs to roffcpp)
This commit is contained in:
Jørgen Herje
2023-04-17 09:45:14 +02:00
committed by GitHub
parent 6f6dc80bc6
commit c7b915c141
4 changed files with 31 additions and 126 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
ApplicationLibCode/UnitTests/RifRoffReader-Test.cpp
View File

@@ -16,7 +16,7 @@ TEST( RifRoffReader, ReadValidFile )
EXPECT_TRUE( QFile::exists( filePath ) );
std::map<int, QString> codeNames;
RifRoffReader::readCodeNames( filePath, codeNames );
RifRoffReader::readCodeNames( filePath, "composite", codeNames );
ASSERT_EQ( 6u, codeNames.size() );
for ( int i = 0; i < 6; i++ )
@@ -35,7 +35,7 @@ std::string readIncorrectFile( const QString filename )
std::map<int, QString> codeNames;
try
{
RifRoffReader::readCodeNames( filePath, codeNames );
RifRoffReader::readCodeNames( filePath, "composite", codeNames );
return "";
}
catch ( RifRoffReaderException& ex )
@@ -44,13 +44,6 @@ std::string readIncorrectFile( const QString filename )
}
}
TEST( RifRoffReader, ReadWrongFileType )
{
// Read a surface file: no expected to work
QString filename( "RifSurfaceImporter/test.ptl" );
ASSERT_EQ( readIncorrectFile( filename ), std::string( "Unexpected file type: roff-asc header missing." ) );
}
TEST( RifRoffReader, ReadNonExistingFileType )
{
// Read a non-existing file
@@ -58,13 +51,6 @@ TEST( RifRoffReader, ReadNonExistingFileType )
ASSERT_EQ( readIncorrectFile( filename ), std::string( "Unable to open roff file." ) );
}
TEST( RifRoffReader, ReadFileWithIncorrectInteger )
{
// Read a file with incorrect integer for code values
QString filename( "RifRoffReader/code_values_integer_wrong.roff" );
ASSERT_EQ( readIncorrectFile( filename ), std::string( "Unexpected value: not an integer." ) );
}
TEST( RifRoffReader, ReadFileCodeNamesMissing )
{
// Read a file without code names