#13000 Fishbones completion: Avoid overwrite of default values

Always call setSystemParameters after appendFishbonesSubs
This commit is contained in:
Magne Sjaastad committed 2025-10-13 13:10:33 +02:00
1 parent 45d1a4a9f8
commit cf5da1ff7a
1 file changed
+3 -3
@@ -160,8 +160,9 @@ RimFishbones* RimFishbonesCollection::appendFishbonesSubsAtLocations( const std:
auto* obj = new RimFishbones;
obj->setValveLocations( subLocations );
RimFishbonesDefines::RicFishbonesSystemParameters customParameters = RimFishbonesDefines::drillingStandardParameters();
appendFishbonesSubs( obj );
RimFishbonesDefines::RicFishbonesSystemParameters customParameters = RimFishbonesDefines::drillingStandardParameters();
if ( drillingType == RimFishbonesDefines::DrillingType::EXTENDED )
{
customParameters = RimFishbonesDefines::drillingExtendedParameters();
@@ -171,14 +172,13 @@ RimFishbones* RimFishbonesCollection::appendFishbonesSubsAtLocations( const std:
customParameters = RimFishbonesDefines::acidJettingParameters();
}
// NB: Setting the system parameters must be done after appendFishbonesSubs, as the latter sets some default values
obj->setSystemParameters( customParameters.lateralsPerSub,
customParameters.lateralLength,
customParameters.holeDiameter,
customParameters.buildAngle,
customParameters.icdsPerSub );
appendFishbonesSubs( obj );
return obj;
}