#3581 Temp LGR. No recreation of faults after creating temporary LGRs

ApplicationCode/Commands/RicCreateTemporaryLgrFeature.cpp

@@ -142,7 +142,7 @@ void RicCreateTemporaryLgrFeature::onActionTriggered(bool isChecked)
                 }
             }
 
-            mainGrid->calculateFaults(activeCellInfo, true);
+            mainGrid->calculateFaults(activeCellInfo);
         }
 
         RiuSelectionManager::instance()->deleteAllItems(RiuSelectionManager::RUI_APPLICATION_GLOBAL);

ApplicationCode/ReservoirDataModel/RigFault.h

@@ -49,9 +49,14 @@ public:
     }
 
     inline int faultIdx(size_t reservoirCellIndex, cvf::StructGridInterface::FaceType face) const
+    {
+        // Ensure no crash after creating temporary LGRs
+        if (reservoirCellIndex < m_faultIdxForCellFace.size())
         {
             return m_faultIdxForCellFace[reservoirCellIndex][face];
         }
+        return NO_FAULT;
+    }
 
     inline void setFaultIdx(size_t reservoirCellIndex, cvf::StructGridInterface::FaceType face, int faultIdx)
     {

ApplicationCode/ReservoirDataModel/RigMainGrid.cpp

@@ -421,9 +421,9 @@ bool RigMainGrid::hasFaultWithName(const QString& name) const
 //--------------------------------------------------------------------------------------------------
 ///
 //--------------------------------------------------------------------------------------------------
-void RigMainGrid::calculateFaults(const RigActiveCellInfo* activeCellInfo, bool forceCalculation)
+void RigMainGrid::calculateFaults(const RigActiveCellInfo* activeCellInfo)
 {
-    if (!forceCalculation && hasFaultWithName(RiaDefines::undefinedGridFaultName()) &&
+    if (hasFaultWithName(RiaDefines::undefinedGridFaultName()) &&
         hasFaultWithName(RiaDefines::undefinedGridFaultWithInactiveName()))
     {
         // RiaLogging::debug(QString("Calculate faults already run for grid."));
@@ -431,8 +431,6 @@ void RigMainGrid::calculateFaults(const RigActiveCellInfo* activeCellInfo, bool
         return;
     }
 
-    m_faults.clear();
-
     m_faultsPrCellAcc = new RigFaultsPrCellAccumulator(m_cells.size());
 
     // Spread fault idx'es on the cells from the faults

ApplicationCode/ReservoirDataModel/RigMainGrid.h

@@ -72,7 +72,7 @@ public:
     RigNNCData*                             nncData();
     void                                    setFaults(const cvf::Collection<RigFault>& faults);
     const cvf::Collection<RigFault>&        faults();
-    void                                    calculateFaults(const RigActiveCellInfo* activeCellInfo, bool forceCalculation = false);
+    void                                    calculateFaults(const RigActiveCellInfo* activeCellInfo);
 
     void distributeNNCsToFaults();