mirror of
https://github.com/OPM/ResInsight.git
synced 2025-02-25 18:55:39 -06:00
cppcheck : Avoid mix of signed/unsigned and remove unused code
This commit is contained in:
@@ -114,10 +114,8 @@ RimSummaryCurve* RicSummaryPlotFeatureImpl::addDefaultCurveToPlot( RimSummaryPlo
|
||||
std::vector<RimSummaryCurve*> RicSummaryPlotFeatureImpl::addDefaultCurvesToPlot( RimSummaryPlot* plot,
|
||||
RimSummaryCase* summaryCase )
|
||||
{
|
||||
std::vector<RimSummaryCurve*> defaultCurves;
|
||||
|
||||
QString curvesTextFilter = RiaApplication::instance()->preferences()->defaultSummaryCurvesTextFilter;
|
||||
QStringList curveFilters = curvesTextFilter.split( ";", QString::SkipEmptyParts );
|
||||
QString curvesTextFilter = RiaApplication::instance()->preferences()->defaultSummaryCurvesTextFilter;
|
||||
QStringList curveFilters = curvesTextFilter.split(";", QString::SkipEmptyParts);
|
||||
|
||||
return addCurvesFromAddressFiltersToPlot( curveFilters, plot, summaryCase, false );
|
||||
}
|
||||
@@ -762,12 +760,11 @@ std::set<RifEclipseSummaryAddress>
|
||||
|
||||
filteredSummaryAdressesFromCase( summaryAddressFilters, addrs, &filteredAdressesFromCases, &usedFilters );
|
||||
|
||||
for ( int cfIdx = 0; cfIdx < usedFilters.size(); ++cfIdx )
|
||||
for ( size_t cfIdx = 0 ; cfIdx < usedFilters.size() ; ++cfIdx )
|
||||
{
|
||||
if ( !usedFilters[cfIdx] )
|
||||
{
|
||||
RiaLogging::warning( "Vector filter \"" + summaryAddressFilters[cfIdx] +
|
||||
"\" did not match anything in case: \"" + sumCase->caseName() + "\"" );
|
||||
RiaLogging::warning("Vector filter \"" + summaryAddressFilters[static_cast<int>(cfIdx)] + "\" did not match anything in case: \"" + sumCase->caseName() + "\"");
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -789,12 +786,11 @@ std::vector<RimSummaryCurve*> RicSummaryPlotFeatureImpl::addCurvesFromAddressFil
|
||||
|
||||
filteredSummaryAdressesFromCase( curveFilters, addrs, &curveAddressesToUse, &usedFilters );
|
||||
|
||||
for ( int cfIdx = 0; cfIdx < usedFilters.size(); ++cfIdx )
|
||||
for (size_t cfIdx = 0 ; cfIdx < usedFilters.size() ; ++cfIdx)
|
||||
{
|
||||
if ( !usedFilters[cfIdx] )
|
||||
{
|
||||
RiaLogging::warning( "Vector filter \"" + curveFilters[cfIdx] + "\" did not match anything in case: \"" +
|
||||
summaryCase->caseName() + "\"" );
|
||||
RiaLogging::warning("Vector filter \"" + curveFilters[static_cast<int>(cfIdx)] + "\" did not match anything in case: \"" + summaryCase->caseName() + "\"");
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user