Commit Graph
89 Commits
Author SHA1 Message Date
Magne Sjaastad a00bfea40b #11663 Make sure non-Darcy data is computed
The computation of non-Darcy properties is expensive, so we cache the results. Make sure that the calling function calls this function before using the properties.
2024-09-05 08:41:06 +02:00
Magne Sjaastad d0b5c8d9cb #11134 Export completions: Call ensureReservoirCaseIsOpen before export
This change will enable export without any open views.
2024-01-30 14:34:33 +01:00
Magne Sjaastad 6922ba22b0 Improve reload and replace of cases
* Move code to from features to helper classes
* Ask user if replace case should also happen for the associated grid or summary file
2024-01-25 10:41:57 +01:00
Magne Sjaastad 68a4d54af2 #10754: Exclude COMPDAT for de-activated laterals 2023-11-13 09:17:30 +01:00
Kristian Bendiksen 8930b5b32d #10728 Fractures: add new conductivity in fracture mode to approximate Reveal behavior 2023-10-18 18:30:18 +02:00
Kristian Bendiksen d177491843 #10648 Refactor summary reader: return std::vector<double> instead of taking ptr. 2023-10-02 09:16:52 +02:00
Kristian Bendiksen 8e5788bb24 Reveal: dump StimPlan XML for debugging thermal completions. 2023-09-25 09:33:37 +02:00
Kristian Bendiksen 1899184a41 Janitor: Remove deprecated method. 2023-09-11 17:39:38 +02:00
Kristian Bendiksen 5bf2c2a89d #10367 Janitor: Remove unneccessary 'this' pointers 2023-08-07 13:38:27 +02:00
Magne Sjaastad 1da509166a Improve CmdFeature base class
Add default implementation of isEnabled() and add const
2023-06-26 14:28:46 +02:00
Magne Sjaastad 59ca0b943c Add readability-simplify-boolean-expr
* Add readability-simplify-boolean-expr
* Fixes based on review
2023-06-26 13:12:41 +02:00
Magne Sjaastad 0c90f67dcc Change API for PdmObjectHandle and PdmFieldHandle
* Refactor interface to PdmObjectHandle and PdmFieldHandle
Return objects instead of passing in structures as parameters

* Add nodiscard to several functions
* Remove redundant this->
* Rename to ptrReferencedObjectsByType
2023-05-12 21:41:34 +02:00
Magne Sjaastad 37e29a0f68 Display all data if multiple fractures crosses a cell
- add the operator<=> for QString
- add operator<=> to fracture report item
2023-05-12 16:23:01 +02:00
Magne Sjaastad 5ee764af48 Refactor result definition 2023-05-11 08:37:58 +02:00
Magne Sjaastad b7f8d0e0f1 Increase warning level
* Set warning level to /W3 for MSVC to catch more warnings
* remove several excluded checks for clang
* removed several unused variables
* Hide warnings qwt
* add missing parentheses in logical expressions
* Remove double check on same logical expression
2023-04-17 15:57:39 +02:00
Magne Sjaastad 6f6dc80bc6 Added more clang-tidy checks
Improved GitHub Action to run clang-format as part of clang-tidy

* Simplify clang-tidy workflow
* Added modernize-use-using, modernize-redundant-void-arg, readability-static-accessed-through-instance
* Add nolint for libecl typedefs
2023-04-14 14:07:45 +02:00
Magne Sjaastad 952e766c2f Update clang-format.yml (#10068)
* Update to clang-format-15
Removed two custom .clang-format files in subfolders of AppFwk

* Fixes by clang-format
2023-04-13 07:05:53 +02:00
Magne Sjaastad 39d011b1e6 #9742 Set default value 1* for KH 2023-03-02 14:16:36 +01:00
Magne Sjaastad f8c5cf389f clang-format: Set column width to 140
* Set column width to 140
* Use c++20
* Remove redundant virtual
2023-02-26 10:48:40 +01:00
Magne Sjaastad d91e8ccb56 Avoid throwing exception when opening a file for export 2023-02-13 15:03:42 +01:00
Magne Sjaastad 6ad42817c6 Always use export folder if defined
Rename to m_customFileNameIncludingPath, and split into folder and file name for export object
2023-02-13 15:03:42 +01:00
Magne Sjaastad 8028444018 GitHub Actions: Add apt mirror to make package download more robust
- Download of Ubuntu packages from Azure is unstable. Add mirror sites to improve reliability.
- Improve use of clang-format and include source code changes
2023-02-07 07:22:57 +01:00
Kristian Bendiksen 68db4c7fa5 #9652 Thermal Fractures: fix transmissibilities for long perforation intervals.
Filter out invalid fracture cells (conductivity == positive infinity) when
calculating fracture to well transmissibilities.

Fixes #9652.
2023-01-20 13:31:51 +01:00
Kristian Bendiksen f92da6a98d Completion export: Export user-defined perforation length for azimuth. 2022-12-21 12:08:20 +01:00
Magne Sjaastad 296718fd29 Fix location of ICV for MSW wells
* Show warning if no wells are visible
* #9461 MSW: Start export of a lateral at the tie in location on parent well
Previous implementation used the full well path for the lateral, including the part of the parent well up to sea level.
2022-12-14 08:59:24 +01:00
Magne Sjaastad dfa1bc2cd0 Some fixes for new gcc/clang
Minor fixes for newer gcc/clang. These issues were seen when using ubuntu-latest (Ubuntu 22.04) on Github Actions.
2022-11-25 08:59:10 +01:00
Kristian Bendiksen e8789f3d4b #9470 User defined perf length for azimuth fractures
Fractures: Add UI for user-defined perforation length for az fractures
Add user defined perforation length for azimuth fractures.
Janitor: remove duplication
2022-11-24 10:42:26 +01:00
Kristian Bendiksen 0e49d983a2 Thermal Fracture: make fracture completions export work. 2022-10-03 08:33:55 +02:00
Magne Sjaastad f0ce04597d Merge pull request #8985 from OPM/8926-remove-useoptionsonly
AppFwk : Remove obsolete useOptionsOnly
2022-05-29 13:01:27 +02:00
Magne Sjaastad 93614ef272 Merge pull request #8791 from OPM/8790-rename-to-group
Rename summary references to "Group"
2022-04-07 21:06:40 +02:00
Magne Sjaastad 2c0ebfd14c Make face test robust 2022-02-03 16:30:21 +01:00
Magne Sjaastad 94a541f966 #8513 Use cell face when leaving cell when well path starts inside cell 2022-02-03 16:30:21 +01:00
Magne Sjaastad 3c35244809 #8420 Janitor: Remove empty parameters in initialization macros 2022-01-07 08:31:52 +01:00
Magne Sjaastad 2a65636ba3 #8250 Use variadic macros and remove obsolete parameters 2021-11-14 15:26:09 +01:00
Magne Sjaastad 4366146fbb #8225 MSW export : Adjust position of valve segments 2021-11-02 13:53:42 +01:00
Magne Sjaastad d6b699c38a Janitor : Set optional comment flag for perforations 2021-11-02 13:53:42 +01:00
Magne Sjaastad 299217e219 £8014 : Fix MSW valve export 2021-10-29 14:43:56 +02:00
Magne Sjaastad 54a4f35588 #8142 Preferences : Move system settings into separate file 2021-10-13 12:52:02 +02:00
Magne Sjaastad 0f87c9760d #7862 Export Completion: Add ResInsight project file to file header 2021-09-29 09:42:04 +02:00
Magne Sjaastad 0e0bd751f6 #7973 Export Completions : Further improvements
Fix typo
Make sure compdat export works for custom file name
2021-09-09 15:16:34 +02:00
Magne Sjaastad acdcbe44b4 Merge pull request #7975 from OPM/7973-custom-export-filename
Export Completions : Custom export file name fails in some cases
2021-09-09 10:16:37 +02:00
Magne Sjaastad 638f926429 cmake-format: Allow dangling parenthesis 2021-09-01 08:13:16 +02:00
Magne Sjaastad b78cf3a4bb Use cmake-format on all cmake files 2021-08-26 19:46:38 +02:00
Magne Sjaastad b9362386bc #7450 Well Completion: Allocation of User defined D-factor to perforation connection factors
If the user defined a D-factor for the perforation interval, distribute the D-factor based on

D_cell = D_well * Sum_Tran_cells / Tran_cell
2021-06-07 09:28:57 +02:00
Magne Sjaastad 0097e9dfb2 MSW : Fix length for the WELSWGS incremental depth 2021-05-28 07:27:53 +02:00
Magne Sjaastad 8749deb76a #7731 MSW Fishbones : Adjust diameter for fishbone lateral segments in main bore cells 2021-05-28 07:27:53 +02:00
Magne Sjaastad 1f85adecab #7729 MSW : Compute initial measured depth once
Avoid computing value of initial MD multiple times
2021-05-28 07:27:53 +02:00
Magne Sjaastad eba78b2660 #7729 MSW : Fix wrong segment for lateral
A lateral is connected to wrong segment for user defined reference MD
2021-05-28 07:27:53 +02:00
Magne Sjaastad 33ac79d856 #7727 Performance : Reduce amount of work
Use objectsWithReferringPtrFields to find tieIn wells
Avoid using descendantsOfType
2021-05-27 12:52:57 +02:00
Magne Sjaastad afb293db52 #7727 Well Path : Simplify access to all well paths 2021-05-27 12:52:57 +02:00