Commit Graph

160 Commits

Author SHA1 Message Date
Kristian Bendiksen
7aabe8c4a8 Python: add type hinting to python code.
Types are checked using mypy.

Fixes #10394.
2023-08-23 09:47:44 +02:00
Kristian Bendiksen
5bf2c2a89d #10367 Janitor: Remove unneccessary 'this' pointers 2023-08-07 13:38:27 +02:00
Magne Sjaastad
59ca0b943c
Add readability-simplify-boolean-expr
* Add readability-simplify-boolean-expr
* Fixes based on review
2023-06-26 13:12:41 +02:00
Magne Sjaastad
40080a99de
9978 Improve UI for long drop-down lists, use tree selection more
* Improve tree selection editor
- always call defineEditorAttributes
- use heightHint in editor attributes 
- use tree selection editor as default editor for std::vector

* Use tree selection editor instead of list selection editor
List selection editor must be used when editing std::vector<cvf::vec3d> and similar. Replace other use of list selection editor with tree selection editor.

* Set checked state based on text string for integer only models
For models with only integer values, use text string to define the items to be selected. The full list will always be visible, and the checked state will be updated when editing the filter text.

Example: "1, 5-7" will set items 1, 5, 6, 7 checked and all other items unchecked

* Minor fixes
- Set placeholder text after content is added (to ensure correct data type)
- Fix check of integers. `canConvert<int>()`returns true for both QString and int. Thus convert to string and then check for int conversion.

* Activate filtering when unchecking all items in list with only integers
- Reactivate filtering when uncheck of all items for a list with only integer values (to keep consistency between filter and list)
- Update function name for clarity

---------

Co-authored-by: Jørgen Herje <jorgen.herje@ceetronsolutions.com>
2023-05-22 15:44:37 +02:00
Magne Sjaastad
54f0a832de
Janitor: Remove unused includes 2023-05-15 15:43:01 +02:00
Magne Sjaastad
0c90f67dcc
Change API for PdmObjectHandle and PdmFieldHandle
* Refactor interface to PdmObjectHandle and PdmFieldHandle
Return objects instead of passing in structures as parameters

* Add nodiscard to several functions
* Remove redundant this->
* Rename to ptrReferencedObjectsByType
2023-05-12 21:41:34 +02:00
Magne Sjaastad
6f6dc80bc6
Added more clang-tidy checks
Improved GitHub Action to run clang-format as part of clang-tidy

* Simplify clang-tidy workflow
* Added modernize-use-using, modernize-redundant-void-arg, readability-static-accessed-through-instance
* Add nolint for libecl typedefs
2023-04-14 14:07:45 +02:00
Magne Sjaastad
952e766c2f
Update clang-format.yml (#10068)
* Update to clang-format-15
Removed two custom .clang-format files in subfolders of AppFwk

* Fixes by clang-format
2023-04-13 07:05:53 +02:00
Magne Sjaastad
d2f435c00a
Improved simulation well visualization
* Move members to private in RigWellResultPoint
* Create simulation well path geometry using well topology
* Add separate MSW well pipe centerline computations
* Review comments

---------

Co-authored-by: magnesj <magnesj@users.noreply.github.com>
2023-02-28 16:06:37 +01:00
Magne Sjaastad
f8c5cf389f
clang-format: Set column width to 140
* Set column width to 140
* Use c++20
* Remove redundant virtual
2023-02-26 10:48:40 +01:00
Magne Sjaastad
70bb221162
Janitor issues
* Remove obsolete code
* Fix path modification of a relative folder
Replace start token '.' with file path to the project file to make sure that the path './wells/a-1h.dev' can be imported correctly.
* Add more logging when keywords are missing from import
2023-02-15 07:56:17 +01:00
Kristian Bendiksen
53a80cd86a Fracture: show perforation length field in fracture for azimuth + user-defined perf length. 2023-01-20 13:31:51 +01:00
Kristian Bendiksen
eedda3fa40 Recompute completion type results when input values change. 2023-01-20 13:31:51 +01:00
Magne Sjaastad
c1aceb7134 Avoid random assignment of sub/lateral index to make regression test stable 2022-12-21 15:30:08 +01:00
Kristian Bendiksen
8f33caef74 Fracture: Make conductivity type scriptable from python. 2022-12-20 08:44:42 +01:00
Kristian Bendiksen
e7ec977c13 #9413 Perforation: avoid overwriting diameter set when appending perforation
Fixes #9413.
2022-12-02 14:29:54 +01:00
Kristian Bendiksen
69ccce225c #9470 Fracture Template: make perforation length scriptable.
Also use it in example script.
2022-11-25 07:41:27 +01:00
Kristian Bendiksen
e8789f3d4b
#9470 User defined perf length for azimuth fractures
Fractures: Add UI for user-defined perforation length for az fractures
Add user defined perforation length for azimuth fractures.
Janitor: remove duplication
2022-11-24 10:42:26 +01:00
Magne Sjaastad
6a859e0860
Fix update issues related to fracture calculations
* Make sure property filter is updated when completion type is cleared
* Clear geometry cache in views to make sure geometry is recreated
* Calculate required input parameters to completion type calculations
* Recompute values when depth changes
2022-11-18 12:50:04 +01:00
Kristian Bendiksen
ffc3830110 #9473 Elliptic Fracture: wrong area for scale fractures
Fixes #9473.
2022-11-17 15:36:56 +01:00
Magne Sjaastad
4fea00afbf Fix some signed/unsigned compare issues 2022-11-10 08:37:20 +01:00
Kristian Bendiksen
26dd61a604 Python: Add api and example to get fracture template scale factors. 2022-10-28 15:09:34 +02:00
Kristian Bendiksen
737eb9693a Thermal Fracture: add api for changing time step from python 2022-10-24 12:01:34 +02:00
Kristian Bendiksen
dc80f582bd #9328 StimPlan Fracture: Fix nullptr crash on failed import.
Fixes #9328.
2022-10-05 09:45:27 +02:00
Kristian Bendiksen
d0e9c454d3 #9325 Thermal Fracture: rename injectivity decline to injectivity factor. 2022-10-03 13:19:19 +02:00
Kristian Bendiksen
1a9831db8c Thermal Fracture: Add option to skip filter cake pressure drop adjustment. 2022-10-03 08:33:55 +02:00
Kristian Bendiksen
dbd8dd4ff4 Thermal Fracture: Fix off-by-one in transmissibility calculation. 2022-10-03 08:33:55 +02:00
Kristian Bendiksen
3dad3c65cb Thermal Fracture: Improve handling of result names and units. 2022-10-03 08:33:55 +02:00
Kristian Bendiksen
8ed349f859 Thermal Fracture: add relative and absolute filter-cake pressure drop calculation. 2022-10-03 08:33:55 +02:00
Kristian Bendiksen
da2b183d0e Thermal Fracture: Add option to choose filter cake pressure drop adjustment. 2022-10-03 08:33:55 +02:00
Kristian Bendiksen
7d774d733c Thermal Fracture: compute filter cake mobility. 2022-10-03 08:33:55 +02:00
Kristian Bendiksen
ce65d3738a Thermal Fracture: compute injectivity decline 2022-10-03 08:33:55 +02:00
Kristian Bendiksen
453fe2dcd6 Thermal Fracture: Remove some unnecessary complications with the result names. 2022-10-03 08:33:55 +02:00
Kristian Bendiksen
619807b81f Thermal Fracture: add python script for exporting template as surface. 2022-10-03 08:33:55 +02:00
Kristian Bendiksen
550110d8ab Allow different definitions of valid result for StimPlan and Thermal template. 2022-10-03 08:33:55 +02:00
Magne Sjaastad
3cdc69d1a7 Fix typo for StimPlanFileName keyword 2022-09-12 08:58:09 +02:00
Magne Sjaastad
f3a3e04e1f
Fix missing update of export well name 2022-09-08 16:14:05 +02:00
Kristian Bendiksen
49e298c0b8 Thermal Fracture: rotate and place fracture according to template data. 2022-09-05 15:40:31 +02:00
Kristian Bendiksen
96c4d48c9d #9100 Thermal Fracture: add action to place using template data 2022-09-05 15:40:31 +02:00
Kristian Bendiksen
f82c530966 #9104 Thermal Fracture: Handle offset and scaling. 2022-08-25 09:17:00 +02:00
Magne Sjaastad
506bfbd638
Remove control flag in setCollapsedByDefault
* Remove control flag in setCollapsedByDefault
* Set regions/annotations collapsed by default
2022-08-19 14:18:36 +02:00
Kristian Bendiksen
a87e05035d #9102 Thermal Fracture: handle field units. 2022-08-05 13:45:31 +02:00
Kristian Bendiksen
2a86b55ad2 Thermal Fracture Import: fix crash when import fails. 2022-08-03 14:04:31 +02:00
Kristian Bendiksen
9f0d2c11b6 Thermal Fracture: load and update on project reload. 2022-07-06 18:18:11 +02:00
Kristian Bendiksen
4b8a02cf46 Thermal Fracture: improve import and display of timestamps 2022-07-06 18:18:11 +02:00
Kristian Bendiksen
625b927cb6 Thermal Fracture: Add visualization of results 2022-07-06 18:18:11 +02:00
Kristian Bendiksen
ffb0c5a03f Thermal Fracture: add thermal fracture template 2022-07-06 18:18:11 +02:00
Kristian Bendiksen
a89899b7dc Refactor: Introduce MeshFractureTemplate, and convert StimPlanFractureTemplate to it. 2022-07-06 18:18:11 +02:00
Kristian Bendiksen
b4e3586e2c Janitor: StimPlanFractureTemplate: Remove use of obsolete field.
Might turn on mesh display for some StimPlan fractures in projects older than
v2018.1.0.103. The "show mesh" has been controlled by RimStimPlanColors since 2018.
2022-06-17 19:15:19 +02:00
Kristian Bendiksen
e7ff6f8a7b Janitor: remove empty implementation of updateFilePathsFromProjectPath. 2022-06-17 19:15:19 +02:00