Commit Graph
47 Commits
Author SHA1 Message Date
Magne Sjaastad 88cf84a23a Assign branch number to main branches before completions 2025-11-03 13:40:46 +01:00
Magne Sjaastad 901bed8acd #13013 Ensures increasing MD for fishbone laterals
Positions the ICD segment at the end of the fishbone section to ensure that lateral MDs are larger than the ICD segment MDs.

This is required by the simulator and ensures correct flow modeling from laterals into the ICD segment.
2025-10-14 12:51:03 +02:00
Magne Sjaastad 37041ad0a6 clang-19-tidy and clang-19-format fixes 2025-05-19 14:31:30 +02:00
jonjenssen da683bed9e Move Rig well related things to subfolder and update include statements 2024-10-31 15:08:59 +01:00
jonjenssen 88118ee4e1 Privatize grid cell array 2024-10-29 18:17:31 +01:00
Magne Sjaastad a00bfea40b #11663 Make sure non-Darcy data is computed
The computation of non-Darcy properties is expensive, so we cache the results. Make sure that the calling function calls this function before using the properties.
2024-09-05 08:41:06 +02:00
Magne Sjaastad 59ca0b943c Add readability-simplify-boolean-expr
* Add readability-simplify-boolean-expr
* Fixes based on review
2023-06-26 13:12:41 +02:00
Magne Sjaastad 0c90f67dcc Change API for PdmObjectHandle and PdmFieldHandle
* Refactor interface to PdmObjectHandle and PdmFieldHandle
Return objects instead of passing in structures as parameters

* Add nodiscard to several functions
* Remove redundant this->
* Rename to ptrReferencedObjectsByType
2023-05-12 21:41:34 +02:00
Magne Sjaastad b7f8d0e0f1 Increase warning level
* Set warning level to /W3 for MSVC to catch more warnings
* remove several excluded checks for clang
* removed several unused variables
* Hide warnings qwt
* add missing parentheses in logical expressions
* Remove double check on same logical expression
2023-04-17 15:57:39 +02:00
Magne Sjaastad 952e766c2f Update clang-format.yml (#10068)
* Update to clang-format-15
Removed two custom .clang-format files in subfolders of AppFwk

* Fixes by clang-format
2023-04-13 07:05:53 +02:00
Magne Sjaastad f8c5cf389f clang-format: Set column width to 140
* Set column width to 140
* Use c++20
* Remove redundant virtual
2023-02-26 10:48:40 +01:00
Magne Sjaastad 6ad42817c6 Always use export folder if defined
Rename to m_customFileNameIncludingPath, and split into folder and file name for export object
2023-02-13 15:03:42 +01:00
Magne Sjaastad 296718fd29 Fix location of ICV for MSW wells
* Show warning if no wells are visible
* #9461 MSW: Start export of a lateral at the tie in location on parent well
Previous implementation used the full well path for the lateral, including the part of the parent well up to sea level.
2022-12-14 08:59:24 +01:00
Magne Sjaastad dfa1bc2cd0 Some fixes for new gcc/clang
Minor fixes for newer gcc/clang. These issues were seen when using ubuntu-latest (Ubuntu 22.04) on Github Actions.
2022-11-25 08:59:10 +01:00
Magne Sjaastad 2c0ebfd14c Make face test robust 2022-02-03 16:30:21 +01:00
Magne Sjaastad 94a541f966 #8513 Use cell face when leaving cell when well path starts inside cell 2022-02-03 16:30:21 +01:00
Magne Sjaastad 4366146fbb #8225 MSW export : Adjust position of valve segments 2021-11-02 13:53:42 +01:00
Magne Sjaastad d6b699c38a Janitor : Set optional comment flag for perforations 2021-11-02 13:53:42 +01:00
Magne Sjaastad 299217e219 £8014 : Fix MSW valve export 2021-10-29 14:43:56 +02:00
Magne Sjaastad 0f87c9760d #7862 Export Completion: Add ResInsight project file to file header 2021-09-29 09:42:04 +02:00
Magne Sjaastad 0e0bd751f6 #7973 Export Completions : Further improvements
Fix typo
Make sure compdat export works for custom file name
2021-09-09 15:16:34 +02:00
Magne Sjaastad acdcbe44b4 Merge pull request #7975 from OPM/7973-custom-export-filename
Export Completions : Custom export file name fails in some cases
2021-09-09 10:16:37 +02:00
Magne Sjaastad 8749deb76a #7731 MSW Fishbones : Adjust diameter for fishbone lateral segments in main bore cells 2021-05-28 07:27:53 +02:00
Magne Sjaastad 1f85adecab #7729 MSW : Compute initial measured depth once
Avoid computing value of initial MD multiple times
2021-05-28 07:27:53 +02:00
Magne Sjaastad 805df93aed #7720 Export of MSW : Export data from imported well paths
The tie-in concept was only available for modeled well paths. Make sure both modeled and file well paths produce MSW output
2021-05-25 11:50:18 +02:00
Magne Sjaastad 78e4e1cd5c Janitor : Use enum class 2021-05-18 16:22:05 +02:00
Magne Sjaastad d4f4f20e6e MSW : Do not export completions if well path lateral is unchecked 2021-05-18 16:22:05 +02:00
Magne Sjaastad b518acada6 Janitor : Use enum class 2021-05-18 16:22:05 +02:00
Magne Sjaastad 4b75dd4d6a Fix build issue on Linux 2021-05-14 14:35:54 +02:00
Magne Sjaastad dbc191ed40 #7687 MSW Fishbones : Compute sum of area for multiple ICDs in same cell 2021-05-14 14:19:09 +02:00
Magne Sjaastad fcb0bd391b #7686 MSW Fishbones : Compute effective diameter for multiple laterals in same cell 2021-05-14 14:19:09 +02:00
Magne Sjaastad 9a6073eb7b #7678 Fishbones MSW : Always create an intersection for an ICD segment 2021-05-14 14:19:09 +02:00
Magne Sjaastad 460a387021 #7678 Fishbones MSW : Make sure COMPSEGS is connected to ICD branch
Always connect open hole flow to an ICD, not the WELSEGS representing a well path lateral.
2021-05-14 14:19:09 +02:00
Magne Sjaastad c430e7343a #7678 Fishbones MSW : Include WSEGVALV in MSW-file for LGR section 2021-05-11 14:02:22 +02:00
Magne Sjaastad d002ee1d6e #6878 Export Completion: Allow suffix in custom file name 2021-05-03 14:15:43 +02:00
Magne Sjaastad 3fa4986f37 #6878 Export Completion: Add custom file name 2021-05-03 14:15:43 +02:00
Magne Sjaastad 0936a293ac MSW : Use start of well path, not start of fishbones 2021-04-21 15:06:44 +02:00
Magne Sjaastad dcbfd4cc27 #7597 MSW : Connect fractures a segment with lower measured depth 2021-04-21 07:41:56 +02:00
Magne Sjaastad 4f89e38334 #7595 MSW : Move MSW parameters to well path
Move msw parameters to well path
Make it clear when options are taken from top level well path or well path lateral
Use well path lateral custom values for diameter and roughness
2021-04-20 21:13:02 +02:00
Magne Sjaastad b2d475dde2 #7589 MSW : Always connect to segment with lower measured depth 2021-04-19 14:34:04 +02:00
Magne Sjaastad 63690d5196 Major rewrite of MSW export model 2021-04-13 07:54:34 +02:00
Magne Sjaastad 2e643edc35 MSW : Restore MSW settings per completion type
Remove the common MSW settings on well path
2021-03-11 10:50:25 +01:00
Magne Sjaastad 51b72ce7be WELSEGS Export : Avoid duplicate perforation segments in WELSEGS table 2021-03-11 10:50:25 +01:00
Magne Sjaastad 9bac309a4f Completion Export : Add option to control export of comments 2021-03-02 09:25:53 +01:00
Magne Sjaastad 8bab748fa6 Improve MSW export including multi lateral wells
Based on branch https://github.com/OPM/ResInsight/tree/system-msw-refactor

- Move completion settings to property of well path
- Rename to RimFishbones
- Export implicit COMPSEGS for fishbones main bore
- Add valve for each branch
- Increase version number to be able to handle import of legacy project files
2021-02-26 14:59:57 +01:00
bc81437435 Moved UnitSystem from RiaEclipseUnitTools to RiaDefines. (#7225)
* Moved UnitSystem from RiaEclipseUnitTools to RiaDefines.
- Renamed UnitSystem to EclipseUnitSystem
- Replaced header includes and removed obsolete includes of RiaEclipseUnitTools.h
* Moved  result name functions into separate file.
* Minor cleanup

Co-authored-by: rubenthoms <rubenthoms@users.noreply.github.com>
Co-authored-by: Magne Sjaastad <magne.sjaastad@ceetronsolutions.com>
Co-authored-by: magnesj <magnesj@users.noreply.github.com>
2021-01-21 12:58:46 +01:00
Gaute Lindkvist 81699db187 Rename ApplicationCode to ApplicationLibCode 2021-01-11 15:27:45 +01:00