The Python generator declares the add_folder() return type from
subCollectionClassKeyword(), while the folder is created by
createSubCollection(). Nothing tied the two together, so overriding only
one of them would give wrong type hints without any failing test.
ResInsight-tests: the folder added to a polygon collection, a surface
collection and an ensemble surface has the class named by
subCollectionClassKeyword(), and a polygon file declares and creates no
folder.
collection_name() returned the stored m_collectionName, which is empty
for a RimPolygonFile or RimPolygonCloudAddress without a name. Both
classes fall back to the file name or a default ("Polygon File", "Sumo
Polygon Address") in name().
PdmNestedCollectionBase::displayName() is a virtual that defaults to
collectionName(); RimPolygonFile and RimPolygonCloudAddress override it
with name(), and CollectionNameInternal returns displayName().
collectionName() itself is unchanged, since findSubCollectionByName()
and the name conflict policy compare stored names.
ResInsight-tests: RimcNestedCollectionBase-Test covers a polygon
collection, a polygon file (default, base name, file name fallback) and
a cloud polygon address.