Commit Graph
3067 Commits
Author SHA1 Message Date
Magne Sjaastad cfc620b501 Avoids potential null pointer dereference
Adds a null check for the eclResDef pointer before accessing its members.
This prevents a potential crash if eclResDef is null.
Additionally, the unnecessary assertions are removed.
2025-10-23 16:14:12 +02:00
Magne Sjaastad 6bc25c387d #13065 Improves result info handling
Improves result info handling by ensuring the result
definition is valid before accessing it, preventing
potential crashes.
Uses `if (auto)` to check for null result definitions,
and displays a user-friendly message when no result
definition is available.
2025-10-23 16:14:12 +02:00
Magne Sjaastad ea06cdc291 Avoid small allocation on every read of data from resdata 2025-10-23 16:14:12 +02:00
Magne Sjaastad f6cd02a6c1 #13064 Crash when computing delta ensemble curves for ongoing simulation
When creating delta for an ongoing simulation, the length of time and value vectors can differ. Resize these vectors to make sure they have the same length to avoid crash.
2025-10-23 16:14:12 +02:00
Kristian Bendiksen fe46ced410 Refactor: use Vec3st in sector export ui, and split long method. 2025-10-22 16:20:50 +02:00
Kristian Bendiksen b329318e05 Replace more keywords. 2025-10-22 16:20:50 +02:00
Kristian Bendiksen ebb8d62eb6 Replace values in deck file values. 2025-10-22 16:20:50 +02:00
Kristian Bendiksen 8f5432c28e Export sector UI: add UI for bccon/bcprop. 2025-10-22 16:20:50 +02:00
Kristian Bendiksen 2392a6dfa1 Refactor: extract method for getting sector data. 2025-10-22 16:20:50 +02:00
JJ 54a890e13f Use modern, fieldless buttons (#13056)
* Use modern buttons
2025-10-21 18:36:24 +02:00
Kristian Bendiksen ac2923b8b9 #13034 Auto-import PVD surfaces for grid.
Fixes #13034.
2025-10-20 15:24:02 +02:00
Kristian Bendiksen 1a6922e346 #13033 Replace Case: add missing grid/egrid filter.
Fixes #13033.
2025-10-20 13:37:08 +02:00
magnesj 3fa94f3b17 Fixes by clang-tidy 2025-10-18 14:17:01 +02:00
JJ 1eaf50b6b9 Support running jobs without blocking GUI (#13040)
* Add view job log command.
* Add stop job command.
* Do not block ui while job is running.
* Show progress while job is running
* Make sure user gets notified of running jobs when exiting ResInsight or closing current project.
2025-10-18 02:42:11 +02:00
Kristian Bendiksen c38819bac7 CSV Parser: include line number in error message. 2025-10-17 07:52:42 +02:00
Kristian Bendiksen 2b974abfd1 Refactor CSV Parser: Modernize casts. 2025-10-17 07:52:42 +02:00
Kristian Bendiksen 4a4941f759 CSV Parser: use cell separator when determining layout type. 2025-10-17 07:52:42 +02:00
Kristian Bendiksen dddb206dc4 Refactor CSV parser: Modernize enum. 2025-10-17 07:52:42 +02:00
Kristian Bendiksen 7ab1c62b30 Refactor CSV parser: Improve error handling in openDataStream. 2025-10-17 07:52:42 +02:00
Kristian Bendiksen c6da9ad8a8 Refactor CSV parser: Extract method for parsing date time. 2025-10-17 07:52:42 +02:00
Kristian Bendiksen c17736a232 Refactor CSV parser: Refactor to use lambda. 2025-10-17 07:52:42 +02:00
Kristian Bendiksen b29db6e62d Refactor CSV parser: Remove pointers in api. 2025-10-17 07:52:42 +02:00
Kristian Bendiksen 75ca1b5216 Refactor CSV parser: Modernize memory management. 2025-10-17 07:52:42 +02:00
Kristian Bendiksen d137281066 Refactor CSV parser: modernize parser to use std::expected. 2025-10-17 07:52:42 +02:00
Magne Sjaastad db586cd99a Use hyperlink to edit common readout settings
Show Apply Filter button on same row
2025-10-17 07:43:51 +02:00
Magne Sjaastad 00a58a1fd9 Introduces common readout settings for summary multi plots
Introduces common readout settings for summary multi plots, allowing users to apply a single readout configuration across multiple plots instead of configuring each individually.
2025-10-16 14:09:15 +02:00
Magne Sjaastad a75c10252d Build cell aabb search tree when required
This is a follow-up to the fix where the assert was removed in 9a71abd8af.

This fix will make sure that the search tree always is created when findIntersectingCells() is called.
2025-10-16 14:08:38 +02:00
Magne Sjaastad 0b7a4b12f1 #13019 Remove assert from RiaSummaryTools::summaryCaseMainCollection() 2025-10-14 14:47:58 +02:00
Jon Jenssen 9a71abd8af Crash fix, do not assert, return empty list 2025-10-14 13:43:25 +02:00
Magne Sjaastad 5f2e2919c8 Avoids iterator invalidation in QwtPlot item lists
When working with a summary ensemble in a Debug build on Windows, a crash happened in RiuQwtPlotWidget::resetPlotCurveHighlighting(). When iterating over list of plot items, one pointer to item pointed to 0xddddddd, a clear indication that the underlying list had been updated during the loop and the iterator invalidated.

The change ensures that modifications to the item list during iteration do not cause unexpected behavior, particularly in scenarios involving grid lines and curve highlighting.

This is achieved by making a copy of the item list before iteration when modifications may occur. For cases where no add/remove will be performed during the iteration, a comment is added to clarify that it is safe to access the reference to the list.
2025-10-14 12:52:24 +02:00
Magne Sjaastad 901bed8acd #13013 Ensures increasing MD for fishbone laterals
Positions the ICD segment at the end of the fishbone section to ensure that lateral MDs are larger than the ICD segment MDs.

This is required by the simulator and ensures correct flow modeling from laterals into the ICD segment.
2025-10-14 12:51:03 +02:00
jonjenssen d6318f6d01 Add support for duplicating jobs. Give run cmd an icon 2025-10-14 08:42:42 +02:00
Kristian Bendiksen a81229bad8 Introduce type-safe cell index for active reservoir cell index. 2025-10-13 16:17:03 +02:00
Kristian Bendiksen fd56ae3e4d Generate OPERNUM for entire result vector. 2025-10-13 14:14:44 +02:00
Kristian Bendiksen 5373484615 #12950 Sector Model: Add BCPROP keyword. 2025-10-13 14:14:44 +02:00
Kristian Bendiksen dd689aec50 #12950 Sector Model: Add BCCON keyword. 2025-10-13 14:14:44 +02:00
Kristian Bendiksen 8e6a96da00 #12950 Add api for export cell visibility for a given view. 2025-10-13 14:14:44 +02:00
Magne Sjaastad cf5da1ff7a #13000 Fishbones completion: Avoid overwrite of default values
Always call setSystemParameters after appendFishbonesSubs
2025-10-13 13:10:33 +02:00
Magne Sjaastad 45d1a4a9f8 #12986 Fishbones completion: Add unit text for Lateral Diameter 2025-10-13 13:10:33 +02:00
Magne Sjaastad bba6af58e5 #13001 3D-view: Scale factor is not shown correctly 2025-10-13 13:10:33 +02:00
jonjenssen 6fc8e826cf Add missing time record to dates keyword 2025-10-10 12:10:53 +02:00
Magne Sjaastad 77c3548f24 Fixes active index usage for radial LGR grids
Ensures that active cell indexing is always used for temporary local grid refinements (LGRs) of radial multi-grids.

The  TestCase_Completions_Export loads a grid with several LGRs. This test case failed due to the changes for radial grids.
2025-10-09 15:08:41 +02:00
Magne Sjaastad 15a1b1b46c Skip non-existing files before trying to import summary data 2025-10-09 15:08:25 +02:00
Magne Sjaastad 65e61767f4 Fix typo and restore filter for tree view after update 2025-10-09 11:14:45 +02:00
Magne Sjaastad 6de145ef50 #12996 Resdata: Prefer UNRST over FUNRST 2025-10-08 16:03:56 +02:00
Magne Sjaastad 62188fa9f2 Improve naming of cell related result names
Use radial/theta when required for GUI
Hide DX/DY from the list of available results
2025-10-08 16:03:56 +02:00
Magne Sjaastad b771421087 #12994 Radial model: Freeze when selecting cell result INDEX_IJK
When a LGR is created to be able to show the radial grid, the active index usage when computing INDEX_IJK was wrong.

wip
2025-10-08 16:03:56 +02:00
magnesj 5d26f53472 Fixes by clang-tidy 2025-10-08 07:48:37 +02:00
Jon Jenssen a878ae3563 Fix combobox edits being reset. 2025-10-07 19:11:51 +02:00
JJ 11942e377f Opm Flow: Support for adding more dates to data file (#12991)
* Add support for appending dates keyword at end of file
* Make sure well group from job is used
* Increase well groups in welldims in case a new group is made
* GUI cleanup
2025-10-07 18:21:15 +02:00