mirror of
https://github.com/OPM/ResInsight.git
synced 2026-10-25 06:38:13 -05:00
Magne Sjaastad
c27f25ae8a
RigFlowDiagResults::activeCellInfo() dereferences the ancestor RimEclipseResultCase and its eclipseCaseData() unchecked. The derived results (TOF, Cell Fraction, Communication, Max Fraction Tracer) crash when the solution is detached or the case data is released. activeCellInfo() now returns nullptr when the case or its data is missing, and the derived-result calculations return nullptr in that case. New test RigFlowDiagResults.DerivedResultWithoutEclipseCase. Call stack: [4] RigFlowDiagResults::calculateDerivedResult(RigFlowDiagResultAddress const&, unsigned long) at ResInsight/ApplicationLibCode/ReservoirDataModel/RigFlowDiagResults.cpp:211 [5] RigFlowDiagResults::findOrCalculateResult(RigFlowDiagResultAddress const&, unsigned long) at ResInsight/ApplicationLibCode/ReservoirDataModel/RigFlowDiagResults.cpp:95 [6] RigFlowDiagStatCalc::minMaxCellScalarValues(unsigned long, double&, double&) at ResInsight/ApplicationLibCode/ReservoirDataModel/RigFlowDiagStatCalc.cpp:49 [7] RigStatisticsDataCache::minMaxCellScalarValues(unsigned long, double&, double&) at ResInsight/ApplicationLibCode/ResultStatisticsCache/RigStatisticsDataCache.cpp:121 [8] RimEclipseResultDefinitionTools::updateLegendForFlowDiagnostics(...) at ResInsight/ApplicationLibCode/ProjectDataModel/RimEclipseResultDefinitionTools.cpp:422 [9] RimEclipseResultDefinition::updateRangesForExplicitLegends(...) at ResInsight/ApplicationLibCode/ProjectDataModel/RimEclipseResultDefinition.cpp:1705 [10] RimEclipseView::updateLegendRangesTextAndVisibility(...) at ResInsight/ApplicationLibCode/ProjectDataModel/RimEclipseView.cpp:1699 [11] RimEclipseView::onUpdateLegends() at ResInsight/ApplicationLibCode/ProjectDataModel/RimEclipseView.cpp:1568 [12] RimEclipseView::onCreateDisplayModel() at ResInsight/ApplicationLibCode/ProjectDataModel/RimEclipseView.cpp:854
50 lines
2.1 KiB
C++
50 lines
2.1 KiB
C++
/////////////////////////////////////////////////////////////////////////////////
|
|
//
|
|
// Copyright (C) 2026- Equinor ASA
|
|
//
|
|
// ResInsight is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// ResInsight is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
// WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
// FITNESS FOR A PARTICULAR PURPOSE.
|
|
//
|
|
// See the GNU General Public License at <http://www.gnu.org/licenses/gpl.html>
|
|
// for more details.
|
|
//
|
|
/////////////////////////////////////////////////////////////////////////////////
|
|
|
|
#include "gtest/gtest.h"
|
|
|
|
#include "RigFlowDiagDefines.h"
|
|
#include "RigFlowDiagResultAddress.h"
|
|
#include "RigFlowDiagResultFrames.h"
|
|
#include "RigFlowDiagResults.h"
|
|
#include "RigStatisticsDataCache.h"
|
|
|
|
#include "RimFlowDiagSolution.h"
|
|
|
|
#include <memory>
|
|
|
|
//--------------------------------------------------------------------------------------------------
|
|
/// Derived results must not dereference a missing eclipse case when the solution is detached
|
|
//--------------------------------------------------------------------------------------------------
|
|
TEST( RigFlowDiagResults, DerivedResultWithoutEclipseCase )
|
|
{
|
|
auto flowDiagSolution = std::make_unique<RimFlowDiagSolution>();
|
|
RigFlowDiagResults results( flowDiagSolution.get(), 1 );
|
|
|
|
const std::vector<QString> derivedResultNames = { RigFlowDiagDefines::tofResultName(),
|
|
RigFlowDiagDefines::cellFractionResultName(),
|
|
RigFlowDiagDefines::communicationResultName(),
|
|
RigFlowDiagDefines::maxFractionTracerResultName() };
|
|
|
|
for ( const auto& name : derivedResultNames )
|
|
{
|
|
RigFlowDiagResultAddress address( name.toStdString(), RigFlowDiagResultAddress::PHASE_ALL, std::set<std::string>() );
|
|
EXPECT_EQ( nullptr, results.resultValues( address, 0 ) );
|
|
}
|
|
}
|