mirror of
https://github.com/OPM/ResInsight.git
synced 2026-10-25 06:38:13 -05:00
Magne Sjaastad
8ac2255832
Closing all summary cases while a delta ensemble is present crashed with a use-after-free. RicCloseSummaryCaseFeature::deleteSummaryCases holds a case list across removeCases and deletes it afterwards, while removeCases made the delta ensemble rebuild and destroy derived cases that are themselves part of that list. The previous fix rewrote the caller list with the surviving cases, which stopped the crash but left the hazard in place for any other caller holding a case list across a removal. Add RimSummaryCaseUpdateBatch, a plain scope object that is ambient for the duration of its scope. Removal now only detaches, and hands the detached cases to the batch. The outermost scope flushes, regenerating the dirty delta ensembles in dependency order first so a chained delta ensemble sees the final state of its source, then destroying the orphans with caf::PdmObjectHandleTools::deleteObjects. A nested batch contributes to the outermost one and never flushes. Orphans are held as guarded pointers, so a case the caller destroyed itself is skipped instead of being destroyed twice. Both contribution points fall back to immediate execution when no batch is active, so call sites that do not open one keep behaving as before. Open a batch in RimSummaryCaseMainCollection::removeCases and in RicCloseSummaryCaseFeature::deleteSummaryCases, which is the outermost of the two and therefore keeps the detached cases alive across its own deleteObjects call. removeCases no longer rewrites the caller list, so it now takes it by const reference.
133 lines
4.7 KiB
C++
133 lines
4.7 KiB
C++
/////////////////////////////////////////////////////////////////////////////////
|
|
//
|
|
// Copyright (C) 2017- Statoil ASA
|
|
//
|
|
// ResInsight is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// ResInsight is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
// WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
// FITNESS FOR A PARTICULAR PURPOSE.
|
|
//
|
|
// See the GNU General Public License at <http://www.gnu.org/licenses/gpl.html>
|
|
// for more details.
|
|
//
|
|
/////////////////////////////////////////////////////////////////////////////////
|
|
|
|
#include "RicCloseSummaryCaseFeature.h"
|
|
|
|
#include "RiaGuiApplication.h"
|
|
#include "Summary/RiaSummaryTools.h"
|
|
|
|
#include "RicDeleteItemFeature.h"
|
|
|
|
#include "RimDepthTrackPlot.h"
|
|
#include "RimMainPlotCollection.h"
|
|
#include "RimProject.h"
|
|
#include "RimSummaryCase.h"
|
|
#include "RimSummaryCaseMainCollection.h"
|
|
#include "RimSummaryCaseUpdateBatch.h"
|
|
#include "RimSummaryMultiPlot.h"
|
|
#include "RimSummaryMultiPlotCollection.h"
|
|
#include "RimSummaryPlot.h"
|
|
#include "RimWellLogPlot.h"
|
|
#include "RimWellPlotTools.h"
|
|
#include "RimWellRftPlot.h"
|
|
|
|
#include "RiuPlotMainWindow.h"
|
|
|
|
#include "cafPdmObjectHandleTools.h"
|
|
#include "cafSelectionManager.h"
|
|
|
|
#include <QAction>
|
|
|
|
#include <set>
|
|
|
|
CAF_CMD_SOURCE_INIT( RicCloseSummaryCaseFeature, "RicCloseSummaryCaseFeature" );
|
|
|
|
//--------------------------------------------------------------------------------------------------
|
|
///
|
|
//--------------------------------------------------------------------------------------------------
|
|
void RicCloseSummaryCaseFeature::setupActionLook( QAction* actionToSetup )
|
|
{
|
|
actionToSetup->setText( "Close Summary Case" );
|
|
actionToSetup->setIcon( QIcon( ":/Erase.png" ) );
|
|
applyShortcutWithHintToAction( actionToSetup, QKeySequence::Delete );
|
|
}
|
|
|
|
//--------------------------------------------------------------------------------------------------
|
|
///
|
|
//--------------------------------------------------------------------------------------------------
|
|
void RicCloseSummaryCaseFeature::deleteSummaryCases( std::vector<RimSummaryCase*> cases )
|
|
{
|
|
// The case list is used all the way down to the delete below. Keep a batch open for that whole span, so a derived
|
|
// case detached by the removal is not destroyed while this list still refers to it.
|
|
RimSummaryCaseUpdateBatch updateBatch;
|
|
|
|
RimSummaryMultiPlotCollection* summaryPlotColl = RiaSummaryTools::summaryMultiPlotCollection();
|
|
RimSummaryCaseMainCollection* summaryCaseMainCollection = RiaSummaryTools::summaryCaseMainCollection();
|
|
|
|
std::set<RimSummaryMultiPlot*> plotsToUpdate;
|
|
|
|
auto depthTrackPlots = caf::PdmObjectHandleTools::referringAncestorOfType<RimDepthTrackPlot, RimSummaryCase>( cases );
|
|
|
|
const std::set<RimSummaryCase*> casesToDelete( cases.begin(), cases.end() );
|
|
|
|
for ( RimSummaryMultiPlot* multiPlot : summaryPlotColl->multiPlots() )
|
|
{
|
|
for ( RimSummaryPlot* summaryPlot : multiPlot->summaryPlots() )
|
|
{
|
|
summaryPlot->deleteCurvesAssosiatedWithCases( casesToDelete );
|
|
}
|
|
plotsToUpdate.insert( multiPlot );
|
|
}
|
|
|
|
summaryCaseMainCollection->removeCases( cases );
|
|
|
|
RimWellPlotTools::loadDataAndUpdateDepthTrackPlots( depthTrackPlots );
|
|
|
|
for ( auto plot : plotsToUpdate )
|
|
{
|
|
plot->updateConnectedEditors();
|
|
plot->updatePlots();
|
|
}
|
|
|
|
summaryCaseMainCollection->updateAllRequiredEditors();
|
|
|
|
RiuPlotMainWindow* mainPlotWindow = RiaGuiApplication::instance()->mainPlotWindow();
|
|
mainPlotWindow->updateMultiPlotToolBar();
|
|
|
|
caf::PdmObjectHandleTools::deleteObjects( cases );
|
|
}
|
|
|
|
//--------------------------------------------------------------------------------------------------
|
|
///
|
|
//--------------------------------------------------------------------------------------------------
|
|
bool RicCloseSummaryCaseFeature::isCommandEnabled() const
|
|
{
|
|
const auto selection = caf::SelectionManager::instance()->objectsByType<RimSummaryCase>();
|
|
if ( selection.empty() )
|
|
{
|
|
return false;
|
|
}
|
|
|
|
for ( RimSummaryCase* summaryCase : selection )
|
|
{
|
|
if ( summaryCase->isObservedData() )
|
|
{
|
|
return false;
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|
|
//--------------------------------------------------------------------------------------------------
|
|
///
|
|
//--------------------------------------------------------------------------------------------------
|
|
void RicCloseSummaryCaseFeature::onActionTriggered( bool isChecked )
|
|
{
|
|
RicCloseSummaryCaseFeature::deleteSummaryCases( caf::SelectionManager::instance()->objectsByType<RimSummaryCase>() );
|
|
}
|