ResInsight

0 Fork 0

mirror of https://github.com/OPM/ResInsight.git synced 2026-10-25 14:40:26 -05:00

Files

T

Kristian Bendiksen aec17d54a7 Fix CmdFeatureMenuBuilder::MenuItem memory leak in RiuContextMenuLauncher

Address sanitizer detected a memory leak in CmdFeatureMenuBuilder::MenuItem
objects allocated during context menu creation.

Problem: The RiuContextMenuLauncher constructor was creating a temporary
CmdFeatureMenuBuilder object, populating it with menu items, then copying
the entire object to the member variable m_menuBuilder. This caused
unnecessary memory allocation and copying of std::vector<MenuItem> data.

Root cause: Inefficient constructor implementation:
  caf::CmdFeatureMenuBuilder menuBuilder;  // temp object
  for (cmd : commandIds) menuBuilder << cmd;  // populate temp
  m_menuBuilder = menuBuilder;  // copy entire vector (leak source)

Fix: Build the menu directly into the member variable instead of creating
a temporary object and copying it:
  for (cmd : commandIds) m_menuBuilder << cmd;  // direct construction

This eliminates the unnecessary temporary object creation and copy operation
that was causing the MenuItem vector allocation detected by the sanitizer.
The fix maintains identical functionality while being more efficient.

2025-09-04 09:04:30 +02:00

Adm

Prepare 2025.09.0-RC_1

2025-08-28 20:14:53 +02:00

Application

#12873 Make sure addresses are created on single summary case reload

2025-09-02 15:48:12 +02:00

CommandFileInterface

clang-19-tidy and clang-19-format fixes

2025-05-19 14:31:30 +02:00

Commands

Refactor: Change RigGridBase::cellCornerVertices to return std::array