mirror of
https://github.com/OPM/ResInsight.git
synced 2026-10-26 15:10:22 -05:00
Magne Sjaastad
318659e130
* Recompute well cell arrays when the grids change computeWellCellsPrGrid() returned early whenever the arrays had been computed once, so the size check below it was unreachable and a stale array was kept when the grids changed. The too-short array triggered an assert in RivReservoirViewPartMgr::computeNativeVisibility. Return early only when the cached arrays still match the current set of grids. * Guard against missing GUI application when applying style sheet RiaGuiApplication::instance() does a dynamic_cast and returns null outside a GUI context. The assert guarding this is compiled out in release, so the null pointer was dereferenced. * Guard against missing case in flow characteristics plot field change The case field can be set to nothing from the UI. RimEclipseResultCase::defaultFlowDiagSolution() and reservoirViews() were then called on a null pointer. * Guard against missing case and out of range time steps when updating flow characteristics plot onLoadDataAndUpdate() dereferenced the case without checking, although the same function handles a missing case further down. The time step indices come from the flow diagnostics solution, and were used to index arrays sized by the number of case time steps without a range check.
153 lines
5.7 KiB
C++
153 lines
5.7 KiB
C++
|
|
|
|
/////////////////////////////////////////////////////////////////////////////////
|
|
//
|
|
// Copyright (C) 2011-2012 Statoil ASA, Ceetron AS
|
|
//
|
|
// ResInsight is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// ResInsight is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
// WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
// FITNESS FOR A PARTICULAR PURPOSE.
|
|
//
|
|
// See the GNU General Public License at <http://www.gnu.org/licenses/gpl.html>
|
|
// for more details.
|
|
//
|
|
/////////////////////////////////////////////////////////////////////////////////
|
|
|
|
#include "gtest/gtest.h"
|
|
|
|
#include "RigEclipseCaseData.h"
|
|
#include "RigGridManager.h"
|
|
#include "RigMainGrid.h"
|
|
|
|
//--------------------------------------------------------------------------------------------------
|
|
///
|
|
//--------------------------------------------------------------------------------------------------
|
|
TEST( RigGridManager, BasicTest )
|
|
{
|
|
cvf::ref<RigMainGrid> mainGridA = new RigMainGrid;
|
|
|
|
cvf::ref<RigEclipseCaseData> eclipseCase = new RigEclipseCaseData( nullptr );
|
|
eclipseCase->setMainGrid( mainGridA.p() );
|
|
|
|
EXPECT_EQ( mainGridA->refCount(), 2 );
|
|
|
|
RigGridManager gridCollection;
|
|
gridCollection.addCase( eclipseCase.p() );
|
|
EXPECT_EQ( mainGridA->refCount(), 2 );
|
|
|
|
cvf::ref<RigMainGrid> mainGridB = mainGridA;
|
|
EXPECT_EQ( mainGridA->refCount(), 3 );
|
|
|
|
cvf::ref<RigMainGrid> existingGrid = gridCollection.findEqualGrid( mainGridB.p() );
|
|
EXPECT_TRUE( existingGrid.notNull() );
|
|
}
|
|
|
|
//--------------------------------------------------------------------------------------------------
|
|
///
|
|
//--------------------------------------------------------------------------------------------------
|
|
TEST( RigGridManager, EqualTests )
|
|
{
|
|
cvf::ref<RigMainGrid> mainGridA = new RigMainGrid;
|
|
mainGridA->nodes().push_back( cvf::Vec3d( 0, 0, 0 ) );
|
|
mainGridA->nodes().push_back( cvf::Vec3d( 0, 0, 1 ) );
|
|
mainGridA->nodes().push_back( cvf::Vec3d( 0, 0, 2 ) );
|
|
|
|
cvf::ref<RigEclipseCaseData> eclipseCase = new RigEclipseCaseData( nullptr );
|
|
eclipseCase->setMainGrid( mainGridA.p() );
|
|
|
|
RigGridManager gridCollection;
|
|
gridCollection.addCase( eclipseCase.p() );
|
|
|
|
cvf::ref<RigMainGrid> mainGridB = new RigMainGrid;
|
|
cvf::ref<RigMainGrid> existingGrid = gridCollection.findEqualGrid( mainGridB.p() );
|
|
EXPECT_TRUE( existingGrid.isNull() );
|
|
|
|
mainGridB->nodes().push_back( cvf::Vec3d( 0, 0, 0 ) );
|
|
existingGrid = gridCollection.findEqualGrid( mainGridB.p() );
|
|
EXPECT_TRUE( existingGrid.isNull() );
|
|
|
|
// Insert nodes in opposite direction
|
|
mainGridB->nodes().push_back( cvf::Vec3d( 0, 0, 2 ) );
|
|
mainGridB->nodes().push_back( cvf::Vec3d( 0, 0, 1 ) );
|
|
existingGrid = gridCollection.findEqualGrid( mainGridB.p() );
|
|
EXPECT_TRUE( existingGrid.isNull() );
|
|
|
|
// Overwrite to match the node structure of mainGridA
|
|
mainGridB->nodes()[1] = cvf::Vec3d( 0, 0, 1 );
|
|
mainGridB->nodes()[2] = cvf::Vec3d( 0, 0, 2 );
|
|
existingGrid = gridCollection.findEqualGrid( mainGridB.p() );
|
|
EXPECT_TRUE( existingGrid.notNull() );
|
|
}
|
|
|
|
//--------------------------------------------------------------------------------------------------
|
|
/// The well cell arrays are cached, and must be recomputed if the grid changes size after the first
|
|
/// computation. A stale array is shorter than the cell count of the grid it is used with.
|
|
//--------------------------------------------------------------------------------------------------
|
|
TEST( RigEclipseCaseDataTest, WellCellsInGridIsRecomputedWhenGridSizeChanges )
|
|
{
|
|
cvf::ref<RigMainGrid> mainGrid = new RigMainGrid;
|
|
mainGrid->setCellCounts( cvf::Vec3st( 2, 2, 2 ) );
|
|
|
|
cvf::ref<RigEclipseCaseData> eclipseCase = new RigEclipseCaseData( nullptr );
|
|
eclipseCase->setMainGrid( mainGrid.p() );
|
|
|
|
const cvf::UByteArray* wellCells = eclipseCase->wellCellsInGrid( 0 );
|
|
ASSERT_TRUE( wellCells != nullptr );
|
|
EXPECT_EQ( mainGrid->cellCount(), wellCells->size() );
|
|
|
|
// Grow the grid after the well cell arrays have been cached
|
|
mainGrid->setCellCounts( cvf::Vec3st( 3, 3, 3 ) );
|
|
|
|
wellCells = eclipseCase->wellCellsInGrid( 0 );
|
|
ASSERT_TRUE( wellCells != nullptr );
|
|
EXPECT_EQ( mainGrid->cellCount(), wellCells->size() );
|
|
}
|
|
|
|
/*
|
|
|
|
//--------------------------------------------------------------------------------------------------
|
|
///
|
|
//--------------------------------------------------------------------------------------------------
|
|
TEST(RigReservoirTest, BasicTest)
|
|
{
|
|
cvf::ref<RigSingleWellResultsData> wellCellTimeHistory = new RigSingleWellResultsData;
|
|
|
|
QDateTime wellStartTime = QDateTime::currentDateTime();
|
|
|
|
int wellTimeStepCount = 5;
|
|
wellCellTimeHistory->m_wellCellsTimeSteps.resize(wellTimeStepCount);
|
|
|
|
int i;
|
|
for (i = 0; i < wellTimeStepCount; i++)
|
|
{
|
|
wellCellTimeHistory->m_wellCellsTimeSteps[i].m_timestamp = QDateTime(wellStartTime).addYears(i);
|
|
}
|
|
|
|
int resultTimeStepCount = 2 * wellTimeStepCount;
|
|
std::vector<QDateTime> resultTimes;
|
|
for (i = 0; i < resultTimeStepCount; i++)
|
|
{
|
|
resultTimes.push_back(QDateTime(wellStartTime).addMonths(i * 6));
|
|
}
|
|
|
|
wellCellTimeHistory->computeMappingFromResultTimeIndicesToWellTimeIndices(resultTimes);
|
|
|
|
for (i = 0; i < resultTimeStepCount; i++)
|
|
{
|
|
qDebug() << "Index" << i << "is " << wellCellTimeHistory->m_resultTimeStepIndexToWellTimeStepIndex[i];
|
|
|
|
const RigWellResultFrame& wellCells =
|
|
wellCellTimeHistory->wellResultFrame(wellCellTimeHistory->m_resultTimeStepIndexToWellTimeStepIndex[i]); qDebug() <<
|
|
wellCells.m_timestamp;
|
|
}
|
|
|
|
}
|
|
|
|
|
|
*/
|