mirror of
https://github.com/OPM/ResInsight.git
synced 2026-10-25 06:38:13 -05:00
Magne Sjaastad
b5b34fcf9b
synchronize2dIntersectionViews() could crash in two ways: when the view's ownerCase() is null, and when the collection has no Rim3dView ancestor at all (e.g. mid-destruction after detaching from the PDM tree, where firstAncestorOrThisOfTypeAsserted<Rim3dView>() returns null since CAF_ASSERT is compiled out in release). Both cases are now guarded.
36 lines
1.6 KiB
C++
36 lines
1.6 KiB
C++
#include "gtest/gtest.h"
|
|
|
|
#include "RimEclipseView.h"
|
|
#include "RimIntersectionCollection.h"
|
|
|
|
#include <memory>
|
|
|
|
//--------------------------------------------------------------------------------------------------
|
|
/// Synchronizing 2D intersection views for a view whose case is not yet assigned (ownerCase() returns
|
|
/// null, e.g. RimEclipseView::eclipseCase() before a case has been set) must not crash. See crash in
|
|
/// RimCase::intersectionViewCollection() being called on a null case.
|
|
//--------------------------------------------------------------------------------------------------
|
|
TEST( RimIntersectionCollectionTest, SynchronizeWithoutOwnerCaseDoesNotCrash )
|
|
{
|
|
auto* view = new RimEclipseView();
|
|
|
|
RimIntersectionCollection* intersectionCollection = view->intersectionCollection();
|
|
ASSERT_NE( nullptr, intersectionCollection );
|
|
ASSERT_EQ( nullptr, view->ownerCase() );
|
|
|
|
EXPECT_NO_FATAL_FAILURE( intersectionCollection->synchronize2dIntersectionViews() );
|
|
|
|
delete view;
|
|
}
|
|
|
|
//--------------------------------------------------------------------------------------------------
|
|
/// Synchronizing 2D intersection views for a collection detached from any Rim3dView ancestor (e.g.
|
|
/// mid-destruction, once the owning view has been removed from the PDM tree) must not crash.
|
|
//--------------------------------------------------------------------------------------------------
|
|
TEST( RimIntersectionCollectionTest, SynchronizeWithoutOwnerViewDoesNotCrash )
|
|
{
|
|
auto intersectionCollection = std::make_unique<RimIntersectionCollection>();
|
|
|
|
EXPECT_NO_FATAL_FAILURE( intersectionCollection->synchronize2dIntersectionViews() );
|
|
}
|