OilfieldToolsNet/opm-common
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[fix] AggregateActionX: Do not assume an ACTIONX condition exists

Browse Source 
The rest of the code allows an ACTIONX keyword without any
condition (Such an action will never be evaluated). Yet
AggregateActionXData assumed that there is always at least one
condition. This lead to a segmentation fault if that was not the case.

It seemed like iAC[offset + Ix::FirstGreater] is used nowhere and
therefore we now always use 0 there. I was not brave enouogh to remove
the storage for it, because I fear this might break backwards
compatibility of the output layer.
This commit is contained in:
Markus Blatt 2023-10-15 20:41:20 +02:00
parent 25340d8ec7
commit 157e1b0f86
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/opm/output/eclipse/AggregateActionxData.cpp
View File

@ -324,10 +324,10 @@ const std::map<logic_enum, int> logicalToIndex_17 = {
std::size_t offset = 0; std::size_t offset = 0;
const auto& actx_cond = actx.conditions(); const auto& actx_cond = actx.conditions();
int first_greater = 0; int first_greater = 0;
if( !actx_cond.empty() &&
actx_cond[0].cmp == Opm::Action::Comparator::LESS)
{ {
const auto& first_cond = actx_cond[0]; first_greater = 1;
if (first_cond.cmp == Opm::Action::Comparator::LESS)
first_greater = 1;
} }
for (const auto& cond : actx_cond) { for (const auto& cond : actx_cond) {