OilfieldToolsNet/opm-common
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

INTEHEAD: Store Actual Maximum Number of Groups in Item 21

Browse Source 
Commit 7986e99e intended to make OPM Flow able to run simulation
cases whose active number of groups might exceed the declared
maximum number of (non-FIELD) groups (Item 3 of WELLDIMS).  However,
we did not ensure that Item 21 of INTEHEAD contained the larger of
WELLDIMS(3) and the actual number of active groups.

This, in turn, meant that downstream consumers--such as the code to
enumerate groups according to their order of appearance in the
simulation deck--would generate subscripts/indices that were out of
bounds for the allocated tables.  Flow's restart code would then not
produce any output and the user would not be aware of the problem
until attempting to restart a simulation or trying to visualise 3D
simulation results.

This commit corrects the situation by ensuring that we always store
the larger of the two sizes in INTEHEAD(21).

Pointy Hat: @bska
This commit is contained in:
Bård Skaflestad 2019-06-19 12:53:33 +02:00
parent 599ed7136f
commit 212150e7b8
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/opm/output/eclipse/CreateInteHead.cpp
View File

@ -71,6 +71,7 @@ namespace {
Opm::RestartIO::InteHEAD::WellTableDim
getWellTableDims(const int nwgmax,
const int ngmax,
const ::Opm::Runspec& rspec,
const ::Opm::Schedule& sched,
const std::size_t lookup_step)
@ -86,7 +87,8 @@ namespace {
const auto maxWellInGroup =
std::max(wd.maxWellsPerGroup(), nwgmax);
const auto maxGroupInField = wd.maxGroupsInField();
const auto maxGroupInField =
std::max(wd.maxGroupsInField(), ngmax);
return {
numWells,
@ -258,7 +260,8 @@ createInteHead(const EclipseState& es,
.dimensions (grid.getNXYZ())
.numActive (static_cast<int>(grid.getNumActive()))
.unitConventions (getUnitConvention(es.getDeckUnitSystem()))
.wellTableDimensions(getWellTableDims(nwgmax, rspec, sched, lookup_step))
.wellTableDimensions(getWellTableDims(nwgmax, ngmax, rspec,
sched, lookup_step))
.calendarDate (getSimulationTimePoint(sched.posixStartTime(), simTime))
.activePhases (getActivePhases(rspec))
// The numbers below have been determined experimentally to work