OilfieldToolsNet/opm-common
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #2143 from joakim-hove/roew-copt

Browse Source 
Summary keyword ROEW is based on COPT and not WOPT
This commit is contained in:
Joakim Hove 2020-12-02 08:29:40 +01:00 committed by GitHub
commit 5b50805c0f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 22 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/opm/output/eclipse/Summary.cpp
View File

@ -754,7 +754,7 @@ inline quantity bhp( const fn_args& args ) {
/* /*
This function is slightly ugly - the evaluation of ROEW uses the already This function is slightly ugly - the evaluation of ROEW uses the already
calculated WOPT results. We do not really have any formalism for such calculated COPT results. We do not really have any formalism for such
dependencies between the summary vectors. For this particualar case there is a dependencies between the summary vectors. For this particualar case there is a
hack in SummaryConfig which should ensure that this is safe. hack in SummaryConfig which should ensure that this is safe.
*/ */
@ -766,10 +766,10 @@ quantity roew(const fn_args& args) {
return zero; return zero;
double oil_prod = 0; double oil_prod = 0;
const auto& wells = args.regionCache.wells( region_name, args.num ); for (const auto& [well, global_index] : args.regionCache.connections(region_name, args.num)) {
for (const auto& well : wells) const auto copt_key = fmt::format("COPT:{}:{}" , well, global_index + 1);
oil_prod += args.st.get_well_var(well, "WOPT"); oil_prod += args.st.get(copt_key);
}
oil_prod = args.unit_system.to_si(Opm::UnitSystem::measure::volume, oil_prod); oil_prod = args.unit_system.to_si(Opm::UnitSystem::measure::volume, oil_prod);
return { oil_prod / args.initial_inplace.get( region_name, Opm::Inplace::Phase::OIL, args.num ) , measure::identity }; return { oil_prod / args.initial_inplace.get( region_name, Opm::Inplace::Phase::OIL, args.num ) , measure::identity };
} }

15
src/opm/parser/eclipse/EclipseState/SummaryConfig/SummaryConfig.cpp
View File

@ -762,8 +762,19 @@ inline void keywordR( SummaryConfig::keyword_list& list,
} }
// See comment on function roew() in Summary.cpp for this weirdness. // See comment on function roew() in Summary.cpp for this weirdness.
if (keyword.rfind("ROEW", 0) == 0) if (keyword.rfind("ROEW", 0) == 0) {
keywordW(list, "WOPT", {}, schedule); auto copt_node = SummaryConfigNode("COPT", SummaryConfigNode::Category::Connection, {});
for (const auto& wname : schedule.wellNames()) {
copt_node.namedEntity(wname);
const auto& well = schedule.getWellatEnd(wname);
for( const auto& connection : well.getConnections() ) {
copt_node.number( connection.global_index() + 1 );
list.push_back( copt_node );
}
}
}
auto param = SummaryConfigNode { auto param = SummaryConfigNode {

6
tests/parser/SummaryConfigTests.cpp
View File

@ -1190,7 +1190,9 @@ RHPV_REG
)"; )";
const auto& summary_config = createSummary(deck_string); const auto& summary_config = createSummary(deck_string);
BOOST_CHECK_EQUAL(summary_config.size(), 15 + 4); // The +5 corresponds to five additional COPT summary config keywords which
// have been automatically added for the ROEW calculation.
BOOST_CHECK_EQUAL(summary_config.size(), 15 + 5);
BOOST_CHECK(summary_config.hasKeyword("RPR__REG")); BOOST_CHECK(summary_config.hasKeyword("RPR__REG"));
BOOST_CHECK(summary_config.hasKeyword("ROPT_REG")); BOOST_CHECK(summary_config.hasKeyword("ROPT_REG"));
BOOST_CHECK(summary_config.hasKeyword("RRPV_REG")); BOOST_CHECK(summary_config.hasKeyword("RRPV_REG"));
@ -1215,7 +1217,7 @@ RHPV_REG
BOOST_CHECK_EQUAL(rpr.size(), 3U); BOOST_CHECK_EQUAL(rpr.size(), 3U);
// See comment on the roew() function in Summary.cpp for this uglyness. // See comment on the roew() function in Summary.cpp for this uglyness.
BOOST_CHECK(summary_config.hasKeyword("WOPT")); BOOST_CHECK(summary_config.hasKeyword("COPT"));
} }
BOOST_AUTO_TEST_CASE( WOPRL ) { BOOST_AUTO_TEST_CASE( WOPRL ) {