Merge pull request #1645 from akva2/janitoring

quell compiler warnings

src/opm/io/eclipse/SummaryNode.cpp

@@ -41,6 +41,9 @@ constexpr bool use_number(Opm::EclIO::SummaryNode::Category category) {
     case Opm::EclIO::SummaryNode::Category::Well:
         return false;
     }
+
+    static_assert("Unhandled category in use_number");
+    return false; // Never reached, but quells compiler warning
 }
 
 constexpr bool use_name(Opm::EclIO::SummaryNode::Category category) {
@@ -57,6 +60,9 @@ constexpr bool use_name(Opm::EclIO::SummaryNode::Category category) {
     case Opm::EclIO::SummaryNode::Category::Region:
         return false;
     }
+
+    static_assert("Unhandled category in use_name");
+    return false; // Never reached, but quells compiler warning
 }
 
 };

src/opm/output/eclipse/Summary.cpp

@@ -1333,6 +1333,8 @@ inline std::vector<Opm::Well> find_wells( const Opm::Schedule& schedule,
     case Opm::EclIO::SummaryNode::Category::Miscellaneous:
         return {};
     }
+
+    throw std::runtime_error("Unhandled summary node category in find_wells");
 }
 
 bool need_wells(const Opm::EclIO::SummaryNode& node) {
@@ -1352,6 +1354,8 @@ bool need_wells(const Opm::EclIO::SummaryNode& node) {
     case Opm::EclIO::SummaryNode::Category::Block:
         return false;
     }
+
+    throw std::runtime_error("Unhandled summary node category in need_wells");
 }
 
 void eval_udq(const Opm::Schedule& schedule, std::size_t sim_step, Opm::SummaryState& st)