Paul Egberts
d2d86e250b
added throw when wrong saturation family is specified
2021-03-22 09:59:21 +01:00
Paul Egberts
fc2524a57a
fix to allow running a one-phase system
2021-03-19 10:18:04 +01:00
Paul Egberts
eea578a0ef
small clean up
2021-03-16 10:21:37 +01:00
Paul Egberts
249983c52a
fix to avoid reading gaswater parameters if oil is present
2021-03-11 16:07:53 +01:00
Paul Egberts
809c1d3f1b
fix of the wrong number of template arguments error in test_fluidmatrixintercations.cpp
2021-03-11 16:07:53 +01:00
Paul Egberts
ace2930603
use of normalizeKrValues() to account for TOLCRIT
2021-03-11 16:07:52 +01:00
Paul Egberts
b2ce73012e
Adaptations neededed for gas-water system
2021-03-11 16:07:52 +01:00
Bård Skaflestad
1479adf6af
Explicitly Prevent Negative 3-p Kro Values in Stone 2 Model
...
This makes the material balance equations converge more smoothly in
corner cases and makes a real field case run at all.
2021-02-23 09:17:13 +01:00
Tor Harald Sandve
372bb122a6
Merge pull request #448 from totto82/addExtrapolationThermalVisc
...
Extrapolate oil viscosity temperature factor for undersaturated case
2021-02-23 08:52:01 +01:00
Tor Harald Sandve
ea03ba8287
Extrapolate oil viscosity temperatuer factor for undersaturated case
2021-02-22 15:31:13 +01:00
Bård Skaflestad
c7317befa7
Merge pull request #443 from totto82/blackoilDiff
...
Add support for diffusion in the blackoil fluid system
2021-02-18 18:05:15 +01:00
Tor Harald Sandve
ac4a3871ef
Add expression that return diffusion coefficient based on temperature, pressure and salinity
...
Diffusion coefficient of CO2 in pure water according to (McLachlan and Danckwerts, 1972)
Diffusion coefficient of CO2 in the brine phase modified following (Ratcliff and Holdcroft,1963 and Al-Rawajfeh, 2004)
2021-02-12 12:18:07 +01:00
Tor Harald Sandve
f9552a2081
fix assert statement
2021-02-04 09:44:56 +01:00
Tor Harald Sandve
e55568a646
dont allow for default molar weight in DIFFC table
2021-02-04 09:44:56 +01:00
Tor Harald Sandve
f406ecd914
fix molar weights
2021-02-04 09:44:56 +01:00
Tor Harald Sandve
570ec20598
init diffusion from deck
2021-02-04 09:44:56 +01:00
Tor Harald Sandve
ceb71c53a2
Add diffusion to blackoil fluidsystem. Diffusion coefficients are only implemented for the CO2-Brine system
2021-02-04 09:44:56 +01:00
Bård Skaflestad
d10786a18c
Merge pull request #439 from bska/vscale-disp-sat-general
...
Implement Three-Point Vertical Scaling for Non-Wetting Phase Relative Permeability
2021-01-27 21:27:47 +01:00
Bård Skaflestad
a56df026be
Implement Three-Point Vertical Scaling for Krn
...
This commit implements the vertical scaling mode activated by the
keywords KRORW, KRORG, and KRGR. This is the same scaling mode as
the KRWR feature implemented, but requires reversing the logic since
we implement the non-wetting phase's relative permeability function
in terms of the wetting phase's saturation.
2021-01-27 18:34:24 +01:00
Bård Skaflestad
2f07358322
Honour TOLCRIT for Tabulated Relative Permeability
...
This commit ensures that we honour TOLCRIT settings when
constructing the internal representations of tabulated relative
permeability functions. In particular, relative permeability values
less than or equal to TOLCRIT are treated as zero.
2021-01-27 18:34:24 +01:00
Bård Skaflestad
a5a45e4020
Merge pull request #438 from bska/fix-famI-sogcr
...
Fix Family I SOGCR Endpoint Hack
2021-01-27 18:29:57 +01:00
Bård Skaflestad
c390e356f3
Fix Family I SOGCR Endpoint Hack
...
The maximum attainable oil saturation in the G/O system is 1-SWL.
Update call sites accordingly.
2021-01-25 20:37:54 +01:00
Bård Skaflestad
247ce0e3fa
Mark Objects 'const' Where Possible
...
Also, don't use lifetime extension for 'Evaluation' objects where
these are constructed inside functions. Doing so inhibits NRVO.
2021-01-25 20:37:54 +01:00
Tor Harald Sandve
f8f1bfc341
Merge pull request #444 from totto82/addInternalEnergy3
...
add missing internal energy function in CO2-Brine module
2021-01-25 14:12:00 +01:00
Tor Harald Sandve
61d262684d
add missing internal energy function in CO2-Brine module
2021-01-21 15:11:10 +01:00
Bård Skaflestad
d0bc4a2c05
Merge pull request #442 from totto82/co2outofidx
...
fix out of bound in CO2.hpp
Closes #441 .
2021-01-19 12:39:04 +01:00
Tor Harald Sandve
f528b2c33f
fix out of bound in CO2.hpp
2021-01-18 10:12:30 +01:00
Bård Skaflestad
292ee5174a
Merge pull request #436 from bska/vscale-disp-sat
...
Implement KRWR Vertical Scaling
2021-01-14 14:15:46 +01:00
Bård Skaflestad
5a30a49e53
Implement KRWR Vertical Scaling
...
This commit adds support for scaling of the relative permeability
value for water at the residual saturation of the displacing
(non-wetting) phase. We use pure vertical scaling in the left
interval [SWL, SR], and a linear/affine function in the right
interval [SR, SWU].
2021-01-13 15:38:34 +01:00
Bård Skaflestad
d1ccb8fcee
Capture Three-Point Vertical Scaling Properties
...
These scale relative permeability function values at the residual
saturation of the displacing phase.
2021-01-13 15:38:34 +01:00
Bård Skaflestad
bb191a5381
Always Store Three Saturation End-Points
...
The two-point scalings will use [0] and [2] instead of [0] and [1].
This is in preparation of introducing 'KRWR' scaling which does not
necessarily require the alternative scaling method ('SCALECRS') for
the horizontal direction.
2021-01-13 15:38:34 +01:00
Atgeirr Flø Rasmussen
bc70036de5
Merge pull request #440 from totto82/fixIdxSalinity
...
fix the index into salinity in the BrineCo2Pvt model
2021-01-13 15:01:54 +01:00
Tor Harald Sandve
474d8c72c5
fix the index into salinity in the BrineCo2Pvt model
2021-01-13 12:35:04 +01:00
Joakim Hove
f4cb4dc292
Merge pull request #437 from joakim-hove/sched-oilvap
...
Get OilVaporization properties from ScheduleState
2021-01-08 09:21:36 +01:00
Joakim Hove
a431e8ba7f
Get OilVaporization properties from ScheduleState
2021-01-07 09:20:19 +01:00
Bård Skaflestad
3db77dd5f9
Merge pull request #434 from bska/use-common-eps-api
...
Extract Endpoints Using Common Facilities
2021-01-05 11:52:52 +01:00
Bård Skaflestad
51e2efd431
Get Saturation Function Family From SatFuncControls
...
There's no need to duplicate this logic.
2020-12-21 00:51:36 +01:00
Bård Skaflestad
15c84cc3fc
Extract Endpoints Using Common Facilities
...
This means we get the "SWCO" handling in SOGCR based on SGOF for
free, and also removes duplicated and complex logic.
2020-12-21 00:51:36 +01:00
Bård Skaflestad
fb5bdc1302
EPS Grid Properties: Prefer Single Assignments
2020-12-11 12:11:14 +01:00
Atgeirr Flø Rasmussen
ce4cbafe95
Merge pull request #435 from akva2/test_init
...
Change static intialization of CO2 tables to avoid function call, use construction.
2020-12-11 07:34:52 +01:00
Arne Morten Kvarving
75b2609336
test if apple clang likes this better
2020-12-08 15:27:50 +01:00
Atgeirr Flø Rasmussen
e58a660235
Merge pull request #432 from goncalvesmachadoc/aquifer
...
Do not check for kr curves for water single-phase
2020-12-01 08:38:02 +01:00
Cintia Goncalves Machado
5513bff1ba
generalize single-phase fix
2020-11-25 17:48:45 +01:00
Cintia Goncalves Machado
1d4dd874ca
do not check for kr curves for flow_onephase
2020-11-24 17:38:12 +01:00
Arne Morten Kvarving
2e7b1e4339
Merge pull request #430 from akva2/janitoring
...
fix header guard
2020-10-05 12:46:15 +02:00
Arne Morten Kvarving
d3a226166f
fix header guard
2020-10-05 11:04:48 +02:00
Tor Harald Sandve
28dd5a2b36
Merge pull request #427 from totto82/co2pvt
...
Add a co2brine pvt model
2020-10-02 12:26:19 +02:00
Tor Harald Sandve
15ff65ffcd
Add a co2brine pvt model
...
The CO2BRINE model is activated by setting CO2STOR in the RUNSPEC section
The CO2 and brine pvt properties are computed based on pvt models in opm-material
- CO2 density is from Span and Wager (1996) as given in co2table.inc
- CO2 viscosity is from Fenhour et al (1998)
- Brine density and viscosity is based on H20 + correction based on Batzle and Wang (1992)
- H20 density is from Hu et al (2007)
- H20 viscosity is computed from density based on correlation given in IAPWS 97
At the current stage the oil-phase is used to model the brine. If a proper gas-water
simulator is made, the Brine PVT should be moved to the water phase.
Known limitations:
- Currently the viscosity of the Brine does not depend on the composition
- Salinity is assumed to be constant and given by SALINITY [mol/kg].
2020-10-01 16:15:39 +02:00
Joakim Hove
e54ff1af09
Merge pull request #428 from joakim-hove/remove-common-exceptions
...
Remove unusued #include common excpetions
2020-09-21 14:27:34 +02:00
Joakim Hove
1315acfe51
Remove unusued #include common excpetions
2020-09-21 10:56:05 +02:00