Commit Graph

1081 Commits

Author SHA1 Message Date
Tor Harald Sandve
f127b5b162 Merge pull request #466 from plgbrts/gaswater5
fixed use of wrong saturations for gas relperm for gas-water system
2021-08-03 11:59:00 +02:00
Arne Morten Kvarving
24dba01e99 changed: get rid of OPM_UNUSED macro usage
prefer anonymous parameters and c++17 [[maybe_unused]]
2021-08-03 09:32:02 +02:00
Paul Egberts
76c759ee17 fixed use of wrong saturations for gas relperm for gas-water system 2021-07-14 13:22:43 +02:00
Bård Skaflestad
0eb0d51186 Merge pull request #463 from akva2/janitoring
Some janitoring
2021-06-21 15:36:57 +02:00
Arne Morten Kvarving
d397cb0429 fix some issues in pvt classes
comparison operators were broken by 15ff65ffcd
2021-06-21 13:00:01 +02:00
Arne Morten Kvarving
25321c5558 fixed: remove unused variable 2021-06-21 12:59:54 +02:00
Arne Morten Kvarving
b2776b00e0 fixed: move header guard on top of file
tools expect it to be the first thing
2021-06-21 12:59:13 +02:00
Bård Skaflestad
9ae03c4095 Merge pull request #462 from akva2/janitoring
fixed: do not assert conditions guaranteed by unsigned
2021-06-18 16:56:01 +02:00
Arne Morten Kvarving
50c8cbea78 fixed: do not assert conditions guaranteed by unsigned 2021-06-18 13:24:02 +02:00
Bård Skaflestad
4ac1eab2cd Merge pull request #461 from akva2/janitoring
Some janitoring
2021-06-09 10:36:45 +02:00
Arne Morten Kvarving
1a75bd9ab4 avoid signed/unsigned comparison warnings 2021-06-09 08:30:39 +02:00
Arne Morten Kvarving
69970a0602 add missing includes 2021-06-09 08:30:01 +02:00
Bård Skaflestad
8960609e04 Merge pull request #460 from akva2/missing_includes
fixed: add missing includes
2021-05-25 20:49:35 +02:00
Arne Morten Kvarving
07af818a5e fixed: add missing includes 2021-05-25 11:44:53 +02:00
Bård Skaflestad
29e8f523de Merge pull request #459 from akva2/no_opm_in_opm_part_2
fixed: do not use Opm:: prefix within Opm namespace part 2
2021-05-07 21:39:24 +02:00
Arne Morten Kvarving
6689e6d08f fixed: do not use Opm:: prefix within Opm namespace part 2
have to use anchoring to root namespace in some places due
to overlapping namespace and class type names.
2021-05-05 21:58:33 +02:00
Arne Morten Kvarving
9e8d48f1d2 remove unused typedefs
they cause conflicts with templates in Opm namespace.
2021-05-05 21:53:12 +02:00
Arne Morten Kvarving
7241acabac changed: make enums enum class
and put them outside class defintion to avoid template
parameter dependence.
2021-05-05 21:44:13 +02:00
Bård Skaflestad
3e26468453 Merge pull request #458 from akva2/no_opm_in_opm
fixed: do not use Opm:: prefix when inside namespace Opm
2021-05-05 14:15:53 +02:00
Arne Morten Kvarving
13f0659d71 fixed: do not use Opm:: prefix when inside namespace Opm 2021-05-05 09:46:32 +02:00
Bård Skaflestad
e97f4d49f8 Merge pull request #455 from akva2/include_deck
fixed: need to include Deck.hpp in test
2021-04-26 14:19:36 +02:00
Arne Morten Kvarving
8cdc05caf0 fixed: need to include Deck.hpp in test 2021-04-26 12:04:35 +02:00
Bård Skaflestad
e706b69cad Merge pull request #451 from osae/fix2pIndex
Correcting phase index.
2021-04-08 15:11:52 +02:00
Ove Sævareid
f4b5fe48da Correcting phase index. 2021-04-08 12:14:25 +02:00
Bård Skaflestad
92f430cd1d Merge pull request #450 from joakim-hove/ep-value
Use value objects for endpoint scaling
2021-04-07 17:24:40 +02:00
Joakim Hove
6979b62754 Use value objects for endpoint scaling 2021-04-07 10:09:43 +02:00
Tor Harald Sandve
819d8379ed Merge pull request #446 from bska/eval-2p-krox
Expose Two-Phase Oil Relperm As Individual Operation
2021-04-06 08:49:52 +02:00
Bård Skaflestad
ab386e0074 Expose Two-Phase Oil Relperm As Individual Operation
This commit adds new operations

    relpermOilInOilGasSystem(params, fluidState)
    relpermOilInOilWaterSystem(params, fluidState)

to the Ecl*Material implementations.  The primary objective is to
support calculating the KROG and KROW quantities separately for
summary output purposes (keywords BKROG, BKROW).  Reimplement the
'krn' operation in terms of these new functions.

At present, these operations are supported only for three-phase
simulation runs.
2021-03-22 13:00:26 +01:00
Bård Skaflestad
af5f93c6f9 Merge pull request #447 from plgbrts/gaswater
Adaptations neededed for gas-water system
2021-03-22 12:59:36 +01:00
Atgeirr Flø Rasmussen
3218ae4286 Merge pull request #445 from bska/prevent-neg-kro-stone2
Explicitly Prevent Negative 3-p Kro Values in Stone 2 Model
2021-03-22 11:27:56 +01:00
Paul Egberts
d2d86e250b added throw when wrong saturation family is specified 2021-03-22 09:59:21 +01:00
Paul Egberts
fc2524a57a fix to allow running a one-phase system 2021-03-19 10:18:04 +01:00
Paul Egberts
eea578a0ef small clean up 2021-03-16 10:21:37 +01:00
Paul Egberts
249983c52a fix to avoid reading gaswater parameters if oil is present 2021-03-11 16:07:53 +01:00
Paul Egberts
809c1d3f1b fix of the wrong number of template arguments error in test_fluidmatrixintercations.cpp 2021-03-11 16:07:53 +01:00
Paul Egberts
ace2930603 use of normalizeKrValues() to account for TOLCRIT 2021-03-11 16:07:52 +01:00
Paul Egberts
b2ce73012e Adaptations neededed for gas-water system 2021-03-11 16:07:52 +01:00
Bård Skaflestad
1479adf6af Explicitly Prevent Negative 3-p Kro Values in Stone 2 Model
This makes the material balance equations converge more smoothly in
corner cases and makes a real field case run at all.
2021-02-23 09:17:13 +01:00
Tor Harald Sandve
372bb122a6 Merge pull request #448 from totto82/addExtrapolationThermalVisc
Extrapolate oil viscosity temperature factor for undersaturated case
2021-02-23 08:52:01 +01:00
Tor Harald Sandve
ea03ba8287 Extrapolate oil viscosity temperatuer factor for undersaturated case 2021-02-22 15:31:13 +01:00
Bård Skaflestad
c7317befa7 Merge pull request #443 from totto82/blackoilDiff
Add support for diffusion in the blackoil fluid system
2021-02-18 18:05:15 +01:00
Tor Harald Sandve
ac4a3871ef Add expression that return diffusion coefficient based on temperature, pressure and salinity
Diffusion coefficient of CO2 in pure water according to (McLachlan and Danckwerts, 1972)
Diffusion coefficient of CO2 in the brine phase modified following (Ratcliff and Holdcroft,1963 and Al-Rawajfeh, 2004)
2021-02-12 12:18:07 +01:00
Tor Harald Sandve
f9552a2081 fix assert statement 2021-02-04 09:44:56 +01:00
Tor Harald Sandve
e55568a646 dont allow for default molar weight in DIFFC table 2021-02-04 09:44:56 +01:00
Tor Harald Sandve
f406ecd914 fix molar weights 2021-02-04 09:44:56 +01:00
Tor Harald Sandve
570ec20598 init diffusion from deck 2021-02-04 09:44:56 +01:00
Tor Harald Sandve
ceb71c53a2 Add diffusion to blackoil fluidsystem. Diffusion coefficients are only implemented for the CO2-Brine system 2021-02-04 09:44:56 +01:00
Bård Skaflestad
d10786a18c Merge pull request #439 from bska/vscale-disp-sat-general
Implement Three-Point Vertical Scaling for Non-Wetting Phase Relative Permeability
2021-01-27 21:27:47 +01:00
Bård Skaflestad
a56df026be Implement Three-Point Vertical Scaling for Krn
This commit implements the vertical scaling mode activated by the
keywords KRORW, KRORG, and KRGR.  This is the same scaling mode as
the KRWR feature implemented, but requires reversing the logic since
we implement the non-wetting phase's relative permeability function
in terms of the wetting phase's saturation.
2021-01-27 18:34:24 +01:00
Bård Skaflestad
2f07358322 Honour TOLCRIT for Tabulated Relative Permeability
This commit ensures that we honour TOLCRIT settings when
constructing the internal representations of tabulated relative
permeability functions.  In particular, relative permeability values
less than or equal to TOLCRIT are treated as zero.
2021-01-27 18:34:24 +01:00