Commit Graph

5352 Commits

Author SHA1 Message Date
Arne Morten Kvarving
237b63e674 reduce scope of variables to avoid dead store warnings 2023-06-01 09:38:45 +02:00
Arne Morten Kvarving
1492182866 make variable constexpr to avoid dead store warning 2023-06-01 09:38:45 +02:00
Arne Morten Kvarving
51aecfb2de fixed: apply VAPPARS from SOLUTION section 2023-05-31 15:13:55 +02:00
Bård Skaflestad
5a79e0f8fb Test Dynamic Segment Dimensions Against WSEGDIMS Limits
In particular, check that

  1. Number of MS wells <= WSEGDIMS(1)
  2. Number of segments per well <= WSEGDIMS(2)
  3. Number of branches per well <= WSEGDIMS(3)

for all report steps in the simulation run.

Example diagnostic message of a case that violates limits 2 and 3:

Error: Problem with keyword WSEGDIMS
  In CASE.DATA line 60
  The case has a multi-segmented well with 246 well segments, but at most 200 are allowed in WSEGDIMS.
  Please increase item 2 of WSEGDIMS to at least 246

Error: Problem with keyword WSEGDIMS
  In CASE.DATA line 60
  The case has a multi-segmented well with 105 lateral branches, but at most 5 are allowed in WSEGDIMS.
  Please increase item 3 of WSEGDIMS to at least 105
2023-05-30 11:47:50 +02:00
Bård Skaflestad
0bc74799ca Merge pull request #3465 from plgbrts/well-specs-new
adding defaults to json files
2023-05-30 11:43:53 +02:00
Paul
4d5b4aba2b changed return type to reference-to-const 2023-05-30 10:49:52 +02:00
Tor Harald Sandve
a456c36a31 Merge pull request #3513 from goncalvesmachadoc/gasvisct
Implement GASVISCT for black-oil [Bug fix]
2023-05-30 08:37:46 +02:00
goncalvesmachadoc
b30f297053 add comments on reference values 2023-05-29 13:20:53 +02:00
Kai Bao
b16f2ed8be update summary quantities even there is no wells associated with it
then it should get a zero. otherwise, the old values will be used.
2023-05-25 09:10:02 +02:00
Kai Bao
ca2dbd1c09 Merge pull request #3523 from totto82/foam_solvent
Add Solvent and Water as transport phase for foam model
2023-05-23 12:27:32 +02:00
Paul
7a8fb7b832 improved error message 2023-05-23 10:48:13 +02:00
Tor Harald Sandve
0514ba2e44 remove INSTANCE(11) as it is not needed 2023-05-23 09:28:22 +02:00
Tor Harald Sandve
54dbf3a9ce add solvent and water as transport fluid for foam 2023-05-23 08:52:25 +02:00
Tor Harald Sandve
ec8a76414a compile for evaluation with 11 derivatives 2023-05-23 08:52:25 +02:00
Arne Morten Kvarving
4572a7135f avoid some dead stores 2023-05-22 23:00:20 +02:00
Arne Morten Kvarving
32b526993d changed: mark explicit units constexpr
these constants are known at compile time.
as a bonus, this also quells warnings
emitted by infer due to it not seeing through
the implicit lambda captures
2023-05-22 22:57:14 +02:00
Arne Morten Kvarving
1c7240977c remove pointless increments 2023-05-22 22:12:18 +02:00
Arne Morten Kvarving
b68f5f1226 add arguments by const ref 2023-05-22 22:08:12 +02:00
Tor Harald Sandve
005ff3e982 Merge pull request #3445 from svenn-t/h2store
Hydrogen-brine simulations - H2STORE
2023-05-22 11:23:48 +02:00
Bård Skaflestad
82226cc0b9 Merge pull request #3527 from akva2/explicit_ctors
mark constructors explicit
2023-05-16 12:06:54 +02:00
Arne Morten Kvarving
6553e8d0b7 mark constructors explicit 2023-05-16 10:50:01 +02:00
Bård Skaflestad
4308305421 Merge pull request #3433 from totto82/brine_co2store
Combine brine + co2store
2023-05-16 10:25:32 +02:00
Arne Morten Kvarving
3ae5fa9f80 Merge pull request #3503 from totto82/default_ehystr
Use default values for EHYSTR if not present but Hysteresis is activated by HYST in SATOPTS
2023-05-15 08:48:32 +02:00
Paul
05d59a14f4 add throw in case a well has a non-increasing MD column 2023-05-12 16:14:58 +02:00
Vegard Kippe
899a1176c2 Changing TUNING semantics to 'only change when specified'. No impact on next time step needs to be handled separately. 2023-05-12 13:02:22 +02:00
Bård Skaflestad
910cd4cf41 Merge pull request #3516 from goncalvesmachadoc/keywordsummary
Parse compositional summary keywords
2023-05-11 21:18:30 +02:00
Bård Skaflestad
45017090f8 Merge pull request #3518 from totto82/extendRstconfig
Add supported mnemonic to list
2023-05-11 21:08:57 +02:00
Tor Harald Sandve
09b69ae644 Add supported mnemonic to list to avoid warning 2023-05-11 12:00:10 +02:00
Arne Morten Kvarving
d599c6874d EclThermalConductionApproach: convert to enum class 2023-05-11 08:46:25 +02:00
Arne Morten Kvarving
7d38661810 EclSolidEnergyApproach: convert to enum class 2023-05-11 08:40:44 +02:00
goncalvesmachadoc
c6421a5b9c parse comp summary keywords 2023-05-10 11:29:25 +02:00
goncalvesmachadoc
abaa1074ff implement gasvisct 2023-05-09 10:48:25 +02:00
Bård Skaflestad
991ac2ca84 Check for Invalid Cells in Block Level Summary Vectors
This commit adds sanity checking to the cell references of block
level summary vectors (e.g., BPR or BGSAT).  If the summary vector
references a cell that's outside the models declared dimensions we
issue a warning and ignore that particular summary vector request.
2023-05-07 16:10:42 +02:00
Tor Harald Sandve
4f3b67fa77 use 58.44 as molar mass of salt 2023-05-04 09:48:03 +02:00
Tor Harald Sandve
46f5558b59 Combine brine and the co2store module
This commit allows for dynamically changes in salinity in the co2 storage module

I.e. It allows for modeling salt precipition for co2 storage cases.
2023-05-03 15:09:06 +02:00
Tor Harald Sandve
8dfc9a12f5 Use default values for EHYSTR if not present but Hysteresis is activated by HYST in SATOPTS 2023-05-03 15:04:16 +02:00
Bård Skaflestad
d1087f6463 Split WELLDIMS Error Message Formatting Out to Helper Functions
That way, they could become reusable for other keywords and we can
exploit the commonality between MAXWELLS and MAXGROUPS.  Moreover,
we can reduce the visual clutter of the body of each checking
function and fix some singular/plural mismatches in the diagnostic
messages.
2023-05-02 21:33:50 +02:00
Bård Skaflestad
9a5b3721cb Dimension Segment Related Restart Arrays According to Dynamic Size
The [IR]SEG and ILB[RS] arrays must be able to accommodate the
maximum number of segments and branches used in the run.  This
commit incorporates the dynamic maximum sizes.  If those sizes
exceed the maximum values entered in WSEGDIMS, then the resulting
restart file will not be fully compatible with other simulation
software.
2023-05-02 09:44:06 +02:00
Bård Skaflestad
28e057af39 Merge pull request #3488 from goncalvesmachadoc/summary
Add WWGR to summary
2023-04-28 11:35:18 +02:00
goncalvesmachadoc
21e4e9d2f1 add_wwgr 2023-04-27 12:03:25 +02:00
Paul
b171cbc3af Calculate headI/headJ from trajectory data when they are defaulted in WELSPECS 2023-04-26 17:30:53 +02:00
Bård Skaflestad
5cdeb6137b Implement Proper Record Copying Behaviour for ROCK
This commit adds the expected behaviour for all-defaulted records in
ROCK, provided the all-defaulted records are not the first of the
keyword.  Similarly to, e.g. PVTW, all-defaulted records are treated as
copies of the immediately preceding record.

In other words, given

    ROCK
    -- REF. PRES   COMPRESSIBILITY
       280.000        5.6E-5 /
    /

the second record is supposed to be a copy of the first.
2023-04-26 14:29:28 +02:00
Markus Blatt
8beebd49e3 Merge pull request #3485 from atgeirr/allow-field-wells
Allow FIELD group as parent for wells
2023-04-26 14:14:33 +02:00
Markus Blatt
f16b433b53 Merge pull request #3484 from akva2/fix_udqdefine_serialize
fixed: missing serialization of tokens in UDQDefine
2023-04-26 12:54:52 +02:00
Atgeirr Flø Rasmussen
33843346b4 Use ParseContext system to handle well under FIELD situation.
Also downgrade from a throw to a warning.
2023-04-26 11:43:21 +02:00
Arne Morten Kvarving
6ff355a141 fixed: missing serialization of tokens in UDQDefine
this went unnoticed since there are no UDQDefines in the pre-simulation
Schedule broadcast for parallel. however it causes issues for serialized
restarts
2023-04-26 11:35:12 +02:00
Atgeirr Flø Rasmussen
6de95332be Avoid printing "Internal error" for user input problems.
This is done by:
 - splitting the catch(std::exception) in KeywordHandlers.cpp
   in two and catching std::logic_error separately,
 - not adding "Internal error" in the OpmInputError constructor
   taking std::exception.
In addition, two possible user errors related to mixing groups
and wells as children of a single group have been changed to
std::runtime_error.
2023-04-26 11:35:05 +02:00
Bård Skaflestad
ffea242f7e Reimplement Enum->String Conversion in Terms of Array
Improves lookup speed.

Suggested by: [at]blattms.
2023-04-25 19:49:18 +02:00
Bård Skaflestad
0c6aff9b68 Make Diagnostic Message Reflect Reality
We also need to include DOUBLE_SLASH_TERMINATED in the list of
alternatives.
2023-04-25 19:47:02 +02:00
Paul Egberts
26daf8e544 adding defaults to json files 2023-04-24 16:12:00 +02:00