Commit Graph

2910 Commits

Author SHA1 Message Date
Arne Morten Kvarving
6700e08c84 avoid dead store 2023-06-01 09:38:45 +02:00
Arne Morten Kvarving
f64f587055 mark variable maybe_unused to avoid dead store warnings 2023-06-01 09:38:45 +02:00
Arne Morten Kvarving
237b63e674 reduce scope of variables to avoid dead store warnings 2023-06-01 09:38:45 +02:00
Arne Morten Kvarving
89ce51af81 added: unit test for VAPPARS in SOLUTION section
also revise existing test using SCHEDULE to check
that level 0 is UNDEF
2023-05-31 15:49:23 +02:00
Bård Skaflestad
682e6d8763 Merge pull request #3541 from akva2/test_spline_janitoring
test_spline: convert to boost::test
2023-05-30 14:21:47 +02:00
Bård Skaflestad
5a79e0f8fb Test Dynamic Segment Dimensions Against WSEGDIMS Limits
In particular, check that

  1. Number of MS wells <= WSEGDIMS(1)
  2. Number of segments per well <= WSEGDIMS(2)
  3. Number of branches per well <= WSEGDIMS(3)

for all report steps in the simulation run.

Example diagnostic message of a case that violates limits 2 and 3:

Error: Problem with keyword WSEGDIMS
  In CASE.DATA line 60
  The case has a multi-segmented well with 246 well segments, but at most 200 are allowed in WSEGDIMS.
  Please increase item 2 of WSEGDIMS to at least 246

Error: Problem with keyword WSEGDIMS
  In CASE.DATA line 60
  The case has a multi-segmented well with 105 lateral branches, but at most 5 are allowed in WSEGDIMS.
  Please increase item 3 of WSEGDIMS to at least 105
2023-05-30 11:47:50 +02:00
Arne Morten Kvarving
edeb7679b0 test_ncpflash: convert to boost::test 2023-05-30 10:31:56 +02:00
Bård Skaflestad
86a2f856d3 Merge pull request #3547 from akva2/test_fluidmatrixinteractions_janitoring
test_fluidmatrixinteractions: convert to boost::test
2023-05-30 08:36:31 +02:00
Arne Morten Kvarving
59ce72d04f test_fluidmatrixinteractions: convert to boost::test 2023-05-30 07:23:55 +02:00
Arne Morten Kvarving
98a9367b19 test_eclmateriallawmanager: convert to boost::test 2023-05-30 07:08:56 +02:00
Bård Skaflestad
4146ce75f3 Merge pull request #3545 from akva2/test_eclblackoilpvt_janitoring
test_eclblackoilpvt: convert to boost::test
2023-05-26 16:25:31 +02:00
Bård Skaflestad
4e1333deda Merge pull request #3544 from akva2/test_eclblackoilfluidsystem_janitoring
test_eclblackoilfluidsystem: convert to boost::test
2023-05-26 16:10:00 +02:00
Arne Morten Kvarving
4eac0243ae test_eclblackoilpvt: convert to boost::test 2023-05-26 15:51:41 +02:00
Arne Morten Kvarving
f424e8ec6e test_eclblackoilfluidsystem: convert to boost::test 2023-05-26 15:28:30 +02:00
Arne Morten Kvarving
492823d8dd test_blackoilfluidstate: convert to boost::test 2023-05-26 15:12:47 +02:00
Arne Morten Kvarving
eb84d95263 test_spline: convert to boost::test 2023-05-26 13:48:43 +02:00
Bård Skaflestad
857f9e39e4 Merge pull request #3540 from akva2/test_threecomponents_ptflash_janitoring
test_threecomponents_ptflash: convert to boost::test
2023-05-26 12:57:43 +02:00
Bård Skaflestad
823788a7c8 Merge pull request #3539 from akva2/test_2dtables_janitoring
test_2dtables: convert to boost::test
2023-05-26 12:57:13 +02:00
Arne Morten Kvarving
99035c4400 test_co2brine_ptflash: use stream 2023-05-26 12:37:06 +02:00
Arne Morten Kvarving
949d14d7c7 test_threecomponents_ptflash: convert to boost::test 2023-05-26 12:35:56 +02:00
Arne Morten Kvarving
e650889965 test_2dtables: convert to boost::test 2023-05-26 12:21:53 +02:00
Arne Morten Kvarving
4abfc8115e test_immiscibleflash: convert to boost::test 2023-05-26 12:20:35 +02:00
Arne Morten Kvarving
4bd20c6364 test_co2brine_ptflash: convert to boost::test 2023-05-25 22:53:25 +02:00
Bård Skaflestad
51f21f86bd Merge pull request #3535 from akva2/test_tabulation_janitoring
test_tabulation: Some janitoring
2023-05-25 22:23:40 +02:00
Bård Skaflestad
621dcad31d Merge pull request #3533 from akva2/test_fluidsystems_janitoring
test_fluidsystems: Some janitoring
2023-05-25 22:22:42 +02:00
Bård Skaflestad
80bdd0f999 Merge pull request #3532 from akva2/test_co2brinepvt_janitoring
test_co2brinepvt: Some janitoring
2023-05-25 22:21:30 +02:00
Arne Morten Kvarving
edefd93f38 test_components: convert to boost::test 2023-05-25 21:49:07 +02:00
Arne Morten Kvarving
180f34dea7 checkComponent: improve output
as this is called multiple times for a component
we get duplicate output. improve by also including the
Evaluation template parameters in the output.
2023-05-25 21:49:07 +02:00
Arne Morten Kvarving
0baa0f441a test_tabulation: convert to boost::test 2023-05-25 21:15:38 +02:00
Arne Morten Kvarving
860bc2e7f6 test_tabulation: adjust tolerances so there are no failed comparisons 2023-05-25 21:13:04 +02:00
Arne Morten Kvarving
174e19c35d test_fluidsystems: convert to Boost::Test 2023-05-24 22:04:39 +02:00
Arne Morten Kvarving
91d5db381a fixed: avoid dead stores in test_fluidsystems 2023-05-24 22:04:39 +02:00
Arne Morten Kvarving
89b1a95a2d test_co2brinepvt: convert to Boost::Test 2023-05-23 22:31:50 +02:00
Arne Morten Kvarving
38fb67496d fixed: avoid dead stores in test_co2brinepvt 2023-05-23 22:16:47 +02:00
Arne Morten Kvarving
553ac0a14c reduce scope of variable
avoids sca warnings
2023-05-22 23:00:30 +02:00
Tor Harald Sandve
005ff3e982 Merge pull request #3445 from svenn-t/h2store
Hydrogen-brine simulations - H2STORE
2023-05-22 11:23:48 +02:00
Bård Skaflestad
4308305421 Merge pull request #3433 from totto82/brine_co2store
Combine brine + co2store
2023-05-16 10:25:32 +02:00
Tor Harald Sandve
1aff5fc604 add test that compares Brine and BrineDynamic 2023-05-12 09:07:55 +02:00
Arne Morten Kvarving
644d371026 Merge pull request #3508 from blattms/prevent-crash
Fixes segfaulting PYACTION test with pybind 2.10.3 and python 3.11
2023-05-10 15:49:21 +02:00
Arne Morten Kvarving
651693e623 avoid unused expression warning 2023-05-09 10:35:40 +02:00
Markus Blatt
84aa367b19 Exception type differs beween pybind11 versions, use std::exception. 2023-05-05 16:09:58 +02:00
Markus Blatt
3e5ac55c1b Prevent segmentation faults for exceptions thrown in Python code
If for example pybind11 or python changes the type of exception thrown
and we expect a different (the old one) in our boost test, then the python
of pybind11 is left in an unusable condition and the next attempt of
running might produce hard to debug exception, This happened on Debian
bookworm (pybind 2.10.3, python 3.11) for syntax errors.
2023-05-05 16:03:17 +02:00
Bård Skaflestad
5cdeb6137b Implement Proper Record Copying Behaviour for ROCK
This commit adds the expected behaviour for all-defaulted records in
ROCK, provided the all-defaulted records are not the first of the
keyword.  Similarly to, e.g. PVTW, all-defaulted records are treated as
copies of the immediately preceding record.

In other words, given

    ROCK
    -- REF. PRES   COMPRESSIBILITY
       280.000        5.6E-5 /
    /

the second record is supposed to be a copy of the first.
2023-04-26 14:29:28 +02:00
Markus Blatt
8beebd49e3 Merge pull request #3485 from atgeirr/allow-field-wells
Allow FIELD group as parent for wells
2023-04-26 14:14:33 +02:00
Atgeirr Flø Rasmussen
a055f11392 Update tests for new behaviour. 2023-04-26 12:02:34 +02:00
Bård Skaflestad
599194191d Implement Full Size Protocol for ROCK Keyword
This commit adds a special case for handling the dynamic nature of
the number of records in the ROCK keyword.  In particular, if the
ROCKOPTS keyword is NOT entered before ROCK, then the number of
records is NTPVT--item 2 from TABDIMS.  Conversely, when ROCKOPTS is
entered before ROCK, the number of records in the latter depends on
the setting in item 3 of ROCKOPTS.

This interaction cannot be easily captured in our JSON-based models,
so we introduce a special size class, SPECIAL_CASE_ROCK, that only
applies to the ROCK keyword and implement the logic in a dedicated
function in 'Parser.cpp'.  Once we have determined the correct
number of records, we form a RawKeyword of type FIXED and defer
further processing to the existing handling of fixed-sized keywords.

Add a selection of unit tests to exercise the new behaviour.
2023-04-24 12:54:41 +02:00
Bård Skaflestad
93a2f71545 Merge pull request #3463 from GitPaean/open_wellopen_zerorate_nocrossflow_wells
not forbidding WELOPEN wells with zero rate and disallowing crossflow
2023-04-13 10:34:41 +02:00
Markus Blatt
0ca91f5498 Fixed wrong data file comment. 2023-04-12 17:02:07 +02:00
Svenn Tveit
c498234879 Re-added deleted code 2023-04-12 14:28:02 +02:00
Svenn Tveit
2502e05a6f Move H2STORE test below CO2STORE tests 2023-04-12 14:28:01 +02:00