Common components for OPM, in particular build system (cmake).
5f650785a9
this causes problems with things like DRSDT where "isSaturated(oilPhasIdx)" is not necessarily related to the presence of the gas phase. (analogous for DRVDT.) The impact of performance seems to be negligible: ``` Total time (seconds): 550.185 Solver time (seconds): 534.769 Assembly time (seconds): 251.509 (Failed: 4.51604; 1.79558%) Linear solve time (seconds): 263.03 (Failed: 5.78332; 2.19873%) Update time (seconds): 11.0526 (Failed: 0.220144; 1.99177%) Output write time (seconds): 18.1411 Overall Well Iterations: 902 (Failed: 7; 0.776053%) Overall Linearizations: 1890 (Failed: 33; 1.74603%) Overall Newton Iterations: 1553 (Failed: 33; 2.12492%) Overall Linear Iterations: 23525 (Failed: 511; 2.17216%) ``` before and ``` Total time (seconds): 556.463 Solver time (seconds): 541.06 Assembly time (seconds): 253.165 (Failed: 4.42903; 1.74946%) Linear solve time (seconds): 267.343 (Failed: 4.52042; 1.69087%) Update time (seconds): 11.334 (Failed: 0.214721; 1.89449%) Output write time (seconds): 18.0694 Overall Well Iterations: 903 (Failed: 8; 0.885936%) Overall Linearizations: 1909 (Failed: 33; 1.72865%) Overall Newton Iterations: 1572 (Failed: 33; 2.09924%) Overall Linear Iterations: 23866 (Failed: 391; 1.63831%) ``` after this patch, i.e., on my machine the runtime for Norne went from 550 to 556 seconds due to slightly larger number of non-linear and linear iterations. Note that this also happens if the 1e-4 threshold value is changed instead of the case distinction being removed. (This hints on the into the direction that the performance difference is just numerical noise.) |
||
|---|---|---|
| bin | ||
| opm/material | ||
| tests | ||