Files
opm-common/opm/parser/eclipse/Parser/ParserStringItem.hpp
Roland Kaufmann f8c6bfbaf2 Change unintended compile-time polymorphism to dynamic
equals(ParserIntItem&) has a different signature than equals(ParserItem&),
thus the former method does *not* overload the latter. Virtual just means
then only means that you have created a *new* entry in the v-table. If
you call equals through a pointer/reference to the base class ParserItem,
the defined method in the derived class is not called, and we miss out the
test for the equal default value.

Instead, we should take an argument of the base type and use a dynamic
cast to the derived type. If this downcast fails, then they are not equal;
otherwise we have gotten ourselves a pointer to get the properly typed
default value.

We must use pointers instead of references; if we cast to a reference,
a bad_cast exception is thrown if the expression is not in the proper
type hierarchy.
2013-10-23 20:54:56 +02:00

57 lines
1.9 KiB
C++

/*
Copyright 2013 Statoil ASA.
This file is part of the Open Porous Media project (OPM).
OPM is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
OPM is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with OPM. If not, see <http://www.gnu.org/licenses/>.
*/
#ifndef PARSERSTRINGITEM_HPP
#define PARSERSTRINGITEM_HPP
#include <opm/json/JsonObject.hpp>
#include <opm/parser/eclipse/Parser/ParserItem.hpp>
#include <opm/parser/eclipse/Parser/ParserEnums.hpp>
namespace Opm {
class ParserStringItem : public ParserItem {
public:
ParserStringItem(const std::string& itemName);
ParserStringItem(const std::string& itemName, ParserItemSizeEnum sizeType);
ParserStringItem(const std::string& itemName, ParserItemSizeEnum sizeType, const std::string& defaultValue);
ParserStringItem(const std::string& itemName, const std::string& defaultValue);
ParserStringItem( const Json::JsonObject& jsonConfig);
bool equal(const ParserItem& other) const;
DeckItemConstPtr scan(RawRecordPtr rawRecord) const;
void inlineNew(std::ostream& os) const;
void setDefault(const std::string& defaultValue);
std::string getDefault() const {
return m_default;
}
private:
std::string m_default;
};
typedef boost::shared_ptr<const ParserStringItem> ParserStringItemConstPtr;
typedef boost::shared_ptr<ParserStringItem> ParserStringItemPtr;
}
#endif /* PARSERSTRINGITEM_HPP */