Specifically, only assemble gravity contributions on internal faces or
external Dirichlet faces. Moreover, pay attention to direction of
gravity flux (in/out of cell) during assembly.
Specifically, split detection of prescribed reservoir pressure values
from prescribed well (i.e., BHP) pressure values. Previously, we
would not even assemble any well contributions if there were any
prescribed reservoir pressure values. Moreover, the return value from
assemble_cell_contrib() was exactly opposite of its intended value...
Callers may pass NULLs in absence of wells in any given model. This
implementation assembles an equation for each well, irrespective of
well control type (BHP or RATE), and assumes that productivity indices
and perforation pressure drops account for multiphase effects.
- Got rid of FlowSolution object (reintroduce if abstraction needed).
- Changed estimateCellVelocitySimpleInterface() to match.
- Face pressures now are part of the interface for the pressure solver
(you are supposed to initialize them properly, too).
- Changed test program to match changes.
- Face pressures as output by pressure solver are now propagated to
the outside.
The last item is a behavioural change, so all results are slightly
different.
We will generate square matrices only in the foreseeable future and
there is no need to maintain the number of columns (the 'n' member)
separately. Update all users accordingly.
Following cset ba5d27f90d7a there is no need to compute the interface
pressure values after every linear solve. Re-factor
cfs_tpfa_press_flux() to only compute cell pressures and interface
fluxes, and move interface pressure value computation to cfs_tpfa_fpress().
Having a 'MAT_SIZE_T' that is sometimes an int and sometimes an
mwSignedIndex is asking for trouble. The practical impact for OPM is
low, though, as this issue affects only the MEX interface.
