OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2025-01-06 22:43:01 -06:00
Code Issues Packages Projects Releases Wiki Activity
6fa9c25ba5
opm-simulators/tests/test_LogOutputHelper.cpp

412 lines
17 KiB
C++
Raw Normal View History

add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
/*
Copyright 2018 SINTEF Digital, Mathematics and Cybernetics.
Copyright 2018 Equinor.
This file is part of the Open Porous Media project (OPM).
OPM is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
OPM is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with OPM. If not, see <http://www.gnu.org/licenses/>.
*/
#include <config.h>
#define BOOST_TEST_MODULE TestLogOutputHelper
#include <boost/test/unit_test.hpp>
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
#include <opm/simulators/flow/LogOutputHelper.hpp>
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
#include <opm/common/OpmLog/OpmLog.hpp>
#include <opm/common/OpmLog/StreamLog.hpp>
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
#include <opm/common/utility/String.hpp>
#include <opm/input/eclipse/EclipseState/EclipseState.hpp>
#include <opm/input/eclipse/Schedule/Schedule.hpp>
#include <opm/input/eclipse/Schedule/SummaryState.hpp>
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
#include <opm/input/eclipse/Deck/Deck.hpp>
#include <opm/input/eclipse/Parser/Parser.hpp>
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
#include <array>
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
#include <memory>
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
#include <sstream>
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
#include <string>
namespace {
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
Opm::Deck deck()
{
return Opm::Parser{}.parseString(R"(RUNSPEC
OIL
GAS
WATER
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
FIELD
DIMENS
10 10 3 /
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
DXV
10*1000.0 /
DYV
10*1000.0 /
DZV
20.0 30.0 50.0 /
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
TOPS
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
100*8325.0 /
START -- 0
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
31 AUG 1993 /
SCHEDULE
WELSPECS
-- Item #: 1 2 3 4 5 6
'PROD' 'G1' 10 10 8400 'OIL' /
'INJ' 'G1' 1 1 8335 'GAS' /
/
WCONPROD
-- Item #:1 2 3 4 5 9
'PROD' 'OPEN' 'ORAT' 20000 4* 1000 /
/
WCONINJE
-- Item #:1 2 3 4 5 6 7
'INJ' 'GAS' 'OPEN' 'RATE' 100000 1* 9014 /
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
/
END
)");
}
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
std::string trimStream(std::stringstream& str)
{
std::string data;
PRT file updates * Arrays genarated from RPTSOL + FIP is now strictly following Eclipse format * Adding reservoir volume array also for custom FIP regions
2023-12-15 05:18:34 -06:00
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
std::array<char, 1024> buffer{};
do {
str.getline(buffer.data(), buffer.size(), '\n');
PRT file updates * Arrays genarated from RPTSOL + FIP is now strictly following Eclipse format * Adding reservoir volume array also for custom FIP regions
2023-12-15 05:18:34 -06:00
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
const auto tmp = std::string { buffer.data() };
if (!tmp.empty()) {
data += Opm::trim_copy(tmp);
data += '\n';
}
} while (!str.eof());
return data;
}
template <int type>
struct LogFixture
{
LogFixture() : LogFixture { deck() } {}
LogFixture(const Opm::Deck& deck)
: eclState { deck }
, schedule { deck, eclState }
{
Opm::OpmLog::addBackend("stream", std::make_shared<Opm::StreamLog>(str, type));
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
}
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
~LogFixture()
{
Opm::OpmLog::removeBackend("stream");
}
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
Opm::EclipseState eclState{};
Opm::Schedule schedule{};
Opm::SummaryState st{};
PRT file updates * Arrays genarated from RPTSOL + FIP is now strictly following Eclipse format * Adding reservoir volume array also for custom FIP regions
2023-12-15 05:18:34 -06:00
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
std::stringstream str;
};
using LogNoteFixture = LogFixture<Opm::Log::MessageType::Note>;
using LogWarningFixture = LogFixture<Opm::Log::MessageType::Warning>;
} // Anonymous namespace
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
use fixtures for test_LogOutputHelper
2024-04-11 03:59:32 -05:00
BOOST_FIXTURE_TEST_CASE(Cumulative, LogNoteFixture)
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
{
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
const auto reference = std::string {
R"(=================================================== CUMULATIVE PRODUCTION/INJECTION REPORT =========================================
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
: WELL : LOCATION : WELL :CTRL: OIL : WATER : GAS : Prod : OIL : WATER : GAS : INJ :
: NAME : (I,J,K) : TYPE :MODE: PROD : PROD : PROD : RES.VOL. : INJ : INJ : INJ : RES.VOL. :
: : : : : MSTB : MSTB : MMSCF : MRB : MSTB : MSTB : MMSCF : MRB :
====================================================================================================================================
: FIELD: : : : 1.0: 2.0: 3.0: 4.0: 5.0: 6.0: 7.0: 8.0:
: G1: : : : 9.0: 10.0: 11.0: 12.0: 13.0: 14.0: 15.0: 15.0:
: PROD: 10, 10: PROD:ORAT: 16.0: 17.0: 18.0: 19.0: 20.0: 21.0: 22.0: 23.0:
: INJ: 1, 1: INJ:GRAT: 24.0: 25.0: 26.0: 27.0: 28.0: 29.0: 30.0: 31.0:
Remove Dashed Lines Between Records in PRT File Reports This commit splits the production, injection, and cumulative *Report_() functions into three logically distinct parts, one for outputting the report header (begin*Report_()), one for outputting a single report record (output*ReportRecord_()), and one for ending the report (end*Report_()). This simplifies the logic of the *Record_() member functions since they no longer need to infer the context which is already available in the caller and can perform a more narrow task than before. With this separation we're also able to remove the dashed lines which would previously separate each report record, thereby creating PRT file report sheets which have a more expected layout. Moreover, as an aid to future maintenance, we also factor out common code for the well and group cases in each *Record_() function. Finally, fix a unit conversion problem in the report values for cumulative gas quantities. The sheet header states that we should be outputting values in 'MM' prefixed units, but we were only scaling the gas values by a factor of 1000 instead of 1000*1000. In other words, the injection and production gas values in the cumulative sheet were off by a factor of 1000.
2023-12-08 06:44:33 -06:00
:--------:-----------:--------:----:-----------:-----------:-----------:-----------:-----------:-----------:-----------:-----------:
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
)"
};
Remove Dashed Lines Between Records in PRT File Reports This commit splits the production, injection, and cumulative *Report_() functions into three logically distinct parts, one for outputting the report header (begin*Report_()), one for outputting a single report record (output*ReportRecord_()), and one for ending the report (end*Report_()). This simplifies the logic of the *Record_() member functions since they no longer need to infer the context which is already available in the caller and can perform a more narrow task than before. With this separation we're also able to remove the dashed lines which would previously separate each report record, thereby creating PRT file report sheets which have a more expected layout. Moreover, as an aid to future maintenance, we also factor out common code for the well and group cases in each *Record_() function. Finally, fix a unit conversion problem in the report values for cumulative gas quantities. The sheet header states that we should be outputting values in 'MM' prefixed units, but we were only scaling the gas values by a factor of 1000 instead of 1000*1000. In other words, the injection and production gas values in the cumulative sheet were off by a factor of 1000.
2023-12-08 06:44:33 -06:00
// Note: Cumulative gas values--e.g., FGPT--multiplied by an additional
// factor of 1000, for a total multiplicative factor of one million, in
// order to produce the expected balance sheet output in MM* units.
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
st.set("FOPT", 1.0e3);
st.set("FWPT", 2.0e3);
st.set("FGPT", 3.0e6);
st.set("FVPT", 4.0e3);
st.set("FOIT", 5.0e3);
st.set("FWIT", 6.0e3);
st.set("FGIT", 7.0e6);
st.set("FVIT", 8.0e3);
st.update_group_var("G1", "GOPT", 9.0e3);
st.update_group_var("G1", "GWPT", 10.0e3);
st.update_group_var("G1", "GGPT", 11.0e6);
st.update_group_var("G1", "GVPT", 12.0e3);
st.update_group_var("G1", "GOIT", 13.0e3);
st.update_group_var("G1", "GWIT", 14.0e3);
st.update_group_var("G1", "GGIT", 15.0e6);
st.update_group_var("G1", "GVIT", 15.0e3);
st.update_well_var("PROD", "WOPT", 16.0e3);
st.update_well_var("PROD", "WWPT", 17.0e3);
st.update_well_var("PROD", "WGPT", 18.0e6);
st.update_well_var("PROD", "WVPT", 19.0e3);
st.update_well_var("PROD", "WOIT", 20.0e3);
st.update_well_var("PROD", "WWIT", 21.0e3);
st.update_well_var("PROD", "WGIT", 22.0e6);
st.update_well_var("PROD", "WVIT", 23.0e3);
st.update_well_var("INJ", "WOPT", 24.0e3);
st.update_well_var("INJ", "WWPT", 25.0e3);
st.update_well_var("INJ", "WGPT", 26.0e6);
st.update_well_var("INJ", "WVPT", 27.0e3);
st.update_well_var("INJ", "WOIT", 28.0e3);
st.update_well_var("INJ", "WWIT", 29.0e3);
st.update_well_var("INJ", "WGIT", 30.0e6);
st.update_well_var("INJ", "WVIT", 31.0e3);
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
Fix linking errors when using shared libraries. We accomplish that by passing the module version as a string to the constructors of LogOutputHelper and EclGenericOutputBlackoilModel instead of calling moduleVersionName() in LogOutputHelper. That way moduleVersionName is not needed by libopmsimulators anymore and compilation works again for people requesting shared libraries via CMake's BUILD_SHARED_LIBS variable.
2024-01-29 09:37:38 -06:00
Opm::LogOutputHelper<double> helper(eclState, schedule, st, "dummy version");
Output Well Flow Sheets for All Wells There is no need to restrict PRT file flow reports to those wells which are active on the current rank since the SummaryState object holds information for all wells active at the current report step.
2024-01-04 09:58:43 -06:00
helper.cumulative(0);
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
const auto data = trimStream(str);
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
BOOST_CHECK_EQUAL(data, reference);
}
use fixtures for test_LogOutputHelper
2024-04-11 03:59:32 -05:00
BOOST_FIXTURE_TEST_CASE(Error, LogWarningFixture)
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
{
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
const auto reference = std::string {
R"(Finding the bubble point pressure failed for 3 cells [(2,1,1), (1,3,1), (1,4,1)]
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
Finding the dew point pressure failed for 3 cells [(5,1,1), (6,1,1), (7,1,1)]
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
)"
};
Fix linking errors when using shared libraries. We accomplish that by passing the module version as a string to the constructors of LogOutputHelper and EclGenericOutputBlackoilModel instead of calling moduleVersionName() in LogOutputHelper. That way moduleVersionName is not needed by libopmsimulators anymore and compilation works again for people requesting shared libraries via CMake's BUILD_SHARED_LIBS variable.
2024-01-29 09:37:38 -06:00
Opm::LogOutputHelper<double> helper(eclState, schedule, st, "dummy version");
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
fixed: we need to initialize logger before parsing parsing logs some errors which meant using uninitialized values if no logger has been set
2023-11-20 08:06:52 -06:00
str.str(""); // clear out parser errors
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
helper.error({1,20,30}, {4,5,6});
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
const auto data = trimStream(str);
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
BOOST_CHECK_EQUAL(data, reference);
}
use fixtures for test_LogOutputHelper
2024-04-11 03:59:32 -05:00
BOOST_FIXTURE_TEST_CASE(Fip, LogNoteFixture)
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
{
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
const auto reference = std::string {
R"(
PRT file updates * Arrays genarated from RPTSOL + FIP is now strictly following Eclipse format * Adding reservoir volume array also for custom FIP regions
2023-12-15 05:18:34 -06:00
==================================================
: FIELD TOTALS :
: PAV = 0 PSIA :
: PORV= 157 RB :
: Pressure is weighted by hydrocarbon pore volume:
: Pore volumes are taken at reference conditions :
:--------------- OIL STB ----------------:-- WAT STB --:--------------- GAS MSCF ----------------:
: LIQUID VAPOUR TOTAL : TOTAL : FREE DISSOLVED TOTAL :
:-------------------------:-------------------------------------------:----------------:-------------------------------------------:
:CURRENTLY IN PLACE : 132 138 120: 113 : 1 1 1:
:-------------------------:-------------------------------------------:----------------:-------------------------------------------:
:ORIGINALLY IN PLACE : 25 31 13: 6 : 0 0 0:
====================================================================================================================================
==================================================
: FIPNUM REPORT REGION 1 :
: PAV = 0 PSIA :
: PORV= 371 RB :
:--------------- OIL STB ----------------:-- WAT STB --:--------------- GAS MSCF ----------------:
: LIQUID VAPOUR TOTAL : TOTAL : FREE DISSOLVED TOTAL :
:-------------------------:-------------------------------------------:----------------:-------------------------------------------:
:CURRENTLY IN PLACE : 346 352 333: 327 : 2 2 2:
:-------------------------:-------------------------------------------:----------------:-------------------------------------------:
:ORIGINALLY IN PLACE : 239 245 226: 220 : 1 1 1:
:-------------------------:-------------------------------------------:----------------:-------------------------------------------:
====================================================================================================================================
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
)"
};
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
Opm::Inplace initial, current;
{
const auto offset = 17.0;
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
double j = 1.0;
for (const auto& phase : current.phases()) {
initial.add(phase, j);
initial.add("FIPNUM", phase, 0, j + 2*offset);
initial.add("FIPNUM", phase, 1, j + 2*offset);
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
current.add(phase, j + offset);
current.add("FIPNUM", phase, 0, j + 3*offset);
current.add("FIPNUM", phase, 1, j + 3*offset);
++j;
}
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
}
initial.add(Opm::Inplace::Phase::PressureHydroCarbonPV, 1.0);
initial.add(Opm::Inplace::Phase::HydroCarbonPV, 2.0);
initial.add(Opm::Inplace::Phase::PressurePV, 3.0);
initial.add(Opm::Inplace::Phase::DynamicPoreVolume, 4.0);
current.add(Opm::Inplace::Phase::PressureHydroCarbonPV, 2.0);
current.add(Opm::Inplace::Phase::HydroCarbonPV, 4.0);
current.add(Opm::Inplace::Phase::PressurePV, 6.0);
current.add(Opm::Inplace::Phase::DynamicPoreVolume, 8.0);
current.add("FIPNUM", Opm::Inplace::Phase::PressureHydroCarbonPV, 1, 2.0);
current.add("FIPNUM", Opm::Inplace::Phase::HydroCarbonPV, 1, 4.0);
current.add("FIPNUM", Opm::Inplace::Phase::PressurePV, 1, 6.0);
current.add("FIPNUM", Opm::Inplace::Phase::DynamicPoreVolume, 1, 8.0);
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
Opm::LogOutputHelper<double> helper(eclState, schedule, st, "dummy version");
changed: refactor LogOutputHelper::fip only do one output per call. allow passing the name of the regions to process
2023-11-08 08:39:41 -06:00
helper.fip(current, initial, "");
helper.fip(current, initial, "FIPNUM");
PRT file updates * Arrays genarated from RPTSOL + FIP is now strictly following Eclipse format * Adding reservoir volume array also for custom FIP regions
2023-12-15 05:18:34 -06:00
BOOST_CHECK_EQUAL(str.str(), reference);
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
}
use fixtures for test_LogOutputHelper
2024-04-11 03:59:32 -05:00
BOOST_FIXTURE_TEST_CASE(FipResv, LogNoteFixture)
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
{
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
const auto reference = std::string {
R"(
PRT file updates * Arrays genarated from RPTSOL + FIP is now strictly following Eclipse format * Adding reservoir volume array also for custom FIP regions
2023-12-15 05:18:34 -06:00
===================================
: RESERVOIR VOLUMES RB :
:---------:---------------:---------------:---------------:---------------:---------------:
: REGION : TOTAL PORE : PORE VOLUME : PORE VOLUME : PORE VOLUME : PORE VOLUME :
: : VOLUME : CONTAINING : CONTAINING : CONTAINING : CONTAINING :
: : : OIL : WATER : GAS : HYDRO-CARBON :
:---------:---------------:---------------:---------------:---------------:---------------
: FIELD : 176: 13: 19: 25: 38:
: 1 : 176: 170: 164: 176: 346:
===========================================================================================
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
)"
};
const auto offset = 17.0;
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
Opm::Inplace current;
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
{
double j = 1.0;
for (const auto& phase : current.phases()) {
current.add(phase, offset);
current.add("FIPNUM", phase, 1, j + offset);
++j;
}
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
}
current.add(Opm::Inplace::Phase::DynamicPoreVolume, 1.0);
current.add(Opm::Inplace::Phase::OilResVolume, 2.0);
current.add(Opm::Inplace::Phase::WaterResVolume, 3.0);
current.add(Opm::Inplace::Phase::GasResVolume, 4.0);
make test independent on inplace.size()
2024-01-23 02:42:09 -06:00
current.add("FIPNUM", Opm::Inplace::Phase::DynamicPoreVolume, 1, 11.0 + offset);
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
Opm::LogOutputHelper<double> helper(eclState, schedule, st, "dummy version");
PRT file updates * Arrays genarated from RPTSOL + FIP is now strictly following Eclipse format * Adding reservoir volume array also for custom FIP regions
2023-12-15 05:18:34 -06:00
helper.fipResv(current, "FIPNUM");
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
PRT file updates * Arrays genarated from RPTSOL + FIP is now strictly following Eclipse format * Adding reservoir volume array also for custom FIP regions
2023-12-15 05:18:34 -06:00
BOOST_CHECK_EQUAL(str.str(), reference);
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
}
use fixtures for test_LogOutputHelper
2024-04-11 03:59:32 -05:00
BOOST_FIXTURE_TEST_CASE(Injection, LogNoteFixture)
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
{
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
const auto reference = std::string {
R"(=================================================== INJECTION REPORT ========================================
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
: WELL : LOCATION : CTRL : CTRL : CTRL : OIL : WATER : GAS : FLUID : BHP OR : THP OR :
: NAME : (I,J,K) : MODE : MODE : MODE : RATE : RATE : RATE : RES.VOL. : CON.PR.: BLK.PR.:
: : : OIL : WAT : GAS : STB/DAY : STB/DAY : MSCF/DAY : RB/DAY : PSIA : PSIA :
Remove Dashed Lines Between Records in PRT File Reports This commit splits the production, injection, and cumulative *Report_() functions into three logically distinct parts, one for outputting the report header (begin*Report_()), one for outputting a single report record (output*ReportRecord_()), and one for ending the report (end*Report_()). This simplifies the logic of the *Record_() member functions since they no longer need to infer the context which is already available in the caller and can perform a more narrow task than before. With this separation we're also able to remove the dashed lines which would previously separate each report record, thereby creating PRT file report sheets which have a more expected layout. Moreover, as an aid to future maintenance, we also factor out common code for the well and group cases in each *Record_() function. Finally, fix a unit conversion problem in the report values for cumulative gas quantities. The sheet header states that we should be outputting values in 'MM' prefixed units, but we were only scaling the gas values by a factor of 1000 instead of 1000*1000. In other words, the injection and production gas values in the cumulative sheet were off by a factor of 1000.
2023-12-08 06:44:33 -06:00
=============================================================================================================
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
: FIELD: : : : : 1.0: 2.0: 3.0: 4.0: : :
: G1: : : : : 5.0: 6.0: 7.0: 8.0: : :
: INJ: 1, 1: : : GRAT: 9.0: 10.0: 11.0: 12.0: 13.0: 14.0:
Remove Spurious Blank Lines in PRT File Reports The StreamLog::addMessageUnconditionally() member function will end each message with a newline (std::endl) so we should not add such newlines ourselves. The extra newline characters produce spurious blank lines in the report sheets, e.g., for the "PRODUCTION REPORT". This commit removes the last newline character from each report request, thus deferring that responsibility to OpmLog::note() instead. Doing so, however, means we have take a little more care with the first line of each report lest we create report sheets which are smushed together.
2023-12-07 08:29:08 -06:00
:--------:-----------:------:------:------:-----------:-----------:-----------:-----------:--------:--------:
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
)"
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
};
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
st.set("FOIR", 1.0);
st.set("FWIR", 2.0);
st.set("FGIR", 3.0);
st.set("FVIR", 4.0);
st.update_group_var("G1", "GOIR", 5.0);
st.update_group_var("G1", "GWIR", 6.0);
st.update_group_var("G1", "GGIR", 7.0);
st.update_group_var("G1", "GVIR", 8.0);
st.update_well_var("INJ", "WOIR", 9.0);
st.update_well_var("INJ", "WWIR", 10.0);
st.update_well_var("INJ", "WGIR", 11.0);
st.update_well_var("INJ", "WVIR", 12.0);
st.update_well_var("INJ", "WBHP", 13.0);
st.update_well_var("INJ", "WTHP", 14.0);
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
Fix linking errors when using shared libraries. We accomplish that by passing the module version as a string to the constructors of LogOutputHelper and EclGenericOutputBlackoilModel instead of calling moduleVersionName() in LogOutputHelper. That way moduleVersionName is not needed by libopmsimulators anymore and compilation works again for people requesting shared libraries via CMake's BUILD_SHARED_LIBS variable.
2024-01-29 09:37:38 -06:00
Opm::LogOutputHelper<double> helper(eclState, schedule, st, "dummy version");
Output Well Flow Sheets for All Wells There is no need to restrict PRT file flow reports to those wells which are active on the current rank since the SummaryState object holds information for all wells active at the current report step.
2024-01-04 09:58:43 -06:00
helper.injection(0);
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
const auto data = trimStream(str);
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
BOOST_CHECK_EQUAL(data, reference);
}
use fixtures for test_LogOutputHelper
2024-04-11 03:59:32 -05:00
BOOST_FIXTURE_TEST_CASE(Production, LogNoteFixture)
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
{
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
const auto reference = std::string {
R"(======================================================= PRODUCTION REPORT =======================================================
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
: WELL : LOCATION :CTRL: OIL : WATER : GAS : FLUID : WATER : GAS/OIL : WAT/GAS : BHP OR : THP OR :
: NAME : (I,J,K) :MODE: RATE : RATE : RATE : RES.VOL. : CUT : RATIO : RATIO : CON.PR.: BLK.PR.:
: : : : STB/DAY : STB/DAY : MSCF/DAY : RB/DAY : : MSCF/STB : STB/MSCF : PSIA : PSIA :
=================================================================================================================================
: FIELD: : : 1.0: 2.0: 3.0: 4.0: 5.000: 6.00: 0.6667: : :
: G1: : : 7.0: 8.0: 9.0: 10.0: 11.000: 12.00: 0.8889: : :
: PROD: 10, 10:ORAT: 13.0: 14.0: 15.0: 16.0: 17.000: 18.00: 0.9333: 19.0: 20.0:
:--------:-----------:----:-----------:-----------:-----------:-----------:-----------:----------:------------:--------:--------:
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
)"
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
};
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
st.set("FOPR", 1.0);
st.set("FWPR", 2.0);
st.set("FGPR", 3.0);
st.set("FVPR", 4.0);
st.set("FWCT", 5.0);
st.set("FGOR", 6.0);
st.update_group_var("G1", "GOPR", 7.0);
st.update_group_var("G1", "GWPR", 8.0);
st.update_group_var("G1", "GGPR", 9.0);
st.update_group_var("G1", "GVPR", 10.0);
st.update_group_var("G1", "GWCT", 11.0);
st.update_group_var("G1", "GGOR", 12.0);
st.update_well_var("PROD", "WOPR", 13.0);
st.update_well_var("PROD", "WWPR", 14.0);
st.update_well_var("PROD", "WGPR", 15.0);
st.update_well_var("PROD", "WVPR", 16.0);
st.update_well_var("PROD", "WWCT", 17.0);
st.update_well_var("PROD", "WGOR", 18.0);
st.update_well_var("PROD", "WBHP", 19.0);
st.update_well_var("PROD", "WTHP", 20.0);
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
Fix linking errors when using shared libraries. We accomplish that by passing the module version as a string to the constructors of LogOutputHelper and EclGenericOutputBlackoilModel instead of calling moduleVersionName() in LogOutputHelper. That way moduleVersionName is not needed by libopmsimulators anymore and compilation works again for people requesting shared libraries via CMake's BUILD_SHARED_LIBS variable.
2024-01-29 09:37:38 -06:00
Opm::LogOutputHelper<double> helper(eclState, schedule, st, "dummy version");
Output Well Flow Sheets for All Wells There is no need to restrict PRT file flow reports to those wells which are active on the current rank since the SummaryState object holds information for all wells active at the current report step.
2024-01-04 09:58:43 -06:00
helper.production(0);
Simplify Unit Tests for LogOutputHelper In particular, put more of the common setup code into the test fixture and use more powerful constructors for the EclipseState object. While here, also switch to using the update_well_var() and update_group_var() member functions on the SummaryState object where appropriate since the resulting statements become slightly easier to understand in isolation.
2024-10-09 11:12:43 -05:00
const auto data = trimStream(str);
add tests for LogOutputHelper reference data was created before the refactoring
2023-08-11 08:23:19 -05:00
BOOST_CHECK_EQUAL(data, reference);
}
Reference in New Issue Copy Permalink