OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

fixed: use const refs in foreach constructs

Browse Source 
avoids unnecessary copies
This commit is contained in:
Arne Morten Kvarving
2020-09-01 13:25:26 +02:00
parent cb067869bd
commit 182ec130b1
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
opm/simulators/timestepping/ConvergenceReport.hpp
View File

@@ -162,7 +162,7 @@ namespace Opm
for (const auto f : res_failures_) { for (const auto f : res_failures_) {
s = smax(s, f.severity()); s = smax(s, f.severity());
} }
for (const auto f : well_failures_) { for (const auto& f : well_failures_) {
s = smax(s, f.severity()); s = smax(s, f.severity());
} }
return s; return s;

4
opm/simulators/timestepping/gatherConvergenceReport.cpp
View File

@@ -75,7 +75,7 @@ namespace
const auto wf = local_report.wellFailures(); const auto wf = local_report.wellFailures();
int num_wf = wf.size(); int num_wf = wf.size();
MPI_Pack(&num_wf, 1, MPI_INT, buf.data(), buf.size(), &offset, MPI_COMM_WORLD); MPI_Pack(&num_wf, 1, MPI_INT, buf.data(), buf.size(), &offset, MPI_COMM_WORLD);
for (const auto f : wf) { for (const auto& f : wf) {
packWellFailure(f, buf, offset); packWellFailure(f, buf, offset);
} }
} }
@@ -87,7 +87,7 @@ namespace
const int num_rf = local_report.reservoirFailures().size(); const int num_rf = local_report.reservoirFailures().size();
const int num_wf = local_report.wellFailures().size(); const int num_wf = local_report.wellFailures().size();
int wellnames_length = 0; int wellnames_length = 0;
for (const auto f : local_report.wellFailures()) { for (const auto& f : local_report.wellFailures()) {
wellnames_length += (f.wellName().size() + 1); wellnames_length += (f.wellName().size() + 1);
} }
return (2 + 3*num_rf + 4*num_wf) * int_pack_size + wellnames_length; return (2 + 3*num_rf + 4*num_wf) * int_pack_size + wellnames_length;

4
opm/simulators/wells/WellConnectionAuxiliaryModule.hpp
View File

@@ -62,7 +62,7 @@ public:
wells_.reserve(schedule_wells.size()); wells_.reserve(schedule_wells.size());
// initialize the additional cell connections introduced by wells. // initialize the additional cell connections introduced by wells.
for ( const auto well : schedule_wells ) for ( const auto& well : schedule_wells )
{ {
std::vector<int> compressed_well_perforations; std::vector<int> compressed_well_perforations;
// All possible completions of the well // All possible completions of the well
@@ -102,7 +102,7 @@ public:
void addNeighbors(std::vector<NeighborSet>& neighbors) const void addNeighbors(std::vector<NeighborSet>& neighbors) const
{ {
for(const auto well_perforations : wells_) for(const auto& well_perforations : wells_)
{ {
for(const auto& perforation : well_perforations) for(const auto& perforation : well_perforations)
neighbors[perforation].insert(well_perforations.begin(), neighbors[perforation].insert(well_perforations.begin(),

2
opm/simulators/wells/WellInterface_impl.hpp
View File

@@ -74,7 +74,7 @@ namespace Opm
int all_perf = 0; int all_perf = 0;
originalConnectionIndex_.reserve(perf_data.size()); originalConnectionIndex_.reserve(perf_data.size());
for (const auto connection : well.getConnections()) { for (const auto& connection : well.getConnections()) {
if (connection.state() == Connection::State::OPEN) { if (connection.state() == Connection::State::OPEN) {
originalConnectionIndex_.push_back(all_perf); originalConnectionIndex_.push_back(all_perf);
} }