OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Work around unstable matrix inversion in DUNE 2.[34]

Browse Source 
The versions are missing the specialized code for inverting
a 3x3 matrix that makes the algorithms quite a bit more stable.
With this patch we fall back to using our own MatrixBlock that does
not suffer from this deficiency.
This commit is contained in:
Markus Blatt 2017-07-03 09:17:37 +02:00
parent f0b60cfeed
commit 1bb0968283
2 changed files with 26 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
opm/autodiff/ISTLSolver.hpp
View File

@ -289,7 +289,14 @@ namespace Opm
} }
} }
#if DUNE_VERSION_NEWER(DUNE_ISTL, 2 , 5)
typedef ParallelOverlappingILU0<Matrix,Vector,Vector> SeqPreconditioner; typedef ParallelOverlappingILU0<Matrix,Vector,Vector> SeqPreconditioner;
#else
typedef ParallelOverlappingILU0<Dune::BCRSMatrix<Dune::MatrixBlock<typename Matrix::field_type,
Matrix::block_type::rows,
Matrix::block_type::cols> >,
Vector, Vector> SeqPreconditioner;
#endif
template <class Operator> template <class Operator>
std::unique_ptr<SeqPreconditioner> constructPrecond(Operator& opA, const Dune::Amg::SequentialInformation&) const std::unique_ptr<SeqPreconditioner> constructPrecond(Operator& opA, const Dune::Amg::SequentialInformation&) const
@ -302,7 +309,14 @@ namespace Opm
#if HAVE_MPI #if HAVE_MPI
typedef Dune::OwnerOverlapCopyCommunication<int, int> Comm; typedef Dune::OwnerOverlapCopyCommunication<int, int> Comm;
#if DUNE_VERSION_NEWER(DUNE_ISTL, 2 , 5)
typedef ParallelOverlappingILU0<Matrix,Vector,Vector,Comm> ParPreconditioner; typedef ParallelOverlappingILU0<Matrix,Vector,Vector,Comm> ParPreconditioner;
#else
typedef ParallelOverlappingILU0<Dune::BCRSMatrix<Dune::MatrixBlock<typename Matrix::field_type,
Matrix::block_type::rows,
Matrix::block_type::cols> >,
Vector, Vector, Comm> ParPreconditioner;
#endif
template <class Operator> template <class Operator>
std::unique_ptr<ParPreconditioner> std::unique_ptr<ParPreconditioner>
constructPrecond(Operator& opA, const Comm& comm) const constructPrecond(Operator& opA, const Comm& comm) const

17
opm/autodiff/ParallelOverlappingILU0.hpp
View File

@ -238,14 +238,17 @@ public:
\param n ILU fill in level (for testing). This does not work in parallel. \param n ILU fill in level (for testing). This does not work in parallel.
\param w The relaxation factor. \param w The relaxation factor.
*/ */
ParallelOverlappingILU0 (const Matrix& A, const int n, const field_type w ) template<class Matrix1>
ParallelOverlappingILU0 (const Matrix1& A, const int n, const field_type w )
: lower_(), : lower_(),
upper_(), upper_(),
inv_(), inv_(),
comm_(nullptr), w_(w), comm_(nullptr), w_(w),
relaxation_( std::abs( w - 1.0 ) > 1e-15 ) relaxation_( std::abs( w - 1.0 ) > 1e-15 )
{ {
init( A, n ); // BlockMatrix is a Subclass of FieldMatrix that just adds
// methods. Therefore this cast should be safe.
init( reinterpret_cast<const Matrix&>(A), n );
} }
/*! \brief Constructor. /*! \brief Constructor.
@ -254,7 +257,8 @@ public:
\param A The matrix to operate on. \param A The matrix to operate on.
\param w The relaxation factor. \param w The relaxation factor.
*/ */
ParallelOverlappingILU0 (const Matrix& A, const field_type w) template<class Matrix1>
ParallelOverlappingILU0 (const Matrix1& A, const field_type w)
: ParallelOverlappingILU0( A, 0, w ) : ParallelOverlappingILU0( A, 0, w )
{ {
} }
@ -266,14 +270,17 @@ public:
\param comm communication object, e.g. Dune::OwnerOverlapCopyCommunication \param comm communication object, e.g. Dune::OwnerOverlapCopyCommunication
\param w The relaxation factor. \param w The relaxation factor.
*/ */
ParallelOverlappingILU0 (const Matrix& A, const ParallelInfo& comm, const field_type w) template<class Matrix1>
ParallelOverlappingILU0 (const Matrix1& A, const ParallelInfo& comm, const field_type w)
: lower_(), : lower_(),
upper_(), upper_(),
inv_(), inv_(),
comm_(&comm), w_(w), comm_(&comm), w_(w),
relaxation_( std::abs( w - 1.0 ) > 1e-15 ) relaxation_( std::abs( w - 1.0 ) > 1e-15 )
{ {
init( A, 0 ); // BlockMatrix is a Subclass of FieldMatrix that just adds
// methods. Therefore this cast should be safe.
init( reinterpret_cast<const Matrix&>(A), 0 );
} }
/*! /*!