OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2024-12-02 05:49:09 -06:00
Code Issues Packages Projects Releases Wiki Activity

Bugfix for a corner case in MPI

Browse Source 
A corner case was hit when running the model in MPI.

The conditions become something like:
elemIdx < outsideElemIdx
insideFaceIdx == 4
useSmallestMultiplier == true

Which ultimately leads to an assert failure in applyAllZMultipliers_().

Changing the comparision between insideCartElemIdx and outsideCartElemIdx gets the bug fixed.
This commit is contained in:
locture 2024-01-05 02:46:43 -06:00 committed by GitHub
parent 5e9bdfd342
commit 204ebacbf2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ebos/ecltransmissibility_impl.hh
View File

@ -318,7 +318,13 @@ update(bool global, const std::function<unsigned int(unsigned int)>& map, const
// we only need to calculate a face's transmissibility // we only need to calculate a face's transmissibility
// once... // once...
if (elemIdx > outsideElemIdx)
// This comparison can be problematic for corner cases in mpi
// Test case observed elemIdx <= outsideElemIdx AND insideFaceIdx==4
// This means an assert failure in applyAllZMultipliers_() while useSmallestMultiplier==true
// Converting to comparison between insideCartElemIdx and outsideCartElemIdx fixes the problem
// if (elemIdx > outsideElemIdx)
if (insideCartElemIdx > outsideCartElemIdx)
continue; continue;
// local indices of the faces of the inside and // local indices of the faces of the inside and