From 21876b637eb165336e7971a0990ee5f72f24be7e Mon Sep 17 00:00:00 2001
From: David Landa Marban <dmar@norceresearch.no>
Date: Mon, 29 Sep 2025 10:28:37 +0200
Subject: [PATCH] Add missing invB in BioeffectsFluxes

---
 flow/flow_biofilm.cpp                            |  2 +-
 flow/flow_micp.cpp                               |  2 +-
 opm/models/blackoil/blackoilbioeffectsmodules.hh | 16 +++++++++-------
 opm/models/blackoil/blackoillocalresidualtpfa.hh |  8 ++++----
 4 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/flow/flow_biofilm.cpp b/flow/flow_biofilm.cpp
index 08fb20df17..89ced9e5b7 100644
--- a/flow/flow_biofilm.cpp
+++ b/flow/flow_biofilm.cpp
@@ -22,8 +22,8 @@
 #include <flow/flow_biofilm.hpp>
 
 #include <opm/material/common/ResetLocale.hpp>
-#include <opm/models/blackoil/blackoiltwophaseindices.hh>
 #include <opm/models/blackoil/blackoillocalresidualtpfa.hh>
+#include <opm/models/blackoil/blackoiltwophaseindices.hh>
 #include <opm/models/discretization/common/tpfalinearizer.hh>
 
 #include <opm/grid/CpGrid.hpp>
diff --git a/flow/flow_micp.cpp b/flow/flow_micp.cpp
index f746da2c4d..fab0a0f6f8 100644
--- a/flow/flow_micp.cpp
+++ b/flow/flow_micp.cpp
@@ -21,8 +21,8 @@
 #include <opm/grid/CpGrid.hpp>
 
 #include <opm/material/common/ResetLocale.hpp>
-#include <opm/models/blackoil/blackoilonephaseindices.hh>
 #include <opm/models/blackoil/blackoillocalresidualtpfa.hh>
+#include <opm/models/blackoil/blackoilonephaseindices.hh>
 #include <opm/models/discretization/common/tpfalinearizer.hh>
 
 #include <opm/simulators/flow/Main.hpp>
diff --git a/opm/models/blackoil/blackoilbioeffectsmodules.hh b/opm/models/blackoil/blackoilbioeffectsmodules.hh
index b49f279aee..f1bcb405b5 100644
--- a/opm/models/blackoil/blackoilbioeffectsmodules.hh
+++ b/opm/models/blackoil/blackoilbioeffectsmodules.hh
@@ -208,23 +208,26 @@ public:
         }
     }
 
-    template <class UpEval, class Eval, class IntensiveQuantities>
+    template <class UpEval>
     static void addBioeffectsFluxes_(RateVector& flux,
                                      unsigned phaseIdx,
-                                     const Eval& volumeFlux,
+                                     const Evaluation& volumeFlux,
                                      const IntensiveQuantities& upFs)
     {
         if (phaseIdx == waterPhaseIdx) {
             if constexpr (enableBioeffects) {
                 flux[contiMicrobialEqIdx] =
                     decay<UpEval>(upFs.microbialConcentration())
+                    * decay<UpEval>(upFs.fluidState().invB(waterPhaseIdx))
                     * volumeFlux;
                 if constexpr (enableMICP) {
                     flux[contiOxygenEqIdx] =
                         decay<UpEval>(upFs.oxygenConcentration())
+                        * decay<UpEval>(upFs.fluidState().invB(waterPhaseIdx))
                         * volumeFlux;
                     flux[contiUreaEqIdx] =
                         decay<UpEval>(upFs.ureaConcentration())
+                        * decay<UpEval>(upFs.fluidState().invB(waterPhaseIdx))
                         * volumeFlux;
                 }
             }
@@ -262,16 +265,15 @@ public:
 
     template <class UpstreamEval>
     static void addBioeffectsFluxes_(RateVector& flux,
-                               const ElementContext& elemCtx,
-                               unsigned scvfIdx,
-                               unsigned timeIdx)
+                                     const ElementContext& elemCtx,
+                                     unsigned scvfIdx,
+                                     unsigned timeIdx)
     {
         const auto& extQuants = elemCtx.extensiveQuantities(scvfIdx, timeIdx);
         unsigned upIdx = extQuants.upstreamIndex(waterPhaseIdx);
         const auto& up = elemCtx.intensiveQuantities(upIdx, timeIdx);
-        const auto& fs = up.fluidState();
         const auto& volFlux = extQuants.volumeFlux(waterPhaseIdx);
-        addBioeffectsFluxes_<UpstreamEval>(flux, volFlux, fs);
+        addBioeffectsFluxes_<UpstreamEval>(flux, waterPhaseIdx, volFlux, up);
     }
 
     static void addSource(RateVector& source,
diff --git a/opm/models/blackoil/blackoillocalresidualtpfa.hh b/opm/models/blackoil/blackoillocalresidualtpfa.hh
index a47ea556e4..fbaf98cf6f 100644
--- a/opm/models/blackoil/blackoillocalresidualtpfa.hh
+++ b/opm/models/blackoil/blackoillocalresidualtpfa.hh
@@ -415,8 +415,8 @@ public:
                         addPhaseEnthalpyFluxes_<Evaluation>(flux, phaseIdx, darcyFlux, up.fluidState());
                 }
                 if constexpr (enableBioeffects) {
-                    BioeffectsModule::template addBioeffectsFluxes_<Evaluation, Evaluation, IntensiveQuantities>
-                        (flux, phaseIdx, darcyFlux, up);
+                    BioeffectsModule::template
+                        addBioeffectsFluxes_<Evaluation>(flux, phaseIdx, darcyFlux, up);
                 }
             } else {
                 const auto& invB = getInvB_<FluidSystem, FluidState, Scalar>(up.fluidState(), phaseIdx, pvtRegionIdx);
@@ -427,8 +427,8 @@ public:
                         addPhaseEnthalpyFluxes_<Scalar>(flux,phaseIdx,darcyFlux, up.fluidState());
                 }
                 if constexpr (enableBioeffects) {
-                    BioeffectsModule::template addBioeffectsFluxes_<Scalar, Evaluation, IntensiveQuantities>
-                        (flux, phaseIdx, darcyFlux, up);
+                    BioeffectsModule::template
+                        addBioeffectsFluxes_<Scalar>(flux, phaseIdx, darcyFlux, up);
                 }
             }
         }