OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

adding updateGroupControls() to StandardWellsDense

Browse Source 
which separates the group control related operations. The group control
has to be handled in the level of all wells, which makes more functions
of the well class to be visible outside.
This commit is contained in:
Kai Bao 2017-06-28 13:46:01 +02:00
parent d535157b1a
commit 229244142f
3 changed files with 34 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
opm/autodiff/StandardWell_impl.hpp
View File

@ -1825,12 +1825,6 @@ namespace Opm
invDuneD_.mv(resWell_, dx_well);
updateWellState(dx_well, param, well_state);
// updateWellControls uses communication
// Therefore the following is executed if there
// are active wells anywhere in the global domain.
updateWellControl(well_state);
setWellVariables(well_state);
}
}

2
opm/autodiff/StandardWellsDense.hpp
View File

@ -294,6 +294,8 @@ enum WellVariablePositions {
void applyVREPGroupControl(WellState& well_state) const;
void updateGroupControls(WellState& well_state) const;
protected:
bool wells_active_;
const Wells* wells_;

69
opm/autodiff/StandardWellsDense_impl.hpp
View File

@ -230,6 +230,7 @@ namespace Opm {
}
updateWellControls(well_state);
updateGroupControls(well_state);
// Set the primary variables for the wells
setWellVariables(well_state);
@ -739,22 +740,6 @@ namespace Opm {
StandardWellsDense<TypeTag>::
setWellVariables(const WellState& xw)
{
const int nw = wells().number_of_wells;
// for two-phase numComp < numWellEq
const int numComp = numComponents();
for (int eqIdx = 0; eqIdx < numComp; ++eqIdx) {
for (int w = 0; w < nw; ++w) {
const unsigned int idx = nw * eqIdx + w;
assert( idx < wellVariables_.size() );
assert( idx < xw.wellSolutions().size() );
EvalWell& eval = wellVariables_[ idx ];
eval = 0.0;
eval.setValue( xw.wellSolutions()[ idx ] );
eval.setDerivative(numEq + eqIdx, 1.0);
}
}
for (auto& well_interface : well_container_) {
well_interface->setWellVariables(xw);
}
@ -950,10 +935,9 @@ namespace Opm {
++it;
if( localWellsActive() )
{
BVector dx_well (nw);
invDuneD_.mv(resWell_, dx_well);
updateWellState(dx_well, well_state);
for (auto& well : well_container_) {
well->wellEqIteration(ebosSimulator, param_, well_state);
}
}
// updateWellControls uses communication
// Therefore the following is executed if there
@ -961,6 +945,7 @@ namespace Opm {
if( wellsActive() )
{
updateWellControls(well_state);
updateGroupControls(well_state);
setWellVariables(well_state);
}
} while (it < 15);
@ -1246,23 +1231,6 @@ namespace Opm {
for (const auto& well : well_container_) {
well->updateWellControl(xw);
}
// TODO: group control has to be applied in the level of the all wells
// upate the well targets following group controls
// The following probably can go to a function
// it will not change the control mode, only update the targets
if (wellCollection()->groupControlActive()) {
applyVREPGroupControl(xw);
wellCollection()->updateWellTargets(xw.wellRates());
for (int w = 0; w < number_of_wells_; ++w) {
// TODO: check whether we need current argument in updateWellStateWithTarget
// maybe there is some circumstances that the current is different from the one
// in the WellState.
// while probalby, the current argument can be removed
const int current = xw.currentControls()[w];
well_container_[w]->updateWellStateWithTarget(current, xw);
}
}
}
@ -1703,6 +1671,33 @@ namespace Opm {
template<typename TypeTag>
void
StandardWellsDense<TypeTag>::
updateGroupControls(WellState& well_state) const
{
if (wellCollection()->groupControlActive()) {
applyVREPGroupControl(well_state);
wellCollection()->updateWellTargets(well_state.wellRates());
// TODO: group control has to be applied in the level of the all wells
// upate the well targets following group controls
// it will not change the control mode, only update the targets
for (int w = 0; w < number_of_wells_; ++w) {
// TODO: check whether we need current argument in updateWellStateWithTarget
// maybe there is some circumstances that the current is different from the one
// in the WellState.
// while probalby, the current argument can be removed
const int current = well_state.currentControls()[w];
well_container_[w]->updateWellStateWithTarget(current, well_state);
}
}
}
template<typename TypeTag>
typename StandardWellsDense<TypeTag>::EvalWell
StandardWellsDense<TypeTag>::